adding tests for new unique loggers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbovbel
approved these changes
Apr 17, 2018
ayrton04
approved these changes
Apr 17, 2018
|
Kicking the build farm. |
|
Oh, you are PR-ing into your other branch, and not into lunar-devel-locus. Was that intentional? |
|
Is this for 18.2? |
|
@ayrton04 this was a request upstream. I'm making the changes to the branch i am merging upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for unique throttler.
Tests confirm the expected behavior of the unique logger. Have run and confirmed tests do not fail. Will be making a second PR to our codebase so we don't have to remerge this branch. This PR is really for getting this shipped upstream