get full completion in cli completion download #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzhe-log10
commented
Aug 19, 2024
| @@ -270,7 +270,15 @@ def download_completions(limit, offset, timeout, tags, from_date, to_date, file) | |||
| fetched_total += new_data_size | |||
|
|
|||
| for completion in new_data: | |||
| output_file.write(json.dumps(completion) + "\n") | |||
| res = _get_completion(completion["id"]) | |||
There was a problem hiding this comment.
Completions()._get_completions() returns a list of completions with a compact info, such as last messages instead of full.
_get_completion(id) get the full completion by id with all messages.
So after we get the list of completions, we do a get for each of the ids for the full completion to save.
There was a problem hiding this comment.
vercel has limitation on how much data we can return, so we had to trim them. Otherwise, it would cause the request to failed 😞
kxtran
reviewed
Aug 19, 2024
| output_file.write(json.dumps(completion) + "\n") | ||
| res = _get_completion(completion["id"]) | ||
| if res.status_code != 200: | ||
| rich.print(f"Error fetching completion {completion['id']}") |
There was a problem hiding this comment.
should we mention here to ask them to retry and then contact us for additional support?
wenzhe-log10
deleted the
wenzhe/eng-1044-debug-cli-completions-download-partial-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.