Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get full completion in cli completion download #272

Merged
merged 1 commit into from
Aug 19, 2024
Merged

get full completion in cli completion download #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion log10/cli/completions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,15 @@ def download_completions(limit, offset, timeout, tags, from_date, to_date, file)
fetched_total += new_data_size

for completion in new_data:
output_file.write(json.dumps(completion) + "\n")
res = _get_completion(completion["id"])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completions()._get_completions() returns a list of completions with a compact info, such as last messages instead of full.
_get_completion(id) get the full completion by id with all messages.
So after we get the list of completions, we do a get for each of the ids for the full completion to save.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vercel has limitation on how much data we can return, so we had to trim them. Otherwise, it would cause the request to failed 😞

if res.status_code != 200:
rich.print(f"Error fetching completion {completion['id']}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention here to ask them to retry and then contact us for additional support?

continue
if not res.json().get("data", {}):
rich.print(f"Completion {completion['id']} is empty")
continue
full_completion_data = res.json()["data"]
output_file.write(json.dumps(full_completion_data) + "\n")

elapsed_time = time.time() - start_time
rate = fetched_total / elapsed_time if elapsed_time > 0 else 0
Expand Down
Loading