Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover more VS versions when building in CI #77

Closed
yupferris opened this issue Jul 24, 2021 · 0 comments · Fixed by #78
Closed

Cover more VS versions when building in CI #77

yupferris opened this issue Jul 24, 2021 · 0 comments · Fixed by #78

Comments

@yupferris
Copy link
Member

We currently only build with Visual Studio 2013, yet most of our userbase is currently using 2019 iirc, or at the very least, 2015/2017. Ideally we'd have all of these covered.
yupferris added a commit to yupferris/WaveSabre that referenced this issue Jul 24, 2021
@yupferris
CI: Specify multiple VS images
fd2dea6 
All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important.

Fixes logicomacorp#77.
@yupferris yupferris mentioned this issue Jul 24, 2021
Merged
yupferris added a commit that referenced this issue Jul 24, 2021
@yupferris
CI: Specify multiple VS images
e0bd1a0 
All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important.

Fixes #77.
tagsemb pushed a commit to tagsemb/WaveSabre that referenced this issue Apr 4, 2023
@yupferris @tagsemb
CI: Specify multiple VS images
aca0a33 
All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important.

Fixes logicomacorp#77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Specify multiple VS images yupferris/WaveSabre
1 participant
@yupferris