CI: Specify multiple VS images #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems 2013, 2017, and 2019 all build without issues, and 2015 seems to have some missing symbols (details here). I have no intention of fixing these issues, especially for older VS versions, so I think the right move for now is to just remove it from the list (effectively only officially support the other 3) and make a separate issue for it, and someone else can fix it if they want to. Frankly I think nobody using WS actually cares about anything other than VS 2019 anyways (or later versions in the future), so we should be good. |
|
Spawned #79. |
All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important. Fixes logicomacorp#77.
yupferris
force-pushed
the
ci-vs-versions
branch
from
6348e3a to
fd2dea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important.
Fixes #77.