flush codec after decode #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
Mar 22, 2018
spec/inputs/http_spec.rb
Outdated
| @@ -145,6 +146,20 @@ def do_post | |||
| end | |||
| end | |||
|
|
|||
| context "with json_lines codec without final delimiter" do | |||
| subject { LogStash::Inputs::Http.new("port" => port, "codec" => "json_lines") } | |||
There was a problem hiding this comment.
can't we test this with line codec so we don't have to rely on a new feature of json_lines?
There was a problem hiding this comment.
yeah I guess so.
|
@jsvd as you suggested I switched to the line codec, good suggestion. |
jsvd
approved these changes
Mar 22, 2018
|
restarted build - seems like the build issues are now solved. |
|
Green. Will squash, bump version, merge and publish. |
remove local tweak to gemfile use line codec instead of json_lines
colinsurprenant
force-pushed
the
flush_codec
branch
from
9a6dfad to
51177d6
Compare
|
actually - I will create another PR for the version bump since it will also reference #80. |
Merged
|
version bump PR in #82 |
|
This has been released in v3.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on logstash-plugins/logstash-codec-json_lines#35
The http input only accepts self-contained payload for each request and multipart is not supported. Because of this, we should always flush the codec after each request & codec decode calls to avoid situations where a delimited content missing a final delimiter, for example, would linger in the codec.
This is similar in nature to the discussion in elastic/logstash#8830 (comment)
Spec added to test this condition. Otherwise codec support is also well tested in the current spec.