Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use aws-sdk v3 #6

Closed
wants to merge 19 commits into from
Closed

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Apr 6, 2022

very naive approach to using aws-sdk v3. needs a lot of require cleanup

Introduce aws-sdk v3, by including the service-specific gems + aws-sdk-core v3, instead of adding the top level ask-sdk gem that would bring on > 300 dependencies.

This PR also removes the calls to eager loading as in aws-sdk v3 it's no longer necessary since we're loading the gems we need explicitly.

@jsvd jsvd requested a review from robbavey June 8, 2022 10:00
@jsvd
Copy link
Member Author

jsvd commented Jun 8, 2022

@robbavey I assigned you as a reviewer for this PR. It targets the bootstrap_work branch which is a refresh of your #1 + #3. In the bootstrap_work branch I tried have each commit be a logical change.
The use_aws_sdk_v3 branch does the remaining work on moving the integration to sdkv3, by mostly tweaking requires.

@christianherweg0807
Copy link

Hello @jsvd, I've released a pre-version, for testing purposes.
See: https://rubygems.org/gems/logstash-integration-aws

With this test release, I'll be able to test my own prerelease from logstash-input-s3-sns-sqs.
I´ll overhand the rubygems.org artefakt to you/elastic or delete my gem release.

regards
christian

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM - there are a few changes I'd like to see to the bootstrap work branch before we publish, but we can go through those separately to this PR.

@jsvd jsvd force-pushed the bootstrap_work branch from 91f4613 to ef7b8f6 Compare June 23, 2022 11:07
@jsvd jsvd deleted the branch logstash-plugins:bootstrap_work June 23, 2022 11:08
@jsvd jsvd closed this Jun 23, 2022
@jsvd jsvd mentioned this pull request Jun 23, 2022
@jsvd jsvd deleted the use_aws_sdk_v3 branch June 23, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants