-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use aws-sdk v3 #6
Conversation
@robbavey I assigned you as a reviewer for this PR. It targets the bootstrap_work branch which is a refresh of your #1 + #3. In the |
Hello @jsvd, I've released a pre-version, for testing purposes. With this test release, I'll be able to test my own prerelease from logstash-input-s3-sns-sqs. regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM - there are a few changes I'd like to see to the bootstrap
work branch before we publish, but we can go through those separately to this PR.
very naive approach to using aws-sdk v3. needs a lot of require cleanupIntroduce aws-sdk v3, by including the service-specific gems + aws-sdk-core v3, instead of adding the top level ask-sdk gem that would bring on > 300 dependencies.
This PR also removes the calls to eager loading as in aws-sdk v3 it's no longer necessary since we're loading the gems we need explicitly.