This repository was archived by the owner on Mar 25, 2020. It is now read-only.
Actually initialize the transport client as the correct impl class #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
force-pushed
the
fix_transport_initialization
branch
from
c5e6e9e to
005560a
Compare
|
LGTM, create an issue to rethink inheritance in this plugin. |
|
Thanks for the review @ph! |
|
Merged sucessfully into master! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we weren't actually ever instantiating Transport clients, just node ones.
We desperately need to refactor the Protocol class, but I'm not sure when. The code is confusing, and it uses inheritance where it is not called for. (which was the source of this bug)