Skip to content

Commit

Permalink
refactor(js, client): refresh token should be optional in RefreshToke… (
Browse files Browse the repository at this point in the history
#558)

* refactor(js, client): refresh token should be optional in RefreshTokenTokenResponse type

* chore: add changeset
  • Loading branch information
charIeszhao committed Sep 26, 2023
1 parent 21367b7 commit 05b9d3e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions .changeset/quiet-ducks-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@logto/client": patch
"@logto/js": patch
---

update "RefreshTokenTokenResponse" type in core JS SDK and set "refresh_token" field as optional
5 changes: 4 additions & 1 deletion packages/client/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,10 @@ export default class LogtoClient {
});

await this.saveAccessTokenMap();
await this.setRefreshToken(refreshToken);

if (refreshToken) {
await this.setRefreshToken(refreshToken);
}

if (idToken) {
await this.verifyIdToken(idToken);
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/core/fetch-token.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export type CodeTokenResponse = KeysToCamelCase<SnakeCaseCodeTokenResponse>;

type SnakeCaseRefreshTokenTokenResponse = {
access_token: string;
refresh_token: string;
refresh_token?: string;
id_token?: string;
scope: string;
expires_in: number;
Expand Down

0 comments on commit 05b9d3e

Please sign in to comment.