Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js, client): refresh token should be optional in RefreshToke… #558

Conversation

charIeszhao
Copy link
Member

…nTokenResponse type

Summary

According to RFC6749, the auth server MAY issue a refresh token, not always.

Testing

Checklist

  • .changeset
  • unit tests
    - [ ] integration tests
  • Updated SDK convention docs

OR

- [ ] This PR is not applicable for the checklist

@charIeszhao charIeszhao self-assigned this Sep 25, 2023
@linear
Copy link

linear bot commented Sep 25, 2023

LOG-6857 Update refresh token response type in JS SDKs

According to RFC6749, the server MAY issue a refresh token, not always.

@charIeszhao charIeszhao merged commit 05b9d3e into master Sep 26, 2023
2 checks passed
@charIeszhao charIeszhao deleted the charles-log-6857-update-refresh-token-response-type-in-js-sdks branch September 26, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants