Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: lottmapgen, stage 2 #1084

Open
5 of 10 tasks
alek13 opened this issue Jul 13, 2023 · 0 comments
Open
5 of 10 tasks

Refactoring: lottmapgen, stage 2 #1084

alek13 opened this issue Jul 13, 2023 · 0 comments
Labels
mapgen Связанное с генерацией ландшафта и биомов refactoring Касающееся крупной переработки имеющейся возможности

Comments

@alek13
Copy link
Member

alek13 commented Jul 13, 2023 •
edited
Loading

Частично вынесено из #1059

  • удалить fimadep (или заменить на что-то понятное, но вроде она не нужна)
  • дать нормальные названия переменным
  • добавить определение берега, дна и мелководья
  • lottmapgen: цикломатическая сложность #1058
    • вынести генерацию в отдеьный файл (там подключать конфиг)
  • вынести в конфиг (разнести по биомам) условия разбросанные по функциям
  • убрать дубдяж констант биомов
  • переименовать переменные с_*** в id_***
  • поправить подсказки luacheck (удалить из exclude_files в .luacheckrc)
  • уменьшиь цикломатическую сложность (удалить из .github/workflows/luacheck.yml)
@alek13 alek13 converted this from a draft issue Jul 13, 2023
This was referenced Jul 12, 2023
Closed
Open
@alek13 alek13 moved this to Todo in Генерация Jul 15, 2023
@alek13 alek13 mentioned this issue Jul 17, 2023
Closed
alek13 added a commit to alek13/lord that referenced this issue Jul 18, 2023
@alek13
MapGen: remove dead code. Relates to lord-server#1084, 1058
bf87a84
alek13 added a commit to alek13/lord that referenced this issue Jul 18, 2023
@alek13
MapGen: rename vars. Relates to lord-server#1084
572dd8d
@alek13 alek13 moved this from Todo to In Progress in Генерация Jul 18, 2023
@alek13 alek13 added refactoring Касающееся крупной переработки имеющейся возможности mapgen Связанное с генерацией ландшафта и биомов labels Jul 18, 2023
alek13 added a commit to alek13/lord that referenced this issue Jul 19, 2023
@alek13
MapGen: remove fimadep (make code mo readable). Relates to lord-ser…
f6bd430 
…ver#1084
@alek13 alek13 added this to the 2023.07 milestone Jul 19, 2023
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2023
@alek13
MapGen: add measure gen time on lua-side. Relates to lord-server#1084
f779917
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2023
@alek13
MapGen: simplify conditions; use constants. Relates to lord-server#1084
07f4d2d
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2023
@alek13
MapGen: extract is_sand_layer() detection. Relates to lord-server#1084
b1155a0
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2023
@alek13
MapGen: add detection of beach & shallow water. Relates to lord-serve…
f96e6b7 
…r#1084
@alek13 alek13 modified the milestones: 2023.07, next-milestone Aug 12, 2023
alek13 added a commit to alek13/lord that referenced this issue Feb 1, 2024
@alek13
Generation: rename vars c_*** into id_***. Relates lord-server#1084
febb486
alek13 added a commit to alek13/lord that referenced this issue Apr 2, 2024
@alek13
Extract voxel manipulations wraper minetest.with_map_part_do(). Rel…
82ed477 
…ates to lord-server#1084, lord-server#1058, lord-server#663, lord-server#661.
alek13 added a commit to alek13/lord that referenced this issue Apr 3, 2024
@alek13
Refactoring lottmapgen: fix luacheck errors. Relates to lord-server…
5f2dae2 
…#1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mapgen Связанное с генерацией ландшафта и биомов refactoring Касающееся крупной переработки имеющейся возможности
Projects
Генерация
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alek13