Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: lottmapgen #1059

Closed
11 of 17 tasks
alek13 opened this issue Jun 6, 2023 · 1 comment
Closed
11 of 17 tasks

Refactoring: lottmapgen #1059

alek13 opened this issue Jun 6, 2023 · 1 comment
Assignees
@alek13
Labels
mapgen Связанное с генерацией ландшафта и биомов refactoring Касающееся крупной переработки имеющейся возможности
Milestone
2023.06

Comments

@alek13
Copy link
Member

alek13 commented Jun 6, 2023 •
edited
Loading

  • поправить подсказки luacheck (удалить из exclude_files в .luacheckrc) (вфнесено в #1084)
  • именнованые константы биомов
  • вынести конфиг
  • lottmapgen: цикломатическая сложность #1058
    • вынести генерацию в отдеьный файл (вфнесено в #1084)
    • разнести по функциям
      • генерация над поверхностью (airspace)
      • генерация покрытия
      • генерация подземлёй
      • замена воды, камня, песка
      • и пр.
  • добавить замер генерации чанка, вычисление среднего (если указано в конфиге)
  • speed up:
    • вынести создание статических локальных переменных из ф-ций (functions.lua) (вфнесено в #1084)
    • использовать залинкованную область памяти для VoxelManip (где-то в доках натыкался) (вфнесено в #1084)
    • вынести получение ContentID при каждой итерации
    • заменить math.random и пр. на локальные
@alek13 alek13 converted this from a draft issue Jun 6, 2023
@alek13 alek13 added the refactoring Касающееся крупной переработки имеющейся возможности label Jun 6, 2023
@alek13 alek13 moved this from Todo to In Progress in Рефакторинг Jun 7, 2023
@alek13 alek13 self-assigned this Jul 5, 2023
@alek13 alek13 moved this to In Progress in Генерация Jul 5, 2023
alek13 added a commit to alek13/lord that referenced this issue Jul 5, 2023
@alek13
Refactoring lottmapgen: extract detect_current_biome(). Relates to …
f26c929 
…lord-server#1058, lord-server#1059
alek13 added a commit to alek13/lord that referenced this issue Jul 5, 2023
@alek13
Refactoring lottmapgen: add biome constants. Relates to lord-server…
6694336 
…#1059
@alek13 alek13 added the mapgen Связанное с генерацией ландшафта и биомов label Jul 7, 2023
alek13 added a commit to alek13/lord that referenced this issue Jul 9, 2023
@alek13
MapGen: Simplify code of grass caverage gen. Relates to lord-server#1059
cf497c1 
, lord-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 9, 2023
@alek13
Rename shadowing var. Relates to lord-server#1059, lord-server#1058
ad73af7
alek13 added a commit to alek13/lord that referenced this issue Jul 9, 2023
@alek13
Rename shadowing var. Relates to lord-server#1059, lord-server#1058
9b96592
alek13 added a commit to alek13/lord that referenced this issue Jul 9, 2023
@alek13
MapGen: Simplify code of "air" biome generation (flora, buildings). R…
a7e3e18 
…elates to lord-server#1059, lord-server#1058
@alek13 alek13 mentioned this issue Jul 9, 2023
Open
alek13 added a commit to alek13/lord that referenced this issue Jul 10, 2023
@alek13
MapGen: biome_fill_air(): remove up-value dependency. Relates to lo…
df704c7 
…rd-server#1059, lord-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 10, 2023
@alek13
MapGen: bring out flora/builings config & gen func biome_fill_air()…
1a5db76 
…. Relates to lord-server#1059, lord-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 10, 2023
@alek13
MapGen: add measure chunk gen time. Relates to lord-server#1059, lord…
4e0dfb5 
…-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 10, 2023
@alek13
MapGen: add measure chunk gen time. Relates to lord-server#1059, lord…
8e999b4 
…-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 11, 2023
@alek13
MapGen: replace func names with locals. Relates to lord-server#1059
4961ec4
alek13 added a commit to alek13/lord that referenced this issue Jul 11, 2023
@alek13
MapGen: bring out config & id vars from gen callback. Relates to lord…
127e3bd 
…-server#1059, lord-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 11, 2023
@alek13
MapGen: reduce vars quantity. Relates to lord-server#1059
a2fc002
alek13 added a commit to alek13/lord that referenced this issue Jul 11, 2023
@alek13
MapGen: reduce vars quantity. Relates to lord-server#1059
951ec79
alek13 added a commit to alek13/lord that referenced this issue Jul 11, 2023
@alek13
MapGen: extract config; remove unused global. Relates to lord-server#…
5f0f939 
…1059
@alek13 alek13 mentioned this issue Jul 13, 2023
Open
10 tasks
alek13 added a commit to alek13/lord that referenced this issue Jul 13, 2023
@alek13
MapGen: just reformat. Relates to lord-server#1059
4ed6bae
alek13 added a commit to alek13/lord that referenced this issue Jul 13, 2023
@alek13
MapGen: extract functions (improve readability, reduce cyclomatic com…
c1a5859 
…plexity). Relates to lord-server#1059, lord-server#1058
alek13 added a commit to alek13/lord that referenced this issue Jul 13, 2023
@alek13
MapGen: use constants for biome detection. Relates to lord-server#1059
a37d6b3
@alek13
Copy link
Member Author

alek13 commented Jul 13, 2023

остальное вынесено во второй этап #1084

@alek13 alek13 closed this as completed Jul 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Генерация Jul 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Рефакторинг Jul 13, 2023
@alek13 alek13 added this to the 2023.06 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
mapgen Связанное с генерацией ландшафта и биомов refactoring Касающееся крупной переработки имеющейся возможности
Projects
Генерация
Status: Done
Рефакторинг
Status: Done
Milestone
2023.06
Development

No branches or pull requests
1 participant
@alek13