Fix search #88
Closed
Fix search #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add link to Studienordnung * Clean up
* Use tailwind classes
* Add Module from Focus * Use constructor * Adding from Focus works * Basic functionality * Move Categories to own component * Style button for focus * Style button * Clean up * Add toggle for validation * Styling * Disable semester button * Work on validation, need data store * Introduce store * Get validation working * WIP * Add validation for semester * Validation * Style errors * Add global validation info * Validation and actions work * Fix todo * Fix lint * Rename * Clean up * Fixes * Fix lint
* Add Module from Focus * Use constructor * Adding from Focus works * Basic functionality * Move Categories to own component * Style button for focus * Style button * Clean up * Add toggle for validation * Styling * Disable semester button * Work on validation, need data store * Introduce store * Get validation working * WIP * Add validation for semester * Validation * Style errors * Add global validation info * Validation and actions work * Fix todo * Fix lint * Rename * Clean up * Fixes * Add search * Fix lint * Clean * Search by id * Make switch and alert stick * Lint
* Store accredited modules in url * Add accredited module * Fix bug * WIP * Validate accredited modules * Store accredited modules properly * Include in cateogires * WIP * Clean * Lint * Move button * Fix dropdown in modal for Chrome * Show label * Show feedback for error in name * Set focus * Add comment and rename * Fix scroll * Add class * Sort cats * Fixes * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add a module, when another one with same name existed (e.g. Wireless and IoT) could result in the wrong one being added. We now use the id instead of the name.