Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default default_adapter (yes, you read that right) #1354

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Dec 29, 2021

Description

  • Remove default Faraday.default_adapter value and add exception message with a link to usage documentation.
  • Simplify RackBuilder internal logic and remove #build delegator from Connection (should not be used externally)

Fixes #1352

…age with link to usage documentation.

* Simplify RackBuilder internal logic and remove `#build` delegator from Connection (should not be used externally)
@iMacTia iMacTia requested a review from olleolleolle December 29, 2021 17:22
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error : no stubbed request for get
2 participants