Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.1 #8

Merged
merged 2 commits into from
May 20, 2022
Merged

Support Ruby 3.1 #8

merged 2 commits into from
May 20, 2022

Conversation

NagayamaRyoga
Copy link

Faraday.default_adapter is nil by default in v2.0.0 (lostisland/faraday#1354)

@hirosassa hirosassa requested review from ma2gedev and snowhork January 5, 2022 07:49
Copy link

@snowhork snowhork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@ma2gedev ma2gedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, though I left the tiny comment.

@@ -1,4 +1,4 @@
source 'https://rubygems.org'

gem 'faraday', '~> 0.8.8'
gem 'faraday', '~> 0.8.8', '< 2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: It seems we can remove this file because tests on CI run against only Gemfile.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this file

@@ -11,14 +11,16 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: [ '2.6', '2.7', '3.0' ]
ruby-version: [ '2.6', '2.7', '3.0', '3.1' ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@rst76 rst76 merged commit 9187c20 into m3dev:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants