-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ruby 3.1 #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, though I left the tiny comment.
gemfiles/faraday-0_8_8.gemfile
Outdated
@@ -1,4 +1,4 @@ | |||
source 'https://rubygems.org' | |||
|
|||
gem 'faraday', '~> 0.8.8' | |||
gem 'faraday', '~> 0.8.8', '< 2.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: It seems we can remove this file because tests on CI run against only Gemfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this file
@@ -11,14 +11,16 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
ruby-version: [ '2.6', '2.7', '3.0' ] | |||
ruby-version: [ '2.6', '2.7', '3.0', '3.1' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🎉
Faraday.default_adapter
isnil
by default in v2.0.0 (lostisland/faraday#1354)