Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for pagination doesn't contain numbers #791

Closed
Saibamen opened this issue Oct 24, 2021 · 9 comments · Fixed by #809
Closed

Translations for pagination doesn't contain numbers #791

Saibamen opened this issue Oct 24, 2021 · 9 comments · Fixed by #809
Labels
bug Something isn't working

Comments

@Saibamen
Copy link
Contributor

Saibamen commented Oct 24, 2021

Is it a duplicated question?
No

Describe the bug
Translations for pagination doesn't contain numbers

To Reproduce
Steps to reproduce the behavior:

  1. Go to dashboard
  2. Scroll to the bottom
  3. See Showing to of records

Expected behavior
Showing X to Y of Z records

Info
Uptime Kuma Version:
Using Docker?: No
Docker Version: --
Node.js Version (Without Docker only): 14.17.3
OS: Windows
Browser: Chrome

Screenshots
image

CC: @cmandesign (i18n for pagination was added in #487)

@Saibamen Saibamen added the bug Something isn't working label Oct 24, 2021
@Saibamen
Copy link
Contributor Author

Saibamen commented Oct 24, 2021

Changed
"Showing {from} to {to} of {count} records"
to
"Showing {{from}} to {{to}} of {{count}} records"
image

so the i18n keys are correct, but how to fix rendering?

@gaby
Copy link
Contributor

gaby commented Oct 24, 2021

I don't even think these are necessary. Look how clean Google looks without any data below the page numbers:

image

@Saibamen
Copy link
Contributor Author

matfish2/vue-pagination-2#83

Without count:
image

@gaby
Copy link
Contributor

gaby commented Oct 24, 2021

That looks way better. The arrows should also be simplify.

Comparing to Google's design.

  • The left arrows shouldn't be render if on Page 1.
  • Same applies if there's only 1 page, don't render the arrows.

@Saibamen
Copy link
Contributor Author

Saibamen commented Oct 24, 2021

For this we should implement own template (https://github.com/matfish2/vue-pagination-2/tree/vue3#custom-template)

Now I just added chunksNavigation: "scroll", option:
image

@deefdragon
Copy link
Contributor

  • The left arrows shouldn't be render if on Page 1.
  • Same applies if there's only 1 page, don't render the arrows.

I prefer disabling/greying out instead of not rendering. It makes it easy to keep your mouse in the same place when navigating the pages. It might not be reasonable given the minor difference between disabled and enabled in UK tho.

@chakflying
Copy link
Collaborator

I guess we can make it opacity: 0 so that it still takes up the same space. I agree that the difference between active and disabled is not very clear.

@Saibamen
Copy link
Contributor Author

I was waiting for #790 to delete lang keys

I will create PR today

@Saibamen
Copy link
Contributor Author

PR: #809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants