Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display "count" text for pagination #809

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

Saibamen
Copy link
Contributor

Description

Fixes #791

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User Interface
  • Translation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

Before

image

After

image

@louislam
Copy link
Owner

I would like to keep language keys, I believe it is useful for later development.

Just need to drop the keys of en.js

@Saibamen
Copy link
Contributor Author

IMO this should be deleted. I don't see a place where these pagination-specific i18n keys should be used.

records: "records",
"One record": "One record",
"Showing {from} to {to} of {count} records": "Showing {from} to {to} of {count} records",

@louislam
Copy link
Owner

louislam commented Oct 28, 2021

Recap from #518 (comment)

It is no harm to keep the unused language key. It can be used in the future and it is the work of other contributors. I suggest that it should be kept.

The records and One record could be possible to be reused again.

And I would agree with you if it is not an open source project, because I could pay my programmers and translators to do it again if I need this.

However, it is an open source project. If I need these keys in the future, retrieving them back from git history would be hard and spend my time. Also it is not easy to find translators to do it again.

@Saibamen
Copy link
Contributor Author

Done

@louislam louislam merged commit 5311bef into louislam:master Oct 29, 2021
@Saibamen Saibamen deleted the pagination_no_text branch October 29, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations for pagination doesn't contain numbers
2 participants