Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PL update + fixes #790

Merged
merged 4 commits into from
Oct 26, 2021
Merged

PL update + fixes #790

merged 4 commits into from
Oct 26, 2021

Conversation

Saibamen
Copy link
Contributor

Description

PL update + fixes:

  • Add missing i18n for Auto Get
  • Run ESLint on all languages
  • Remove : for "Monitor History" key. We don't have punctuations in headers in Settings page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User Interface
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation update
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them

@Saibamen
Copy link
Contributor Author

CC: @kry008, @zsxeee, @atlochowski, @nixnotcastey, @Misly16

PopcornPanda
PopcornPanda approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@PopcornPanda PopcornPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove dot from needPushEvery. Other interval descriptions doesn't end with period, but it's not necessary.

@Saibamen Saibamen mentioned this pull request Oct 25, 2021
Merged
12 tasks
@louislam louislam merged commit 16846c7 into louislam:master Oct 26, 2021
@Saibamen Saibamen deleted the pl_update+fixes branch October 26, 2021 09:21
@Saibamen Saibamen mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PopcornPanda PopcornPanda PopcornPanda approved these changes

@zsxeee zsxeee zsxeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saibamen @zsxeee @PopcornPanda @louislam