A11y - Updated input with no label. #2150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computroniks
suggested changes
Oct 1, 2022
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
|
Should we use |
| @@ -10,7 +10,7 @@ | |||
| <font-awesome-icon icon="times" /> | |||
| </a> | |||
| <form> | |||
| <input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" /> | |||
| <input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" aria-label="Search monitored sites" /> | |||
There was a problem hiding this comment.
What do you think about such a change (plus adding this to the translation file(s) you can)
Suggested change
| <input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" aria-label="Search monitored sites" /> | |
| <input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" :aria-label="$t('Search monitored sites')" /> |
There was a problem hiding this comment.
On my side, i agree with this suggestion.
CommanderStorm
added
the
area:accessibility
7 tasks
|
Closing this PR in favor of #4163, as I don't think the requested/suggested changes will be implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Updated search form input that is missing label. Added aria-label as no valid label in document. Aria-label documentation
Fixes #(issue)
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.