Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y - Updated input with no label. #2150

Closed
wants to merge 2 commits into from
Closed

A11y - Updated input with no label. #2150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e425edc
a11y - Add aria label to monitored sites search input
ibrouos Oct 1, 2022
753f125
Update src/components/MonitorList.vue
ibrouos Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MonitorList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<font-awesome-icon icon="times" />
</a>
<form>
<input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" />
<input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" aria-label="Search monitored sites" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about such a change (plus adding this to the translation file(s) you can)

Suggested change
<input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" aria-label="Search monitored sites" />
<input v-model="searchText" class="form-control search-input" :placeholder="$t('Search...')" autocomplete="off" :aria-label="$t('Search monitored sites')" />

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side, i agree with this suggestion.

</form>
</div>
</div>
Expand Down