-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xml support to HTTP monitors #2610
Add xml support to HTTP monitors #2610
Conversation
…port-to-http-monitors # Conflicts: # server/database.js # server/model/monitor.js # src/languages/en.js
@louislam , @JustinTisdale commits are protected as we speak. Can we go live? |
Should users be able to override the contentType by setting custom headers? |
Custom headers should be the higher priority. |
How should we continue? Is the current state enough? |
How can we advance the process this pr? @louislam @chakflying |
…port-to-http-monitors
How should we continue the process as there are some friends waiting for this? @louislam @chakflying |
…port-to-http-monitors
…port-to-http-monitors # Conflicts: # src/languages/en.js
…port-to-http-monitors # Conflicts: # server/database.js # server/model/monitor.js
…port-to-http-monitors
…port-to-http-monitors
…port-to-http-monitors
…port-to-http-monitors # Conflicts: # src/lang/en.json
…port-to-http-monitors
…port-to-http-monitors # Conflicts: # server/database.js # src/lang/en.json
…port-to-http-monitors
Thank you very much for your attention. I have good news, fixed them! @louislam |
…port-to-http-monitors
Some History: Originally xml/form data implementation was started by #1987, but it was abandoned and unfinished for a long time. Then @bayramberkay and @Genc wanted to implement xml and used #1987's code. The form data implementation is never existed in any previous versions of Uptime Kuma. The commit 3adc9e6 was just removing those unfinished code only. |
I have created this PR that should be ready to merge that will add x-www-form-urlencoded requests - #3499 |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
There is an existing pr request but I guess it hasn't been active for a long time. That's why I just wanted to make a pr request by copy-pasting the xml part. I think it will help most people waiting for this feature.
Fixes #(issue)
#1679
#1332
#1987
#2497
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)