Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding x-www-form-urlencoded #3499

Conversation

anderskvist
Copy link
Contributor

@anderskvist anderskvist commented Jul 28, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adding x-www-form-urlencoded to allow monitors to login via webforms.
Resolves #1351
Resolves #1332

Depends on #3498 as that fixes issue with anything but HTTP monitors that tries to use XML or x-www-form-urlencoded.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing a part of the frontend:

This is the UI of f.ex. Postman:
image

This PR looks like this:
image

I think you are also missing the part where this is urlencoding the string (which differentiates form-data from x-www-form-urlencoded)

@anderskvist
Copy link
Contributor Author

@CommanderStorm Didn't see your message, but I actually just added this example :D

Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@CommanderStorm
Copy link
Collaborator

Could you add the following to the description:
Resolves #1351
Resolves #1332

@KvistA-ELS
Copy link

@louislam thanks for adding this to the 2.0.0 milestone - please also include #3498 as that makes this usable (along with XML). And when is 2.0.0 expected?

Copy link
Contributor

@Computroniks Computroniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

src/pages/EditMonitor.vue Outdated Show resolved Hide resolved
@louislam louislam merged commit f0c54be into louislam:master Sep 9, 2023
@foliovision
Copy link

Hello @louislam

It's too bad this is not part of 1.23.2 release.

Any idea when version 2.0.0 will be out? Is this really a big change that could not go to 1.23.3?

Please let us know.

Thanks,
Martin

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Sep 27, 2023

@foliovision Please refrain from unnessesary pings
You can folow #4500 or subscribe for releases for furhter context.

Any idea when version 2.0.0 will be out

As any sane open source repository we don't work under deadlines.
See the tracking milestone for the progress.

Is this really a big change that could not go to 1.23.3?

the v1 series will only recieve bug fixes as by our policy laied out here:
https://github.com/louislam/uptime-kuma/releases/tag/1.23.0

Given that this is a feature, this will be inluded in the v2 release and no special release will be drafted for this.

@anderskvist anderskvist deleted the kvist/adding_x-www-form-urlencoded_httpBodyEncoding branch December 30, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants