Add translation key for time ago and related strings
#4400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Frank Elsinga <frank@elsinga.de>
CommanderStorm
requested changes
Jan 21, 2024
Comment on lines
+189
to
+191
| return (seconds / 60).toFixed(0) + "m"; | ||
| } else { | ||
| return (seconds / 60 / 60).toFixed(0) + "h ago"; | ||
| return (seconds / 60 / 60).toFixed(0) + "h"; |
There was a problem hiding this comment.
Please add a translation instead of just removing it, or am I missing something? ^^
There was a problem hiding this comment.
Because I wanted to do it like the beginning of the bar and add the key "ago." However, I realized that by doing this, both the "now" key was also displayed
There was a problem hiding this comment.
So I deleted it to leave only the 'now' or '1m' at the end without displaying the 'ago'
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
|
|
Although I suppose we could just increase the value to be much larger than necessary to be safe. |
github-actions
bot
added
pr:please resolve merge conflict
github-actions
bot
removed
the
pr:please resolve merge conflict
6 tasks
|
Rebased this PR in #4813 to remove the uninteded changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Add translation keys
Fixes #(issue)
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.