Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation key for time ago #4813

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Add translation key for time ago #4813

merged 3 commits into from
Aug 24, 2024

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Add translation keys

Originally, this was raised in #4400 but said PR had a bad rebase.
Doing this one cleanly is simpler

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

image

@CommanderStorm CommanderStorm added area:dashboard The main dashboard page where monitors' status are shown pr:needs review this PR needs a review by maintainers or other community members labels Jun 3, 2024
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jun 3, 2024
@CommanderStorm
Copy link
Collaborator Author

The main reason the heartbeat time indication was not translated, is because "the minimum width of heartbeats where the time indication should be displayed" is a fixed value. If the text can be translated, this width becomes variable. I don't see an easy way of handling this.

Although I suppose we could just increase the value to be much larger than necessary to be safe.

This is the closest i can push the values and the longest that they can be (after that, they merge into one long string):
image

=> I don't think this will actually be an issue or am I missing something @chakflying

src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
@CommanderStorm
Copy link
Collaborator Author

Given that this is just a translation, I am going to skip a review for this one.
A self-review is likely fine for this ^^

Copy link
Collaborator Author

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed formatting

src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
src/components/HeartbeatBar.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm merged commit bde3d0e into master Aug 24, 2024
18 checks passed
@CommanderStorm CommanderStorm deleted the cyril59310/master branch August 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown house keeping pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants