Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make sure browser is connected before returning #4417

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Maybe Fixes #4373, but haven't tried to reproduce it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 24, 2024

From glancing at it, it seems you found the bug of a missing await in #4418
=> is this not more likely?
are there cases where we can be not connected but have a browser anyhow?

@chakflying
Copy link
Collaborator Author

Remote browser should not be available in 1.23.X if I remember correctly.

@chakflying
Copy link
Collaborator Author

As to why it might be disconnected, I suppose there could be many reasons, like the OS killing the process because of OOM or it crashed because of some other reason. But I'm also not sure if the connected status would accurately reflect these situations.

@louislam louislam added this to the 1.23.12 milestone Jan 24, 2024
@louislam
Copy link
Owner

I believe so, hope isConnected() is trustworthy.

@louislam louislam merged commit 288cab6 into louislam:1.23.X Jan 24, 2024
14 checks passed
@chakflying chakflying deleted the fix/browser-connected branch February 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants