Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing await in getRemoteBrowser() #4418

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jan 24, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

After adding type definition in #4417, I found that browser should be of type Browser, but getRemoteBrowser() is trying to assign Promise<Browser> to it.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@chakflying chakflying changed the title Fix: missing await in getRemoteBrowser() Fix: missing await in getRemoteBrowser() Jan 24, 2024
@louislam louislam merged commit cf075a8 into louislam:master Jan 25, 2024
17 checks passed
@chakflying chakflying deleted the fix/remote-browser-return-type branch February 1, 2024 12:55
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants