Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

make docker-build and make docker do not work on 9.0.2 branch #541

Closed
werdnum opened this issue Apr 24, 2020 · 2 comments · Fixed by #638
Closed

make docker-build and make docker do not work on 9.0.2 branch #541

werdnum opened this issue Apr 24, 2020 · 2 comments · Fixed by #638

Comments

@werdnum
Copy link

werdnum commented Apr 24, 2020

make docker-build does not work, because it is hardcoded to Go 1.10, which doesn't seem to have support for pulling dependencies. Updating GOVERSION to 1.14.2 in Makefile does the trick.

make docker does not work because there is no Dockerfile.

A minimal working Dockerfile might look like this (if you add the static target as a dependency for docker in Makefile)

FROM alpine:3.11
ADD bin/keycloak-gatekeeper /usr/bin/keycloak-gatekeeper
ENTRYPOINT /usr/bin/keycloak-gatekeeper
@jangaraj
Copy link
Contributor

You don't even need FROM alpine:3.11. Make static binary and you can use FROM scratch.

@ASzc
Copy link
Contributor

ASzc commented Jun 12, 2020

Should be addressed by #638

abstractj pushed a commit that referenced this issue Jun 15, 2020
I ended up rewriting a good portion of the Dockerfile. It now uses a
multi-stage build. It can accept source code to build, or unpack a premade
binary.

I also updated the Makefile

Fixes #609
Fixes #541
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants