This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Migrate the codebase from Gatekeeper repository #516 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianst
suggested changes
May 5, 2020
CONTRIBUTING.md
Outdated
|
|
||
| We do have a few guidelines in place to help you be successful with your contribution. | ||
|
|
||
| Here's a quick checklist for a good PR, more details below: | ||
|
|
||
| 1. [Keycloak Dev Mailing List](https://groups.google.com/forum/#!forum/keycloak-dev) | ||
| 1. [Louketo Dev Mailing List](https://groups.google.com/forum/#!forum/louketo) |
There was a problem hiding this comment.
Suggested change
| 1. [Louketo Dev Mailing List](https://groups.google.com/forum/#!forum/louketo) | |
| 1. [Louketo Mailing List](https://groups.google.com/forum/#!forum/louketo) |
CONTRIBUTING.md
Outdated
| issues that are awaiting contributions in the | ||
| [Keycloak JIRA](https://issues.jboss.org/projects/KEYCLOAK/versions/12340167). | ||
| [Louketo JIRA](https://issues.jboss.org/projects/Louketo/versions/12340167). |
There was a problem hiding this comment.
Suggested change
| [Louketo JIRA](https://issues.jboss.org/projects/Louketo/versions/12340167). | |
| [GitHub Issues](https://github.com/louketo/louketo-proxy/issues). |
CONTRIBUTING.md
Outdated
|
|
||
| ### Open a discussion on Keycloak Dev Mailing List | ||
| ### Open a discussion on Louketo Dev Mailing List |
There was a problem hiding this comment.
Suggested change
| ### Open a discussion on Louketo Dev Mailing List | |
| ### Open a discussion on Louketo Mailing List |
CONTRIBUTING.md
Outdated
| As Keycloak is a community-driven project we require contributors to send a description of what they are planning to | ||
| work on to the [Keycloak Dev Mailing List](https://groups.google.com/forum/#!forum/keycloak-dev). | ||
| As Louketo is a community-driven project we require contributors to send a description of what they are planning to | ||
| work on to the [Louketo Dev Mailing List](https://groups.google.com/forum/#!forum/Louketo-dev). |
There was a problem hiding this comment.
Suggested change
| work on to the [Louketo Dev Mailing List](https://groups.google.com/forum/#!forum/Louketo-dev). | |
| work on to the [Louketo Mailing List](https://groups.google.com/forum/#!forum/Louketo-dev). |
CONTRIBUTING.md
Outdated
|
|
||
| ### Create an issue in Keycloak JIRA | ||
| ### Create an issue in Louketo JIRA |
There was a problem hiding this comment.
Suggested change
| ### Create an issue in Louketo JIRA | |
| ### Create an issue in GitHub Issues |
CONTRIBUTING.md
Outdated
| @@ -82,5 +82,5 @@ for more details. | |||
| The above helps us review your PR and also makes it easier for us to maintain the repository. It is also required by | |||
| our automatic merging process. | |||
|
|
|||
| We also require that the commit message is prefixed with the Keycloak JIRA issue number (example commit message | |||
| "KEYCLOAK-9876 My super cool new feature"). | |||
| We also require that the commit message is prefixed with the Louketo JIRA issue number (example commit message | |||
There was a problem hiding this comment.
Suggested change
| We also require that the commit message is prefixed with the Louketo JIRA issue number (example commit message | |
| We also require that the commit message is prefixed with the GitHub issue number (example commit message |
CONTRIBUTING.md
Outdated
| We also require that the commit message is prefixed with the Keycloak JIRA issue number (example commit message | ||
| "KEYCLOAK-9876 My super cool new feature"). | ||
| We also require that the commit message is prefixed with the Louketo JIRA issue number (example commit message | ||
| "Louketo-9876 My super cool new feature"). |
There was a problem hiding this comment.
Suggested change
| "Louketo-9876 My super cool new feature"). | |
| "602 My super cool new feature"). |
Co-authored-by: Stian Thorgersen <stian@redhat.com>
|
@stianst thanks for reviewing. Ready for another round. |
stianst
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past month, we discussed the idea of having a new home for Gatekeeper, based on that we decided to create a new
organization on GitHub and rename the project to Louketo Proxy.
This pull request refactors the codebase to the new name and should be merged only after the transfer
of the repository.
Some considerations
make docker-buildandmake dockerdo not work on 9.0.2 branch #541.