Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sw/silicon_creator] EXPECT_DEATH instead of ASSERT_DEATH in unit tests #10549

Closed
alphan opened this issue Feb 2, 2022 · 0 comments · Fixed by #10698
Closed

[sw/silicon_creator] EXPECT_DEATH instead of ASSERT_DEATH in unit tests #10549

alphan opened this issue Feb 2, 2022 · 0 comments · Fixed by #10698
Assignees
@alphan
Labels
Component:Software Issue related to Software Type:Cleanup Cleanup tasks

Comments

@alphan
Copy link
Contributor

alphan commented Feb 2, 2022

Nit: this can be EXPECT.

Originally posted by @mcy in #10522 (comment)
@alphan alphan self-assigned this Feb 2, 2022
@alphan alphan added Type:Cleanup Cleanup tasks Component:Software Issue related to Software labels Feb 2, 2022
@alphan alphan mentioned this issue Feb 2, 2022
Merged
alphan added a commit to alphan/opentitan that referenced this issue Feb 8, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
37d165a 
Fixes lowRISC#10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
alphan added a commit to alphan/opentitan that referenced this issue Feb 8, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
e8ea572 
Fixes lowRISC#10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
alphan added a commit to alphan/opentitan that referenced this issue Feb 8, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
fef18ef 
Fixes lowRISC#10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
alphan added a commit to alphan/opentitan that referenced this issue Feb 8, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
f090957 
Fixes lowRISC#10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
@alphan alphan mentioned this issue Feb 8, 2022
Merged
alphan added a commit to alphan/opentitan that referenced this issue Feb 9, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
30b8f67 
Fixes lowRISC#10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
alphan added a commit that referenced this issue Feb 11, 2022
@alphan
[sw/silicon_creator] Use EXPECT_DEATH in unit tests
4907768 
Fixes #10549

Signed-off-by: Alphan Ulusoy <alphan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphan alphan

Labels
Component:Software Issue related to Software Type:Cleanup Cleanup tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sw/silicon_creator] Harden SHUTDOWN_IF_ERROR alphan/opentitan
1 participant
@alphan