[rom_ctrl, dv] Excluded line coverage for prim_generic** blocks #25706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signals are tied to parameters inside the instantiations landing as line coverage hole inside the reports. Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
rom_ctrl_code_cov
branch
from
6afbd56 to
958cc5a
Compare
rswarbrick
reviewed
Dec 19, 2024
| @@ -39,6 +39,15 @@ Block 1 "3318159292" "data_o = 39'(data_i);" | |||
| INSTANCE: tb.dut.u_tl_adapter_rom.u_tlul_data_integ_enc_instr.u_data_gen | |||
| Block 1 "3318159292" "data_o = 39'(data_i);" | |||
|
|
|||
| INSTANCE: tb.dut.gen_rom_scramble_enabled.u_rom.u_rom.u_prim_rom.gen_generic.u_impl_generic | |||
| ANNOTATION: "cfg_i is tied to 0 in tb" | |||
There was a problem hiding this comment.
I think this needs to be rom_cfg_i (which is the name it has as a dut port). I'd probably also:
- Say something like "We expect this port to be wired to a constant."
- Add an assertion in
rom_ctrl.svthat says this is constant. Maybe something likeASSERT(CfgStable_A, $stable(rom_cfg_i))?
rswarbrick
reviewed
Dec 19, 2024
| Block 1 "118728425" "assign unused_cfg = (^cfg_i);" | ||
|
|
||
| INSTANCE: tb.dut.gen_rom_scramble_enabled.u_rom.u_seed_anchor.u_secure_anchor_buf.gen_generic.u_impl_generic | ||
| ANNOTATION: "in_i and out_o are tied to parameters" |
There was a problem hiding this comment.
I think this needs expanding a little to make it "less local". I'd probably suggest something like: "The u_seed_anchor module is a buffer whose inputs are constant because they are tied to parameters. As a result, this continuous assignment line cannot see execution."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.