[top_darjeeling] Instantiate AC Range checks #25862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
hcallahan-lowrisc,
moidx,
rswarbrick,
andreaskurth and
vogelpi
and removed request for
a team,
cfrantz,
hcallahan-lowrisc and
moidx
rswarbrick
reviewed
Jan 14, 2025
|
I don't think splitting up makes sense. The one big commit instantiates the ac ranges on the HJSON (5 lines or so) and this triggers ipgen to copy over the IP. If we split it up, there would be inconsistent IPs |
Razer6
force-pushed
the
ac-ranges-instance
branch
from
4066f22 to
112e519
Compare
|
@rswarbrick @vogelpi Since #25894 is merged, this now correctly maps the AC ranges. Can you take another look? |
Razer6
force-pushed
the
ac-ranges-instance
branch
2 times, most recently
from
6825009 to
63305a4
Compare
Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
This adds a base address translation (BAT) on the muxed host TLUL port before exiting to the AC ranges. This BAT removes the 1-2GB offset and downlifsts the address to 0-1GB when exiting. Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Razer6
force-pushed
the
ac-ranges-instance
branch
from
17c5cb1 to
c9e2994
Compare
a-will
reviewed
Jan 23, 2025
There was a problem hiding this comment.
A thought for the future: Perhaps we'll want to formally introduce a TL-UL to TL-UL bus bridge with base address translation in hw/ip/tlul at some point. Then we can extend topgen / tlgen and do traversals to understand reachability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR instantiates the AC ranges for a single egress port. All Egress ports are muxed to a single egress port before leaving Darjeeling. An additional external miscellaneous port is added to the system that is coming from the external uncore but muxed with same mux and going through the AC ranges.