Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RACL] Add raclgen (tool to generate RACL selection vectors for out-of-topgen flows) #25973

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

davidschrammel
Copy link
Contributor

@davidschrammel davidschrammel commented Jan 22, 2025

This PR is based on #25749 and adds a command line utility for RACL.

raclgen is a tool to compute RACL selection vector and used for out-of-topgen flows to hookup an IP with the distributed policy vector.

All but the last 2 commits are from #25749 and will be dropped once that PR has been merged.

@davidschrammel davidschrammel requested review from Razer6, rswarbrick, vogelpi and matutem and removed request for msfschaffner January 22, 2025 13:56
@davidschrammel davidschrammel force-pushed the racl-gen branch 2 times, most recently from 8dae8c6 to ca8afba Compare January 22, 2025 14:23
@davidschrammel davidschrammel changed the title [RACL] Add raclgen [RACL] Add raclgen (tool to generate RACL selection vectors for out-of-topgen flows) Jan 22, 2025
Copy link
Member

@Razer6 Razer6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidschrammel! This looks good to me.

util/raclgen.py Show resolved Hide resolved
util/raclgen.py Show resolved Hide resolved
@davidschrammel davidschrammel force-pushed the racl-gen branch 2 times, most recently from 89a2a63 to 4466311 Compare January 23, 2025 13:39
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitty Python comments, but this looks good. And thanks for finding and fixing a silly bug in intermodule.py.

util/raclgen.py Outdated Show resolved Hide resolved
util/raclgen.py Outdated Show resolved Hide resolved
util/raclgen.py Show resolved Hide resolved
util/raclgen.py Outdated Show resolved Hide resolved
util/raclgen/lib.py Show resolved Hide resolved
util/raclgen/lib.py Show resolved Hide resolved
util/raclgen/lib.py Outdated Show resolved Hide resolved
util/topgen/templates/toplevel_racl_pkg.sv.tpl Outdated Show resolved Hide resolved
Used for out-of-topgen flows to hookup an IP with the distributed policy
vector.

Signed-off-by: David Schrammel <davidschrammel@rivosinc.com>
Signed-off-by: David Schrammel <davidschrammel@rivosinc.com>
@davidschrammel
Copy link
Contributor Author

@rswarbrick I have updated the commits according to your comments and rebased them on master (now that #25749 has been merged). Could you take a look at this again?

Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@rswarbrick rswarbrick merged commit bbc324c into lowRISC:master Jan 24, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants