Skip to content

add Environment variable: LOWCODER_DEFAULT_QUERY_TIMEOUT_MILLIS #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

dragonpoo
Copy link
Collaborator

@dragonpoo dragonpoo commented Sep 23, 2024

Proposed changes

add Environment variable: LOWCODER_DEFAULT_QUERY_TIMEOUT_MILLIS for default query timeout

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit c123fa7
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66f5801d6c5e58000717e8f5

FalkWolsky
FalkWolsky previously approved these changes Sep 26, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!!! A good contribution

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Now it is perfect

@FalkWolsky FalkWolsky merged commit 9e68335 into dev Sep 26, 2024
6 checks passed
@FalkWolsky FalkWolsky deleted the feature/default_query_timeout branch September 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants