Skip to content

Update customComp.tsx to include the extra required code to run #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

konstchri
Copy link

added the entire code of https://custom-component.majiang.co/index.html to fix the issue requiring external resources to run properly

also renamed the interface from MJ to lowcoder

Proposed changes

#163

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • [ x] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

integrated entire https://custom-component.majiang.co/index.html to fix functionality with custom components and remove external dependency
@falnyr
Copy link
Contributor

falnyr commented Jun 5, 2023

Hi @konstchri, and thanks for your submission.

While I appreciate the effort to make the custom components work, we need to make sure the code is built properly rather than copying a static compiled version of Openblocks 1.1.8 into this repository.

The right way to solve this problem is one of the following:
A. Create a pipeline that builds the contents of one of the client components and publishes it online for public availability.
B. Make the custom component code available via NPM and reference a dependency.

If you can alter your contribution to match either A or B, I'm happy to take this further.

@falnyr falnyr closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants