Skip to content

Mongo DB Datasource Query Failure Fix + SIGNUP Enablement Always On Fix #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

aq-ikhwa-tech
Copy link
Contributor

@aq-ikhwa-tech aq-ikhwa-tech commented Oct 14, 2023

  • Mongo DB Queries were not working because of integer timeout data type. Changed it to string for it to work again.
  • Took into account the enable-register application.props value when loading auth configs.

Associated Bug Ticket: #355

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

- Mongo DB Queries were not working because of integer timeout data type
- Took into account the enable-register application.props value when loading auth configs
@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for lowcoder-cloud canceled.

Name Link
🔨 Latest commit 17d0d43
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/652aa9057e31e2000836e5c6

@aq-ikhwa-tech aq-ikhwa-tech linked an issue Oct 14, 2023 that may be closed by this pull request
1 task
@aq-ikhwa-tech aq-ikhwa-tech changed the base branch from main to dev October 14, 2023 15:08
@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for branchit-lowcoder-test ready!

Name Link
🔨 Latest commit 75f41f0
🔍 Latest deploy log https://app.netlify.com/sites/branchit-lowcoder-test/deploys/65329bc86938070008e2f4be
😎 Deploy Preview https://deploy-preview-401--branchit-lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this important contribution. We should not forget, that we have to add still the full support for SIGNUP Enablement.

@FalkWolsky FalkWolsky merged commit 93a0023 into dev Oct 20, 2023
@FalkWolsky FalkWolsky deleted the fix-for-email-sign-up-env-var-not-applicable branch October 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ENABLE_USER_SIGN_UP is ignored in the all-in-one docker image
2 participants