Skip to content

Mongo DB Datasource Query Failure Fix + SIGNUP Enablement Always On Fix #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package org.lowcoder.domain.authentication;

import lombok.extern.slf4j.Slf4j;
import org.lowcoder.domain.organization.service.OrgMemberService;
import org.lowcoder.domain.organization.service.OrganizationService;
import org.lowcoder.sdk.auth.AbstractAuthConfig;
import org.lowcoder.sdk.auth.EmailAuthConfig;
import org.lowcoder.sdk.config.AuthProperties;
import org.lowcoder.sdk.config.CommonConfig;
import org.lowcoder.sdk.constants.AuthSourceConstants;
import org.lowcoder.sdk.constants.WorkspaceMode;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
Expand All @@ -24,6 +27,10 @@ public class AuthenticationServiceImpl implements AuthenticationService {

@Autowired
private OrganizationService organizationService;

@Autowired
private OrgMemberService orgMemberService;

@Autowired
private CommonConfig commonConfig;
@Autowired
Expand All @@ -49,16 +56,27 @@ private Mono<FindAuthConfig> findAuthConfig(String orgId, Function<AbstractAuthC

@Override
public Flux<FindAuthConfig> findAllAuthConfigs(String orgId, boolean enableOnly) {
return findAllAuthConfigsByDomain()

Mono<FindAuthConfig> emailAuthConfigMono = orgMemberService.doesAtleastOneAdminExist()
.map(doesAtleastOneAdminExist -> {
boolean shouldEnableRegister = !doesAtleastOneAdminExist && authProperties.getEmail().isEnableRegister();
return new FindAuthConfig
(new EmailAuthConfig(AuthSourceConstants.EMAIL, authProperties.getEmail().isEnable(), shouldEnableRegister), null);
});


Flux<FindAuthConfig> findAuthConfigFlux = findAllAuthConfigsByDomain()
.switchIfEmpty(findAllAuthConfigsForEnterpriseMode())
.switchIfEmpty(findAllAuthConfigsForSaasMode(orgId))
.filter(findAuthConfig -> {
if (enableOnly) {
return findAuthConfig.authConfig().isEnable();
}
return true;
})
.concatWithValues(new FindAuthConfig(DEFAULT_AUTH_CONFIG, null));
});

return Flux.concat(findAuthConfigFlux, emailAuthConfigMono);

}

private Flux<FindAuthConfig> findAllAuthConfigsByDomain() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public interface OrgMemberService {

Mono<Long> getOrgMemberCount(String orgId);

Mono<Boolean> doesAtleastOneAdminExist();

Mono<Long> countAllActiveOrgs(String userId);

Mono<OrgMember> getOrgMember(String orgId, String userId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ public Mono<Long> getOrgMemberCount(String orgId) {
return biRelationService.countBySourceId(ORG_MEMBER, orgId);
}

@Override
public Mono<Boolean> doesAtleastOneAdminExist() {
return biRelationService.countByRelation(ORG_MEMBER, MemberRole.ADMIN.getValue())
.single()
.map(count -> count != 0);
}

@Override
public Mono<Boolean> addMember(String orgId, String userId, MemberRole memberRole) {
return biRelationService.addBiRelation(ORG_MEMBER, orgId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public Mono<QueryExecutionResult> executeQuery(Datasource datasource, Map<String
String timeoutStr, QueryVisitorContext queryVisitorContext) {

int timeoutMs = QueryTimeoutUtils.parseQueryTimeoutMs(timeoutStr, requestParams, common.getMaxQueryTimeout());
queryConfig.putIfAbsent("timeoutMs", timeoutMs);
queryConfig.putIfAbsent("timeoutMs", String.valueOf(timeoutMs));

return Mono.defer(() -> {
if (datasourceMetaInfoService.isJsDatasourcePlugin(datasource.getType())) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public interface BiRelationRepository extends ReactiveMongoRepository<BiRelation

Flux<BiRelation> findByBizTypeAndSourceIdAndRelation(BiRelationBizType bizType, String sourceId, String relation);

Mono<Long> countByBizTypeAndRelation(BiRelationBizType bizType, String relation);

Mono<Long> countByBizTypeAndSourceId(BiRelationBizType bizType, String sourceId);

Mono<Long> countByBizTypeAndTargetId(BiRelationBizType bizType, String targetId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ public Flux<BiRelation> getBySourceIdAndRelation(BiRelationBizType bizType, Stri
return biRelationRepository.findByBizTypeAndSourceIdAndRelation(bizType, sourceId, relation);
}

public Mono<Long> countByRelation(BiRelationBizType bizType, String relation) {
return biRelationRepository.countByBizTypeAndRelation(bizType, relation);
}

public Mono<Long> countBySourceId(BiRelationBizType bizType, String sourceId) {
return biRelationRepository.countByBizTypeAndSourceId(bizType, sourceId);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ spring:
mongodb:
authentication-database: admin
auto-index-creation: false
uri: mongodb://lowcoder:secret123@127.0.0.1/lowcoder?authSource=admin
uri: mongodb://192.168.8.100:27017/lowcoder?authSource=admin
redis:
url: redis://localhost:6379
url: redis://192.168.8.100:6379
main:
allow-bean-definition-overriding: true
allow-circular-references: true
Expand Down Expand Up @@ -41,6 +41,8 @@ common:
- '*'
version: 1.1.8
block-hound-enable: false
js-executor:
host: http://127.0.0.1:6060

material:
mongodb-grid-fs:
Expand All @@ -52,3 +54,8 @@ springdoc:
swagger-ui:
path: /api/docs/swagger-ui
paths-to-exclude: /api/v1/**

auth:
email:
enable: true
enable-register: false