-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Extract client duplicates into re-usable components
#7242
Conversation
Development
: Extract duplicate code into re-usable components
Development
: Extract duplicate code into re-usable componentsDevelopment
: Extract duplicates into re-usable components
src/test/javascript/spec/component/legal/data-export-confirmation-dialog.component.spec.ts
Outdated
Show resolved
Hide resolved
Is this PR ready to review? It has the label but is still in draft state. |
@Strohgelaender yes it is forgot to put it out of draft mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts4
- Course, Exam, Exercise Creation and Deletion
- Exam Time change in general and for specific students
works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually on Ts2_Legacy and worked as expected!
Ts11_Legacy could not create exams for the students. However this is not related to this PR.
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
4f64438
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove after code change
Development
: Extract duplicates into re-usable componentsDevelopment
: Extract client duplicates into re-usable components
Checklist
General
Client
Motivation and Context
While implementing new features in Artemis, components have been duplicated. This PR extracts those duplicate components into reusable ones and replaces the original implementations.
Description
The following components are affected:
confirm-entity-name
delete-dialog
componentdata-export-confirmation
componentreset-repo-button
componentworking-time-control
Steps for Testing
Delete dialog
Prerequisites:
Exam working time change
Prerequisites:
Student exam working time change
Prerequisites:
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
(no changes, just refactoring)