Skip to content

Exam mode: Change test case default visibility to after results release date #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Dec 6, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I documented the Java code using JavaDoc style.

Client

  • I followed the coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Students
  1. instructor: create a course programming exercise
  2. instructor: navigate to grading of the exercise and see that the visibility of the test cases is Always
  3. instructor: create an exam programming exercise
  4. instructor: navigate to grading of the exercise and see that the visibility of the test cases is After Release Date of Results
  5. instructor: make some changes and see that reset rests to the expected default state
  6. student: participate in the course exercise and see that you get immediate feedback
  7. student: participate in the exam and see that you do only get the info whether your solution compiled

Testserver States







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Client

Class/File Line Coverage Confirmation (assert/expect)
student-exam-detail.component.ts 90.21% ✅ ❌
programming-exercise-grading-tasks-table.component.ts 91.3% ✅ ❌
programming-exercise-task.component.ts 92.68% ✅ ❌
utils.ts 98.21% ✅ ❌

Server

Class/File Line Coverage Confirmation (assert/expect)
ProgrammingExercise.java 89% ✅ ❌
ProgrammingExerciseFeedbackCreationService.java 94% ✅ ❌
ProgrammingExerciseTestCaseService.java 89% ✅ ❌
ProgrammingExerciseTestCaseResource.java 100%

Screenshots

TODO

@florian-glombik florian-glombik added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) component:Programming labels Dec 6, 2023
@florian-glombik florian-glombik added this to the 6.7.2 milestone Dec 6, 2023
@florian-glombik florian-glombik self-assigned this Dec 6, 2023
@github-actions github-actions bot removed the client Pull requests that update TypeScript code. (Added Automatically!) label Dec 6, 2023
@github-actions github-actions bot added the tests label Dec 6, 2023
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Dec 7, 2023
…turned a promise from a command while also invoking one or more cy commands in that promise."
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@krusche krusche modified the milestones: 6.7.3, 6.7.4 Dec 22, 2023
@github-actions github-actions bot removed the stale label Dec 23, 2023
@florian-glombik florian-glombik removed this from the 6.7.4 milestone Dec 25, 2023
Copy link

github-actions bot commented Jan 2, 2024

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 2, 2024
@florian-glombik
Copy link
Contributor Author

florian-glombik commented Jan 7, 2024

State of this PR:

  • Production code implementation is finished, tests are adjusted / added
  • Merge conflicts with Angular17 update need to be resolved
  • E2E tests need to be adjusted properly (Adjusting the E2E tests has led to a failure (which seemed only to occur in the remote environment - one of the last commits trying to fix the issue introduced an actual mistake))

@github-actions github-actions bot removed the stale label Jan 7, 2024
@krusche krusche added the too-long-open !!! This is an antipattern, we should aim for small PRs that are only open for a short time !!! label Jan 8, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) server Pull requests that update Java code. (Added Automatically!) stale tests too-long-open !!! This is an antipattern, we should aim for small PRs that are only open for a short time !!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants