-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Extract build agent git service
#8595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/de/tum/in/www1/artemis/service/connectors/GitService.java
BBesrour
reviewed
May 18, 2024
…service # Conflicts: # src/main/java/de/tum/in/www1/artemis/service/connectors/GitService.java # src/main/java/de/tum/in/www1/artemis/service/connectors/localci/buildagent/BuildJobExecutionService.java
BBesrour
approved these changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2 and staging
pzdr7
approved these changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on LocalCI Staging
This was referenced Sep 24, 2024
This was referenced Oct 3, 2024
Merged
This was referenced Oct 14, 2024
Integrated code lifecycle
: Provide Instructors more options to control container configuration
#9487
Merged
This was referenced Nov 25, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config-change
Pull requests that change the config in a way that they require a deployment via Ansible.
docker
ready to merge
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Currently, there is an inconsistency in build agents when using single and multi-node setup. In multi-node, they use https. In single-node, they copy the folder. This PR fixes this issue and has the added benefit of reducing the responsibilities of
GitService
Description
This PR implements several structural and code improvements:
GitService
andBuildJobGitService
and added common functionality inAbstractGitService
Steps for Testing
Note
Test on both setups! (single node and multi node servers with ICL)
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests