General: Fix more button in the course menu

[raffifasaro]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
• I strictly followed the principle of data economy for all client-server REST calls.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The "more..." feature when compressing the navbar was not working anymore after a PR that changed the syntax of the course-overview-component

Description

An if else block in the course-overview-component made the definition of "ngbDropdown" inaccessible for some calls, so instead of using an if else block to completely omit the section, we use "d-none" so the ngbDropdown implementation is still accessible.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Exercise

1. Log in to Artemis
2. Navigate to Course
3. See if "...More" section is displayed again after compressing the page and dropout opens beside it

Before:

After:

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

• New Features

  • Improved sidebar rendering logic for better user experience based on the isLti condition.

• Bug Fixes

  • Streamlined conditional checks for sidebar visibility, enhancing clarity and functionality.

• Style

  • Minor adjustments to HTML formatting and indentation for improved readability.

[rabeatwork]

The dropdown is now within the sidebar instead of on the right side. Unfortunately, this doesn't work, especially in the collapsed view.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the conditional rendering logic of sidebar components in two Angular template files: course-exercises.component.html and course-overview.component.html. The updates simplify the rendering conditions based on the isLti variable, transitioning from using *ngIf directives to more straightforward conditional structures. This results in a cleaner codebase while maintaining the existing functionality of the components.

Changes

File Path	Change Summary
src/main/webapp/app/overview/course-exercises.component.html	Updated sidebar rendering logic to use @if instead of *ngIf, removing unnecessary div.
src/main/webapp/app/overview/course-overview.component.html	Simplified sidebar rendering by applying a class based on isLti, reorganized nested elements.

Possibly related PRs

• General: Allow to switch courses from the course icon #8669: Changes in course-overview.component.html involve conditional rendering based on the isLti variable, similar to the main PR.
• Development: Improve course overview component #8971: Modifications in course-overview.component.html also deal with conditional rendering based on isLti, aligning with the main PR's changes.
• General: Improve exercise view when using LTI #9329: Changes in both course-overview.component.html and course-exercises.component.html involve conditional rendering based on the isLti variable.
• General: Elevate toggle sidebar button #9411: Updates to the sidebar toggle button in course-overview.component.html enhance the UI, relevant to the main PR's sidebar changes.
• General: Animate content sidebar on toggle #9412: Animation effects added to the sidebar in course-overview.component.html relate to the main PR's focus on sidebar rendering logic.
• General: Design the border radius of the sidebar uniformly #9481: Modification of the sidebar's border radius in course-overview.component.html contributes to overall UI consistency, aligning with the main PR's goals.
• Development: Fix console errors on course overview page #9526: Null-safe checks in course-overview.component.html improve robustness, aligning with the main PR's focus on sidebar rendering.
• Communication: Reduce FAQ size #9568: Changes to the FAQ section in course-faq.component.html reflect a similar goal of enhancing the UI, which is also a focus of the main PR.

Suggested labels

ready for review, component:LTI, small

Suggested reviewers

• JohannesStoehr
• florian-glombik
• rabeatwork
• az108
• edkaya

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JohannesStoehr]

Code

[kevinfischer4]

Tested on TS5, works as expected.

[HawKhiem]

Tested on TS5. Works fine

[sachmii]

Tested on TS5, works fine.

[SindiBuklaji]

Tested on Ts3 and it works as expected & described 👍