DM-46137: Support timeouts in notebook executions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
force-pushed
the
tickets/DM-46137
branch
from
9f5bfef
to
733c9aa
Compare
This sets a timeout on the nbexec call to the JupyterLab server extension for notebook execution. It raises a NbexecTaskTimeout exception in the arq worker, which should result in an errored state for the notebook execution job. We might need to fine tune the exception handling so that the result output in the API is useful.
jonathansick
force-pushed
the
tickets/DM-46137
branch
2 times, most recently
from
2019f23
to
3826ba8
Compare
This modifies the result payload for a notebook execution job when the job is complete. - Add a new "error" field that reports an exception raised during the noteburst job, which explains why a job's "success" field is false. The field contains a NoteburstExecutionError model, which in turn contains an enum code for the error and a text message describing the error. - Keep the existing "ipynb_error" field for reporting exceptions raised within the notebook itself. Noteburst's execution could still be considered successful even if the notebook itself raised an exception.
jonathansick
force-pushed
the
tickets/DM-46137
branch
from
3374dd1
to
0f50d4a
Compare
This will let a user know what the timeout setting was for the job, which is especially helpful if the execution was related to the timeout.
jonathansick
force-pushed
the
tickets/DM-46137
branch
from
0f50d4a
to
01e84cd
Compare
jonathansick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
timeoutfield on the nbexec call to the JupyterLab server extension for notebook execution.