Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46137: Support timeouts in notebook executions #99

Merged
merged 7 commits into from
Sep 12, 2024

Commits on Sep 6, 2024

  1. Update dependencies

    jonathansick committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    556251a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Add a timeout field to POST notebook

    This sets a timeout on the nbexec call to the JupyterLab server
    extension for notebook execution. It raises a NbexecTaskTimeout
    exception in the arq worker, which should result in an errored state for
    the notebook execution job. We might need to fine tune the exception
    handling so that the result output in the API is useful.
    jonathansick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0a5a0b0 View commit details
    Browse the repository at this point in the history
  2. Report exceptions in notebook execution in "error"

    This modifies the result payload for a notebook execution job when the
    job is complete.
    
    - Add a new "error" field that reports an exception raised during the
      noteburst job, which explains why a job's "success" field is false.
      The field contains a NoteburstExecutionError model, which in turn
      contains an enum code for the error and a text message describing the
      error.
    
    - Keep the existing "ipynb_error" field for reporting exceptions raised
      within the notebook itself. Noteburst's execution could still be
      considered successful even if the notebook itself raised an exception.
    jonathansick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a620299 View commit details
    Browse the repository at this point in the history
  3. Include the job's timeout settings

    This will let a user know what the timeout setting was for the job,
    which is especially helpful if the execution was related to the timeout.
    jonathansick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    01e84cd View commit details
    Browse the repository at this point in the history
  4. Add change log entry

    jonathansick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7705294 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    1778638 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55bee1b View commit details
    Browse the repository at this point in the history