Skip to content

Commit

Permalink
Revert of Disable BrowserTest.WindowOpenClose for Mac (patchset #1 id…
Browse files Browse the repository at this point in the history
…:1 of https://codereview.chromium.org/1093003002/)

Reason for revert:
The Blink problem has been fixed and will roll into Chrome in the next iteration.

Original issue's description:
> Disable BrowserTest.WindowOpenClose for Mac
>
> It's timing out on Mac 10.6 and 10.8 tests, preventing a Blink roll.
>
> TBR=sky@chromium.org,lushnikov@chromium.org
> BUG=478238
>
> Committed: https://crrev.com/64bd184eb5f5e92121318e698fc70d42de2b3f74
> Cr-Commit-Position: refs/heads/master@{#325753}

TBR=sky@chromium.org,lushnikov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478238

Review URL: https://codereview.chromium.org/1096393003

Cr-Commit-Position: refs/heads/master@{#326103}
  • Loading branch information
schenney-chromium authored and Commit bot committed Apr 21, 2015
1 parent 0a67bdf commit 5c43b7f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/ui/browser_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2074,9 +2074,6 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
}
#endif

// TODO(schenney) Disable on Mac to enable a Blink roll.
// Re-enable and fix after Blink rolls.
#if !defined(OS_MACOSX)
IN_PROC_BROWSER_TEST_F(BrowserTest, WindowOpenClose) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisablePopupBlocking);
Expand All @@ -2089,7 +2086,6 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, WindowOpenClose) {
ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(browser(), url, 2);
EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
}
#endif

// TODO(linux_aura) http://crbug.com/163931
// Mac disabled: http://crbug.com/169820
Expand Down

0 comments on commit 5c43b7f

Please sign in to comment.