Remove jquery from examples/extensions/bookmarks-sidebar #1

ryumiel · 2015-04-16T08:38:22Z

jquery adds 9205 lines in single CL which makes hard to review it.
Because the example is not so complex to use jquery, let's remove it.

…tchset #1 id:1 of https://codereview.chromium.org/1085073002/) Reason for revert: Still very flaky on Win Nvidia: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view Original issue's description: > Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/) > > Reason for revert: > kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues. I'll try reverting it, and keep an eye on it. > > Original issue's description: > > Disable WebGL conformance test on Win8/NVIDIA > > > > The test: > > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > > > Has been timing out on and off for as long as we have records. > > > > BUG=459265 > > NOPRESUBMIT=True > > > > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d > > Cr-Commit-Position: refs/heads/master@{#316872} > > TBR=zmo@chromium.org,ccameron@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=459265 > > Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702 > Cr-Commit-Position: refs/heads/master@{#325142} TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459265 Review URL: https://codereview.chromium.org/1082203004 Cr-Commit-Position: refs/heads/master@{#325435}

…odereview.chromium.org/1089943003/) Reason for revert: webkit_tests is failing consistently on http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN since this v8 roll. The failure stacktraces always start like this: 04:10:19.032 18684 ==4== WARNING: MemorySanitizer: use-of-uninitialized-value 04:10:19.032 18684 #0 0x7fac91e377b1 in v8::internal::Heap::IdleNotification(double) v8/src/heap/heap.cc:4592:37 04:10:19.033 18684 #1 0x7fac919e3b41 in v8::Isolate::IdleNotificationDeadline(double) v8/src/api.cc:7115:10 04:10:19.033 18684 #2 0x7fac979924ef in blink::idleGCTaskInMainThread(double) third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:324:22 0 Original issue's description: > Update V8 to version 4.4.24. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/a9250269..c04a49b3 > > Please follow these instructions for assigning/CC'ing issues: > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/9b5a9a85ca1f560edb2103fcc340a8a9afb7905a > Cr-Commit-Position: refs/heads/master@{#325616} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1051043004 Cr-Commit-Position: refs/heads/master@{#325632}

…d:160001 of https://codereview.chromium.org/1077143002/) Reason for revert: Tentative revert to try to fix all the failing tests on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/2548 with stderrs like: ==22726== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7fb677cf3d50 in sandbox::Trap::SigSys(int, siginfo*, void*) sandbox/linux/seccomp-bpf/trap.cc:140:58 #1 0x7fb6744e3fcf in sandbox::sys_sigaction(int, sigaction const*, sigaction*) ???:0 Uninitialized value was created by an allocation of 'temp.lvalue49' in the stack frame of function '_ZN7sandbox7CodeGen6AppendEtjmm' #0 0x7fb677cf82b0 in sandbox::CodeGen::Append(unsigned short, unsigned int, unsigned long, unsigned long) sandbox/linux/bpf_dsl/codegen.cc:121:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/build/slave/WebKit_Linux_MSAN/build/src/out/Release/content_shell+0xef94d50) Exiting [22595:22595:0417/081926:1015885843:ERROR:command_buffer_proxy_impl.cc(166)] Could not send GpuCommandBufferMsg_Initialize. [22595:22595:0417/081926:1015885969:ERROR:webgraphicscontext3d_command_buffer_impl.cc(209)] CommandBufferProxy::Initialize failed. [4:4:0417/081926:1015885973:ERROR:command_buffer_proxy_impl.cc(166)] Could not send GpuCommandBufferMsg_Initialize. [22595:22595:0417/081926:1015886031:ERROR:webgraphicscontext3d_command_buffer_impl.cc(226)] Failed to initialize command buffer. [4:4:0417/081926:1015886209:ERROR:webgraphicscontext3d_command_buffer_impl.cc(209)] CommandBufferProxy::Initialize failed. [4:4:0417/081926:1015886330:ERROR:webgraphicscontext3d_command_buffer_impl.cc(226)] Failed to initialize command buffer. Original issue's description: > Introduce sys_sigprocmask and sys_sigaction. > > This is preparation of nacl_helper_nonsfi's secompbpf sandbox > implementation. > PNaCl toolchain's signal ABI is incompatible with Linux's. > For example, the length of sigset_t is shoter than Linux's. > (Android has also same problem). > siginfo_t has different memory layout. > Some signal numbers, including SIGBUS, SIGCHLD and SIGSYS, > or some signal flags are different. > This CL fills the gap, by introducing linux_signal.h and > two syscalls, sys_sigprocmask and sys_sigaction. > > Also, as signal.h provides ucontext_t, but PNaCl toolchain > does not provides ucontext_t, this CL re-use the > android_ucontext.h (by renaming it to linux_ucontext.h). > > TEST=Ran bots. > BUG=358465 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm > > Committed: https://crrev.com/3a315e3246a5191cee27216c09e669ea2d6c33d3 > Cr-Commit-Position: refs/heads/master@{#325634} TBR=mdempsky@chromium.org,hidehiko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358465 Review URL: https://codereview.chromium.org/1093843002 Cr-Commit-Position: refs/heads/master@{#325644}

…ted/RenderFrameDeleted. (patchset #1 id:1 of https://codereview.chromium.org/1086613003/) Reason for revert: Relanding because the test is still failing even with this patch reverted. Original issue's description: > Revert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (patchset #2 id:20001 of https://codereview.chromium.org/1070553005/) > > Reason for revert: > Tentative revert to try to fix BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit Mac10.6 Tests and Mac10.8 Tests. > > It times out during ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and gets killed whilst waiting for the navigations. > > It started failing between https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474 and https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29002, so the blamelists are: > > Chromium: https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd02040b7ccec2c56f38b4db..274eb3202c59d4842c191e924577e81f14044af5 > > Blink: https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae490efa83aa1b59107f..4dd6623614cff05eb3c18cd96f8d6ed089b7965b > > This is the only patch that seems at all relevant from amongst those... > > Original issue's description: > > Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. > > > > In the FrameTree unittests, illustrate the liveness of frames in the ASCII > > dumps. Update some tests so that children aren't born to dead parents. > > > > BUG=474231 > > > > Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f > > Cr-Commit-Position: refs/heads/master@{#325508} > > TBR=nasko@chromium.org,nick@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=474231 > > Committed: https://crrev.com/5e69a55db837879b5d4ca4b0935cf61742e09751 > Cr-Commit-Position: refs/heads/master@{#325629} TBR=nasko@chromium.org,nick@chromium.org,johnme@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474231 Review URL: https://codereview.chromium.org/1091303003 Cr-Commit-Position: refs/heads/master@{#325665}

…https://codereview.chromium.org/1093843003/) Reason for revert: Reverting the right revert. Original issue's description: > Revert of Readability review for ckehoe (patchset #8 id:160001 of https://codereview.chromium.org/941593002/) > > Reason for revert: > Reverting speculatively due to failures on Mac 10.6 and 10.8 of the BrowserTest.WindowOpenClose test. > > See http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/475 > > [47576:1799:0416/163155:ERROR:bluetooth_adapter_mac.mm(110)] Not implemented reached in virtual bool device::BluetoothAdapterMac::IsDiscoverable() const > > Original issue's description: > > Readability review for ckehoe > > > > R=jgm@google.com, rkc@chromium.org > > > > Committed: https://chromium.googlesource.com/chromium/src/+/254c7ea0abc8bb7a4694e757404436aeea177ebf > > TBR=jgm@google.com,rkc@chromium.org,ckehoe@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/fd46e3f1f668f8e82c0d0078660e75ca9ef810d9 > Cr-Commit-Position: refs/heads/master@{#325675} TBR=jgm@google.com,rkc@chromium.org,ckehoe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1092133002 Cr-Commit-Position: refs/heads/master@{#325698}

…076e99869d7385 (patchset #1 id:1 of https://codereview.chromium.org/1063443006/) Reason for revert: Speculatively try to fix the entire waterfall =( Original issue's description: > Revert of Update mojo sdk to rev 8563c3d4162bd74e96783e823e076e99869d7385 (patchset #5 id:80001 of https://codereview.chromium.org/1096593002/) > > Reason for revert: > Speculative revert to try to fix linux_android_rel_ng trybots. > > Original issue's description: > > Update mojo sdk to rev 8563c3d4162bd74e96783e823e076e99869d7385 > > > > R=jamesr@chromium.org, rockot@chromium.org > > TBR=rockot@chromium.org > > > > Committed: https://crrev.com/a38136b7f2fd5a7a425bf06bc54c10741bfc22bd > > Cr-Commit-Position: refs/heads/master@{#325643} > > TBR=jamesr@chromium.org,rockot@chromium.org,sky@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/3c05e2000a4494ef0197022077ece8ff2bc7fe49 > Cr-Commit-Position: refs/heads/master@{#325714} TBR=jamesr@chromium.org,rockot@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1098743002 Cr-Commit-Position: refs/heads/master@{#325721}

ltilve · 2015-04-20T17:37:03Z

The dependency with bundled jquery was removed at 8c4a88f

…ifest (patchset #1 id:1 of https://codereview.chromium.org/1052223004/) Reason for revert: Reverting because it might have been fixed by https://codereview.chromium.org/1089873003 Original issue's description: > suppress unaddressable error in ManifestBrowserTest.CORSManifest > > BUG=473197 > TBR=mlamouri@chromium.org > NOTRY=true > > Committed: https://crrev.com/b28b931bd2659b0bdc63e4bd8fbfa0a22da61e9b > Cr-Commit-Position: refs/heads/master@{#323541} TBR=zhaoqin@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473197 Review URL: https://codereview.chromium.org/1067663005 Cr-Commit-Position: refs/heads/master@{#325825}

…ox encoder. (patchset #5 id:80001 of https://codereview.chromium.org/1084323005/) Reason for revert: Suspect of the following break: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/1045 Log excerpt: VideoEncoderTest.EncodesVariedFrameSizes/3 (run #1): [ RUN ] VideoEncoderTest.EncodesVariedFrameSizes/3 ../../media/cast/sender/video_encoder_unittest.cc:375: Failure Value of: EncodeAndCheckDelivery(CreateTestVideoFrame(frame_size), frame_id, frame_id) Actual: true Expected: !is_testing_platform_encoder() Which is: false ... Original issue's description: > [cast] Handle frame size changes directly in the VideoToolbox encoder. > > To implement various kinds of re-initialization conditions more easily, > this CL subsumes responsibility for handling frame size changes directly > in the VideoToolbox encoder. > > The design is very similar to the previous one with a proxy encoder. > Instead of proxying the entire encoder, only the video frame factory is > proxied. Both the encoder and the proxy own a ref-counted reference to > the factory, which in turn owns a weak back-reference to the encoder and > a ref-counted reference to the current pixel buffer pool. > > When a frame size change is detected either by the encoder or by the > video frame factory, the internal compression session is reset. This is > done synchronously when executing on the Cast main thread, and by > posting a task to the cast main thread when not. > > The code to re-initialize the compression session will be re-used in > upcoming work where additional conditions, such as backgrounding, need > to be monitored for session reinitialization. > > BUG=1429234101 > > Committed: https://crrev.com/c7b0852e49ff8ffa05c91ee6d073815a047cd86f > Cr-Commit-Position: refs/heads/master@{#325878} TBR=miu@chromium.org,jfroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=1429234101 Review URL: https://codereview.chromium.org/1100583004 Cr-Commit-Position: refs/heads/master@{#325907}

…#1 id:1 of https://codereview.chromium.org/1058853003/) Reason for revert: Speculatively revert to address: https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/55265 No tests actually fail, but the test process still returns 1 which causes the failure: 828 tests run, 0 failures. started: Mon Apr 20 13:08:19 2015 ended: Mon Apr 20 13:50:19 2015 duration: 41 mins, 59 secs status: FAILURE status reason: return code was 1. This is the only CL in the blame-list that has anything to do with telemetry tests. Original issue's description: > Telemetry: Fix a bad path in win_platform_backend. > > BUG= > > Committed: https://crrev.com/0ede054b94179ad1ba09634dcecf4aa471f13b72 > Cr-Commit-Position: refs/heads/master@{#325884} TBR=dtu@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1100553005 Cr-Commit-Position: refs/heads/master@{#325944}

… id:1 of https://codereview.chromium.org/1058543004/) Reason for revert: Started failing after check-in: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37248 Original issue's description: > Wrote a WebRTC test which runs inside an iframe. > > This is a version of perkj's test in codereview.chromium.org/1073783003 > which also covers a full peer connection call. It does not attempt to > verify the case where we nuke the iframe though since we don't know > what will happen past the gUM call in that call. The WebRTC call in > the iframe will just get torn down so there's not much we can test. > > BUG=472617 > > Committed: https://crrev.com/102be273b1fea6b6cfc07ff56f00b6dde4c722ec > Cr-Commit-Position: refs/heads/master@{#325896} TBR=tommi@chromium.org,phoglund@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472617 Review URL: https://codereview.chromium.org/1083243004 Cr-Commit-Position: refs/heads/master@{#325950}

…. (patchset #1 id:1 of https://codereview.chromium.org/1100553005/) Reason for revert: The error is still happening. I'm reverting the speculative revert. https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/55287 Original issue's description: > Revert of Telemetry: Fix a bad path in win_platform_backend. (patchset #1 id:1 of https://codereview.chromium.org/1058853003/) > > Reason for revert: > Speculatively revert to address: > > https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/55265 > > No tests actually fail, but the test process still returns 1 which causes the failure: > > 828 tests run, 0 failures. > started: Mon Apr 20 13:08:19 2015 > ended: Mon Apr 20 13:50:19 2015 > duration: 41 mins, 59 secs > status: FAILURE > status reason: return code was 1. > > This is the only CL in the blame-list that has anything to do with telemetry tests. > > Original issue's description: > > Telemetry: Fix a bad path in win_platform_backend. > > > > BUG= > > > > Committed: https://crrev.com/0ede054b94179ad1ba09634dcecf4aa471f13b72 > > Cr-Commit-Position: refs/heads/master@{#325884} > > TBR=dtu@chromium.org,erikchen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/ba7cda936dc64dd2fdc982f27b9334880ddb314b > Cr-Commit-Position: refs/heads/master@{#325944} TBR=dtu@chromium.org,dcaiafa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1088453003 Cr-Commit-Position: refs/heads/master@{#326067}

…:1 of https://codereview.chromium.org/1093003002/) Reason for revert: The Blink problem has been fixed and will roll into Chrome in the next iteration. Original issue's description: > Disable BrowserTest.WindowOpenClose for Mac > > It's timing out on Mac 10.6 and 10.8 tests, preventing a Blink roll. > > TBR=sky@chromium.org,lushnikov@chromium.org > BUG=478238 > > Committed: https://crrev.com/64bd184eb5f5e92121318e698fc70d42de2b3f74 > Cr-Commit-Position: refs/heads/master@{#325753} TBR=sky@chromium.org,lushnikov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478238 Review URL: https://codereview.chromium.org/1096393003 Cr-Commit-Position: refs/heads/master@{#326103}

This CL implements a combination of the suggestions 1) and 2) and comment #1 in crbug.com/462808. This reduces the number of calls to GetLoadState. However the status might be less accurate as we are far from guaranteed that the oldest connection is the one which has come the furthest. This should be acceptable though, as the state is mainly used report activity or at which stage connections are hung at. BUG=462808 Review URL: https://codereview.chromium.org/1091793002 Cr-Commit-Position: refs/heads/master@{#326244}

…hset #1 id:1 of https://codereview.chromium.org/1095263004/) Reason for revert: Speculatively revert to address Builder XP Tests (1) telemetry_unittests failure: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/37100 [135/828] telemetry.core.backends.remote.trybot_browser_finder_unittest.TrybotBrowserFinderTest.test_find_all_browser_types_list failed unexpectedly: Traceback (most recent call last): File "E:\b\build\slave\XP_Tests__1_\build\src\tools\telemetry\telemetry\core\backends\remote\trybot_browser_finder_unittest.py", line 70, in test_find_all_browser_types_list sorted(trybot_browser_finder.FindAllBrowserTypes(finder_options))) AssertionError: Lists differ: ['trybot-all', 'trybot-all-and... != ['trybot-all', 'trybot-all-and... First list contains 1 additional elements. First extra element 6: trybot-mac-10-9 ['trybot-all', 'trybot-all-android', 'trybot-all-linux', 'trybot-all-mac', 'trybot-all-win', - 'trybot-android-nexus4', ? ^ + u'trybot-android-nexus4'] ? + ^ - 'trybot-mac-10-9'] Original issue's description: > Make correction to Telemetry command for perf trybot. > > BUG=477285 > > Committed: https://crrev.com/e983006d8ae7dc89b651fc36adc57666b97ae38d > Cr-Commit-Position: refs/heads/master@{#326148} TBR=sullivan@chromium.org,prasadv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477285 Review URL: https://codereview.chromium.org/1080953004 Cr-Commit-Position: refs/heads/master@{#326246}

…d lifetime mgmt in VideoCaptureBufferPool (patchset #7 id:480001 of https://codereview.chromium.org/1064963002/) Reason for revert: The reason for reverting is: Speculatively revert to address Android Tests (dbg) content_unittests failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27395 content_unittests content_unittests failures: VideoCaptureBufferPoolTest.BufferPool/2 GpuMemoryBufferFactoryTests/GpuMemoryBufferFactoryTest.CreateAndDestroy/1 VideoCaptureBufferPoolTest.BufferPool/0 VideoCaptureBufferPoolTest.BufferPool/1 [ RUN ] VideoCaptureBufferPoolTest.BufferPool/0 [FATAL:browser_gpu_memory_buffer_manager.cc(56)] Check failed: !g_gpu_memory_buffer_manager. #00 0x764081d3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fdf1d3 #1 0x75cf95c3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x008d05c3 #2 0x75a3c697 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00613697 #3 0x75f8d1fb /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b641fb #4 0x75f8d35b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b6435b #5 0x75f8d3e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b643e3 #6 0x75f8d5e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b645e3 #7 0x75f8c3c7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b633c7 #8 0x75f49bb7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b20bb7 #9 0x75f41c8b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b18c8b #10 0x75736087 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x0030d087 #11 0x763de291 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fb5291 #12 0x41503bcf /system/lib/libdvm.so+0x0001dbcf #13 0x41534125 /system/lib/libdvm.so+0x0004e125 #14 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #15 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #16 0x4151163b /system/lib/libdvm.so+0x0002b63b #17 0x41546863 /system/lib/libdvm.so+0x00060863 #18 0x4154e7c5 /system/lib/libdvm.so+0x000687c5 #19 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #20 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #21 0x4151163b /system/lib/libdvm.so+0x0002b63b #22 0x4154657f /system/lib/libdvm.so+0x0006057f #23 0x4152fd0d /system/lib/libdvm.so+0x00049d0d #24 0x401a82b3 /system/lib/libandroid_runtime.so+0x0004d2b3 #25 0x401a8fd9 /system/lib/libandroid_runtime.so+0x0004dfd9 #26 0x4006b05d /system/bin/app_process+0x0000105d #27 0x400a234b /system/lib/libc.so+0x0000e34b This CL is the most suspect in the blame-list because it touches the VideoCaptureBufferPool. Original issue's description: > VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool & relatives > > - This CL adds support for GpuMemoryBufferTracker in > addition to the existing SharedMemTracker. > > - A GpuMemoryBufferTracker owns a GpuMemoryBuffer, > which can only be accessed byte-wise between Map() and > Unmap(). > > - For that reason, instead of making a VCBP::Tracker > directly accessible via |void* data| and |size|, a > BufferHandle abstraction is introduced. > > - VideoCaptureDeviceClient then defines its own > AutoReleaseBuffer in terms of this new BufferHandle. > This BufferHandle is supposed to stay Map()ed and > ready to use for the duration of its lifetime. > > Summing up: > * VideoCaptureBufferPool has a pool of Trackers, > * from the VCBP we can get a BufferHandle per |buffer_id|, > * from a BufferHandle we can obtain data(), valid > and Map()ed as long as the BufferHandle itself exists. > > - VideoCaptureDevice::ReserveOutputBuffer() changes to > return a scoped_ptr<Buffer> ISO a scoped_refptr. > > - Added VideoCaptureDevice::OnIncomingCapturedBuffer() > to pass directly a Buffer with the capture contents. > > - video_capture_texture_wrapper.{cc,h} is removed and > its contents are merged into VideoCaptureDeviceClient. > > - FakeVideoCaptureDevice learns how to produce > GpuMemoryBuffers. Also, PIXEL_FORMAT_GPUMEMORYBUFFER > is added. > > Summing up, VCDClient accepts: > * memory backed buffers (the usual) > * texture-backed buffers > * GMB-backed buffers (these are wrapped into a Texture > VideoFrame indistinguishable from the previous case) > > - VideoCaptureTextureWrapper files are gone and > its contents folded into VideoCaptureDeviceClient. > > - Unittests are updated, and so is FakeVideoCaptureDevice. > > BUG=440843 > > Committed: https://crrev.com/abeb15fa955c570cd481accb04c2a677eb2865a9 > Cr-Commit-Position: refs/heads/master@{#326171} TBR=miu@chromium.org,emircan@chromium.org,avi@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440843 Review URL: https://codereview.chromium.org/1090273006 Cr-Commit-Position: refs/heads/master@{#326250}

…atchset #1 id:1 of https://codereview.chromium.org/1099063003/) Reason for revert: Speculatively revert to address Linux ChromiumOS Tests browser_tests failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1742 browser_tests RestoreOnStartupTestChromeOS.PRE_LogInAndVerify 596 disabled 10 flaky failed 2 failures: RestoreOnStartupTestChromeOS.LogInAndVerify RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [385/509] RestoreOnStartupTestChromeOS.LogInAndVerify (SKIPPED) [ RUN ] RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [ FATAL ] ../../testing/gtest/include/gtest/gtest.h:1849:: Condition parameter_ != NULL failed. GetParam() can only be called inside a value-parameterized test -- did you intend to write TEST_P instead of TEST_F? Received signal 6 #0 0x7ff3af22e6de base::debug::StackTrace::StackTrace() #1 0x7ff3af22e21f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7ff3abc5dcb0 <unknown> #3 0x7ff3a78320d5 gsignal #4 0x7ff3a783583b abort #5 0x00000074f9d9 testing::internal::posix::Abort() #6 0x0000024055b0 testing::internal::GTestLog::~GTestLog() #7 0x0000007477b3 testing::WithParamInterface<>::GetParam() #8 0x0000012ecb31 policy::LoginPolicyTestBase::LoginPolicyTestBase() #9 0x0000012fc025 policy::RestoreOnStartupTestChromeOS::RestoreOnStartupTestChromeOS() #10 0x0000012fd18c policy::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test() #11 0x0000012fd117 testing::internal::TestFactoryImpl<>::CreateTest() #12 0x0000007009ca _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #13 0x00000241ab2e testing::internal::HandleExceptionsInMethodIfSupported<>() #14 0x000002410383 testing::TestInfo::Run() #15 0x00000241094a testing::TestCase::Run() #16 0x000002415ccc testing::internal::UnitTestImpl::RunAllTests() #17 0x00000242c01a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #18 0x00000241bf4e testing::internal::HandleExceptionsInMethodIfSupported<>() #19 0x00000241596f testing::UnitTest::Run() #20 0x0000022d95e1 RUN_ALL_TESTS() #21 0x0000022d8647 base::TestSuite::Run() #22 0x0000010d2b72 ChromeBrowserTestSuiteRunner::RunTestSuite() #23 0x00000224de78 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #24 0x000004c38ed5 content::LaunchTests() #25 0x00000224ddb9 LaunchChromeTests() #26 0x0000010d2ad8 main #27 0x7ff3a781d76d __libc_start_main #28 0x000000672fe9 <unknown> r8: 00007ff3a51dc8c0 r9: 00007ff3a51dc8c0 r10: 0000000000000008 r11: 0000000000000202 r12: 0000000000672fc0 r13: 00007fffdd71f330 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000005662 si: 0000000000005662 bp: 00007fffdd71e270 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffdd71e138 ip: 00007ff3a78320d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Add browser test for RestoreOnStartup[URLs] on Chrome OS > > Ladies and gentlemen, this CL brings you the long-awaited end-to-end > browser test for RRestoreOnStartup and RestoreOnStartupURLs, at least > on Chrome OS. > > BUG=477145 > TEST=New browser test > > Committed: https://crrev.com/641bb06057cf18e518a96edaadaae42411341905 > Cr-Commit-Position: refs/heads/master@{#326261} TBR=mnissler@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477145 Review URL: https://codereview.chromium.org/1103493003 Cr-Commit-Position: refs/heads/master@{#326272}

…. (patchset #1 id:40001 of https://codereview.chromium.org/1051323006/) Reason for revert: Failing telemetery_unittests on Linux Tests bot: https://sheriff-o-matic.appspot.com/chromium/failure/telemetry_unittests%3A%3ALinux%20Tests Original issue's description: > [Telemetry] Reenable unused-import lint check for telemetry. > > Fix all the places that have unused-import in telemetry. > > BUG=475714 > > Committed: https://crrev.com/dced4517e3fe208cd5d02ee361b43132afec870d > Cr-Commit-Position: refs/heads/master@{#326298} TBR=sullivan@chromium.org,dtu@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475714 Review URL: https://codereview.chromium.org/1060063007 Cr-Commit-Position: refs/heads/master@{#326314}

…hset #1 id:1 of https://codereview.chromium.org/1081923003/) Reason for revert: Sorry for the delay! We are seeing these failures again: http://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%285%29?numbuilds=200 Original issue's description: > Roll wpr to 13560f74b4f40f12108de7fc43f20b873471d48d. > > For a full list of changes, see > chromium/web-page-replay@4e4d540...13560f7 > > BUG=478178 > TBR=nednguyen@google.com > > Committed: https://crrev.com/b3e3792583ffae2764e29f07fb279101281bc4d0 > Cr-Commit-Position: refs/heads/master@{#325954} TBR=erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478178 Review URL: https://codereview.chromium.org/1098413002 Cr-Commit-Position: refs/heads/master@{#326366}

… id:1 of https://codereview.chromium.org/1048983002/) Reason for revert: We no longer need to support ICS as minsdk is now 16, so this reverts these added checks. Original issue's description: > Don't construct TtsPlatformImpl prior to ICS_MR1 > > BUG=462764 > > Committed: https://crrev.com/ede977e8e5bd4415655e5c81a142276417b4250e > Cr-Commit-Position: refs/heads/master@{#322892} TBR=newt@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462764 Review URL: https://codereview.chromium.org/1087033007 Cr-Commit-Position: refs/heads/master@{#326376}

…NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1082203004/) Reason for revert: The windows test time has been cut in half and shouldn't time out anymore. Original issue's description: > Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1085073002/) > > Reason for revert: > Still very flaky on Win Nvidia: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > Original issue's description: > > Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/) > > > > Reason for revert: > > kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues. I'll try reverting it, and keep an eye on it. > > > > Original issue's description: > > > Disable WebGL conformance test on Win8/NVIDIA > > > > > > The test: > > > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > > > > > Has been timing out on and off for as long as we have records. > > > > > > BUG=459265 > > > > > > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d > > > Cr-Commit-Position: refs/heads/master@{#316872} > > > > TBR=zmo@chromium.org,ccameron@chromium.org > > BUG=459265 > > > > Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702 > > Cr-Commit-Position: refs/heads/master@{#325142} > > TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org > BUG=459265 > > Committed: https://crrev.com/c29d5c5f8d7ae90012a3d6bd42218b860cb53558 > Cr-Commit-Position: refs/heads/master@{#325435} TBR=zmo@chromium.org,ccameron@chromium.org,johnme@chromium.org BUG=459265 Review URL: https://codereview.chromium.org/1099203003 Cr-Commit-Position: refs/heads/master@{#326400}

…ondition (patchset #1 id:1 of https://codereview.chromium.org/1095463003/) Reason for revert: this cl was just a temporary bridge and is no longer needed Original issue's description: > update chrome to handle temporary WEB_FRAME_USES_V8_LOCAL condition > > note: this cl will be reverted once v8::Local is aliased to v8::Handle > > TBR=kalman@chromium.org > BUG= > > Committed: https://crrev.com/dd8fc1ebd8763c1a7a93dcf54417eb5aba4599cb > Cr-Commit-Position: refs/heads/master@{#325417} TBR=jochen@chromium.org,kalman@chromium.org BUG= Review URL: https://codereview.chromium.org/1094393003 Cr-Commit-Position: refs/heads/master@{#326477}

…#1 id:1 of https://codereview.chromium.org/1055813006/) Reason for revert: It's crashing in Canary builds. We have probably gained enough data now, so I'm reverting. Original issue's description: > CHECK() if Windows non-blocking connect returns 0. > > Non-blocking connect() on Windows is documented as always returning > WSAEWOULDBLOCK or another error. > > There has been code in place to handle a 0 return value, but we have > no way to test whether it is correct or not. > > Replace the code to handle a 0 return with a CHECK() call, to find out > whether a 0 result really can happen or not. > > BUG=436634 > TEST=net_unittests > > Committed: https://crrev.com/2d53a9381e88eab543cc4c9fd122b0b1ed4f41d7 > Cr-Commit-Position: refs/heads/master@{#326243} TBR=mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436634 Review URL: https://codereview.chromium.org/1076093006 Cr-Commit-Position: refs/heads/master@{#326507}

While the notification list is opened (it means when ChangeQueue is active), if an "add" change (change #1) and an "update" change (change #3) come in continuously, the change #2 overrides the previous change #1 then the "add" change #1 is gone. Hence, the added notification is never added. This patch fixes this bug. BUG=477993 Review URL: https://codereview.chromium.org/1094823002 Cr-Commit-Position: refs/heads/master@{#326510}

… of https://codereview.chromium.org/1092843003/) Reason for revert: Downstream needs a fix in styles.xml to roll this in. Original issue's description: > Revert of Roll Android SDK and AppCompat. (patchset #2 id:20001 of https://codereview.chromium.org/1101633003/) > > Reason for revert: > Breaks downstream Chrome Android ToT instrumentation test. > BUG=480285 > > Original issue's description: > > Roll Android SDK and AppCompat. > > > > - Android SDK rolls to API 22 rev 2 > > (no API changes, just bug fixes) > > - Android Support Library rolls to 22.1.0 > > > > BUG=479858 > > > > Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a > > Cr-Commit-Position: refs/heads/master@{#326437} > > TBR=newt@chromium.org,cjhopman@chromium.org,aurimas@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=479858 > > Committed: https://crrev.com/dd703b9316d9b346ec1bf6ec357884d40ffe80e6 > Cr-Commit-Position: refs/heads/master@{#326484} TBR=newt@chromium.org,cjhopman@chromium.org,pasko@chromium.org,azarchs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480285 Review URL: https://codereview.chromium.org/1086523004 Cr-Commit-Position: refs/heads/master@{#326583}

… (patchset #1 id:1 of https://codereview.chromium.org/1098403002/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=480538 Original issue's description: > Update the extension whitelist for application host change. > > BUG= > > Committed: https://crrev.com/29b6f6fa8785ed80c2fcf043bb0619f3f8b80065 > Cr-Commit-Position: refs/heads/master@{#326534} TBR=tommi@chromium.org,bemasc@chromium.org,bemascc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1093893004 Cr-Commit-Position: refs/heads/master@{#326620}

… to the memory profiler.) (patchset #1 id:1 of https://codereview.chromium.org/1087133005/) Reason for revert: WinHeapDumpProviderTest.GetHeapInformation is failing on XP Tests (1) bot. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/37137 Original issue's description: > Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.) > > Reason of reland: fixed gn files. > > Add a WinHeap dump provider to the memory profiler. > > TBR=nduca@chromium.org > BUG=466141 > > Committed: https://crrev.com/61dfbd59a9f6424197a1c1fadde0703d5ca65446 > Cr-Commit-Position: refs/heads/master@{#326573} TBR=primiano@chromium.org,rnk@chromium.org,sebmarchand@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466141 Review URL: https://codereview.chromium.org/1101173002 Cr-Commit-Position: refs/heads/master@{#326633}

…t for VideoRecorder.IsStarted (patchset #1 id:1 of https://codereview.chromium.org/1093923004/) Reason for revert: It still times out: http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/builds/615/steps/service_worker.service_worker/logs/stdio Original issue's description: > Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted > > ServiceWorkerPerfTest was failing on Android One, due to timeouts of > VideoRecorder.IsStarted(). This patch attempts to fix this by increasing > the timeout from 5 seconds to 10 seconds, and re-enable the test. > > BUG=469841 > TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker > > Committed: https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9 > Cr-Commit-Position: refs/heads/master@{#326820} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469841 Review URL: https://codereview.chromium.org/1099033005 Cr-Commit-Position: refs/heads/master@{#327005}

…ttps://codereview.chromium.org/1081863003/) Reason for revert: I think this is fixed. Original issue's description: > Suppress data races in SkEventTracer > > BUG=437044 > TBR=mtklein@chromium.org > > Committed: https://crrev.com/f0a9e71e6ad0b13397d45afeeeba7c0ced15b570 > Cr-Commit-Position: refs/heads/master@{#326024} TBR=mtklein@chromium.org,glider@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437044 Review URL: https://codereview.chromium.org/1111433002 Cr-Commit-Position: refs/heads/master@{#327102}

…patchset #1 id:1 of https://codereview.chromium.org/1135353004/) Reason for revert: The failure is not caused by the patch. MigrationSingleClientTest.AllTypesIndividually looks flaky. Original issue's description: > Revert of Drive: Let DriveUploader use batch request API. (patchset #7 id:120001 of https://codereview.chromium.org/1134633003/) > > Reason for revert: > MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN: > > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327 > > Original issue's description: > > Drive: Let DriveUploader use batch request API. > > > > The CL lets DriveUploader use batch request API. DriveUploader does asynchronous > > preparation before calling API on service interface. To hold batch request > > during the asynchronous preparation, the CL introduce refcounted hepler class, > > which manages life time of batch request configurator. > > > > BUG=451917 > > TEST=DriveUploaderTest > > > > Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0 > > Cr-Commit-Position: refs/heads/master@{#329599} > > TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=451917 > > Committed: https://crrev.com/e244812ae9a09d001f24f9aaaf780c80f976d790 > Cr-Commit-Position: refs/heads/master@{#329610} TBR=kinaba@chromium.org,tzik@chromium.org,sergeyv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451917 Review URL: https://codereview.chromium.org/1138883004 Cr-Commit-Position: refs/heads/master@{#329613}

… id:1 of https://codereview.chromium.org/1128913003/) Reason for revert: Doesnt fix GcdPrivateAPITest.WifiPasswords on win dbg: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37945 Original issue's description: > Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg > TBR=vitalybuka > BUG=177163 > > Committed: https://crrev.com/81834cca312ad12091b40ebdab5ec9ca6db1c418 > Cr-Commit-Position: refs/heads/master@{#329615} TBR=asargent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=177163 Review URL: https://codereview.chromium.org/1125413007 Cr-Commit-Position: refs/heads/master@{#329620}

… id:1 of https://codereview.chromium.org/1128253005/) Reason for revert: GcdPrivateAPITest.WifiPasswords fails after this patch. Failure example: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37938 Original issue's description: > Enable extension browser tests on debug windows. > > BUG=177163 > > Committed: https://crrev.com/121cbb5f7fce9719ab6152cb2e059575df8139d6 > Cr-Commit-Position: refs/heads/master@{#329495} TBR=asargent@chromium.org,hubbe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=177163 Review URL: https://codereview.chromium.org/1134333003 Cr-Commit-Position: refs/heads/master@{#329622}

StartSrpcServices will require using the service_runtime pointer, to set up the srpc_client pointer. So we cannot destroy the service_runtime at the same time. E.g., if I add a sleep() to induce the race, I get: ../../native_client/src/include/nacl_scoped_ptr.h:96: C *nacl::scoped_ptr<plugin::SelLdrLauncherChrome>::operator->() const [C = plugin::SelLdrLauncherChrome]: Assertion `ptr_ != __null' failed. Received signal 6 #0 0x7f687f4aef7e base::debug::StackTrace::StackTrace() #1 0x7f687f4aeabf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f6879dee340 <unknown> #3 0x7f6876504cc9 gsignal #4 0x7f68765080d8 abort #5 0x7f68764fdb86 <unknown> #6 0x7f68764fdc32 __assert_fail #7 0x7f688e2887f2 nacl::scoped_ptr<>::operator->() #8 0x7f688e288487 plugin::ServiceRuntime::SetupAppChannel() #9 0x7f688e28cb76 plugin::NaClSubprocess::StartSrpcServices() #10 0x7f688e281810 plugin::PnaclTranslateThread::DoLink() #11 0x7f688e27fe7d plugin::PnaclTranslateThread::DoLinkThread() #12 0x7f6879de6182 start_thread #13 0x7f68765c847d clone Should have checked this in previous refactoring: https://codereview.chromium.org/1128943003 BUG=473474 Review URL: https://codereview.chromium.org/1128373005 Cr-Commit-Position: refs/heads/master@{#329718}

…atchset #1 id:1 of https://codereview.chromium.org/1143503003/) Reason for revert: Android Tests dbg bot is failing: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) The reason of this failure is following patch: https://codereview.chromium.org/1123943002/ I had to revert this patch because it is a follow up. Original issue's description: > Use |IsOriginSecure| for mark-HTTP-nonsecure field trial > > When the flag or field trial is set such that non-secure origins will be > marked as dubious/non-secure, use |IsOriginSecure| to determine whether > an origin is non-secure, instead of simply treating http:// and ftp:// > as non-secure. This means that http://nytimes.com will be marked as > dubious/non-secure, but not http://localhost (for example). > > BUG=487499 > TEST=Enable the "Mark non-secure as non-secure" flag in > chrome://flags. Visit http://nytimes.com and observe that the lock icon > is red and crossed out. Visit an http:// URL on localhost and observe > that the lock icon is neutral. > > Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951 > Cr-Commit-Position: refs/heads/master@{#329774} TBR=meacer@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487499 Review URL: https://codereview.chromium.org/1130843005 Cr-Commit-Position: refs/heads/master@{#329826}

…set #1 id:1 of https://codereview.chromium.org/1135373003/) Reason for revert: Reland initial patch. There is a fix for SecurityLevelTest: https://codereview.chromium.org/1135073003 Original issue's description: > Revert of Move SecurityLevel into a class of its own (patchset #19 id:420001 of https://codereview.chromium.org/1123943002/) > > Reason for revert: > Android Tests dbg bot is failing: > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) > > Failure example: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27901 > > Original issue's description: > > Move SecurityLevel into a class of its own > > > > This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel| > > enum into a class of their own: |ConnectionSecurityHelper| in > > //chrome/browser/ssl (since it is applying Chrome-specific security > > policy to determine the security level of a page). > > > > Later, we will use the new |ConnectionSecurityHelper| class to compute a > > security level for a page to send to the DevTools Security > > panel. Specifically, we need to be able to calculate the security level > > for a given page, not just the WebContents for the active tab. > > > > BUG=484392 > > > > Committed: https://crrev.com/ca7c0a3374c21ab10c821f4f3a890afc79182acf > > Cr-Commit-Position: refs/heads/master@{#329591} > > > > Committed: https://crrev.com/f50c9b4834e151aa6b5538545a503614cb74f5f9 > > Cr-Commit-Position: refs/heads/master@{#329724} > > TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=484392 > > Committed: https://crrev.com/39722bb693112be3d91c729246c0ade351e7e900 > Cr-Commit-Position: refs/heads/master@{#329827} TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484392 Review URL: https://codereview.chromium.org/1124383007 Cr-Commit-Position: refs/heads/master@{#329832}

…d trial (patchset #1 id:1 of https://codereview.chromium.org/1130843005/) Reason for revert: The initial patch was relanded: https://codereview.chromium.org/1124383007/ Original issue's description: > Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1143503003/) > > Reason for revert: > Android Tests dbg bot is failing: > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) > > The reason of this failure is following patch: https://codereview.chromium.org/1123943002/ > > I had to revert this patch because it is a follow up. > > Original issue's description: > > Use |IsOriginSecure| for mark-HTTP-nonsecure field trial > > > > When the flag or field trial is set such that non-secure origins will be > > marked as dubious/non-secure, use |IsOriginSecure| to determine whether > > an origin is non-secure, instead of simply treating http:// and ftp:// > > as non-secure. This means that http://nytimes.com will be marked as > > dubious/non-secure, but not http://localhost (for example). > > > > BUG=487499 > > TEST=Enable the "Mark non-secure as non-secure" flag in > > chrome://flags. Visit http://nytimes.com and observe that the lock icon > > is red and crossed out. Visit an http:// URL on localhost and observe > > that the lock icon is neutral. > > > > Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951 > > Cr-Commit-Position: refs/heads/master@{#329774} > > TBR=meacer@chromium.org,estark@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=487499 > > Committed: https://crrev.com/236d015aa9bf3f61ece3e32c8af40fc1b9153727 > Cr-Commit-Position: refs/heads/master@{#329826} TBR=meacer@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487499 Review URL: https://codereview.chromium.org/1144513003 Cr-Commit-Position: refs/heads/master@{#329834}

…d. (patchset #1 id:1 of https://codereview.chromium.org/1136663004/) Reason for revert: Occasional crashes. Original issue's description: > Ensure the new navigation classifier works in the real world. > > BUG=369661 > TEST=No whammies! > > Committed: https://crrev.com/f97970c11c08a18e9ecea0b1b4c77122371a0e4f > Cr-Commit-Position: refs/heads/master@{#329497} TBR=creis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Review URL: https://codereview.chromium.org/1140123002 Cr-Commit-Position: refs/heads/master@{#329849}

…codereview.chromium.org/1140623002/) Reason for revert: Caused build hangs. BUG=487929 Original issue's description: > Roll ASan/Win to LLVM r237003 > > Brings in coverage support for Windows. > > Green build with this revision: > http://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/217/steps/gclient%20runhooks/logs/stdio > > TBR=inferno@chromium.org > NOTRY=true > > Committed: https://crrev.com/9f05e50063c1c643ecbe7851dc388b6346414c08 > Cr-Commit-Position: refs/heads/master@{#329280} TBR=rnk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1134413003 Cr-Commit-Position: refs/heads/master@{#329886}

id:1 of https://codereview.chromium.org/1129293004/) Reason for revert: most likely culprit for interactive ui test failures here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2847 Original issue's description: > Move token handle obtaining to UserSessionManager > > BUG=484690,484734 > R=nkostylev@chromium.org > > Committed: https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9 > Cr-Commit-Position: refs/heads/master@{#329868} TBR=nkostylev@chromium.org,antrim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484690,484734 Review URL: https://codereview.chromium.org/1140823007 Cr-Commit-Position: refs/heads/master@{#329891}

…92694:295151) (patchset #1 id:1 of https://codereview.chromium.org/1130413005/) Reason for revert: This CL most likely breaks Chrome. I can't find any other reason to this issue: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64 Reverting to see if it helps. Original issue's description: > Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) > > This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code. > See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/ > > Summary of changes available at: > https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85 > > This previously landed in CL 981593002 but got reverted in CL 1131323002 > as it broke the Windows GN bots. The GN script now adds BoringSSL to the > "public_deps" if necessary, so the include path is correct then. > > BUG=328475 > > Committed: https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c > Cr-Commit-Position: refs/heads/master@{#330066} TBR=jiayl@chromium.org,thakis@chromium.org,juberti@chromium.org,gcasto@chromium.org,jbauch@webrtc.org,mail@joachim-bauch.de NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328475 Review URL: https://codereview.chromium.org/1139233002 Cr-Commit-Position: refs/heads/master@{#330070}

…tps://codereview.chromium.org/1129383007/) Reason for revert: Possible fix has landed, reverting to see if bot goes green. Original issue's description: > Disable blink_perf.canvas on linux. > > This has been red going on a week now. > > BUG=488059 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2e2d7141b8f141bfb194427afde9fb2bf1ed5486 > Cr-Commit-Position: refs/heads/master@{#330085} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488059 Review URL: https://codereview.chromium.org/1142643002 Cr-Commit-Position: refs/heads/master@{#330086}

…ast. (patchset #1 id:1 of https://codereview.chromium.org/1130893008/) Reason for revert: Temporary revert until Monday (blocked on some other internal changes). Original issue's description: > Use BoringSSL in the implementation of ClearKey for Chromecast. > (Previously, this was used only with the "Chrome" branding). > > BUG= 488572 > > R=gunsch@chromium.org > > Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab > Cr-Commit-Position: refs/heads/master@{#330156} TBR=ddorwin@chromium.org,dougsteed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 488572 Review URL: https://codereview.chromium.org/1141243003 Cr-Commit-Position: refs/heads/master@{#330230}

…ost (patchset #1 id:1 of https://codereview.chromium.org/1132913004/) Reason for revert: See crbug.com/489135 Original issue's description: > [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost > > BUG=483693 > > Committed: https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1 > Cr-Commit-Position: refs/heads/master@{#330286} TBR=dgozman@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=483693 Review URL: https://codereview.chromium.org/1140603004 Cr-Commit-Position: refs/heads/master@{#330348}

…or Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1141243003/) Reason for revert: OK to replay now Original issue's description: > Revert of Use BoringSSL in the implementation of ClearKey for Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1130893008/) > > Reason for revert: > Temporary revert until Monday (blocked on some other internal changes). > > Original issue's description: > > Use BoringSSL in the implementation of ClearKey for Chromecast. > > (Previously, this was used only with the "Chrome" branding). > > > > BUG= 488572 > > > > R=gunsch@chromium.org > > > > Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab > > Cr-Commit-Position: refs/heads/master@{#330156} > > TBR=ddorwin@chromium.org,dougsteed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 488572 > > Committed: https://crrev.com/564d81833f28f73b9413c6d01725530ff91de64c > Cr-Commit-Position: refs/heads/master@{#330230} TBR=ddorwin@chromium.org,dougsteed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 488572 Review URL: https://codereview.chromium.org/1148433002 Cr-Commit-Position: refs/heads/master@{#330372}

…document. (patchset #1 id:1 of https://codereview.chromium.org/1139033002/) Reason for revert: Caused a large spike in crashes across several bugs: https://crbug.com/426658 https://crbug.com/488382 https://crbug.com/488421 https://crbug.com/488434 https://crbug.com/488470 Original issue's description: > Remove a HistoryNode's children when it navigates to a new document. > > When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree. > > BUG=485385 > > Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a > Cr-Commit-Position: refs/heads/master@{#329763} TBR=japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485385 Review URL: https://codereview.chromium.org/1148473002 Cr-Commit-Position: refs/heads/master@{#330435}

…ttps://codereview.chromium.org/1055113004/) Reason for revert: This seems to be causing DesktopNativeWidgetNoPaintAfterCloseTest failures. Original issue's description: > cc: Aggressively expire retro frames. > > If we're not aggressive about expiring a retro frame (e.g. MISSED frames) > then it's possible to enter a high latency mode often. > > BUG=469953 > > Committed: https://crrev.com/bb5a390066a1baf27ec44228fd3ba4173f93cfbf > Cr-Commit-Position: refs/heads/master@{#330465} TBR=brianderson@chromium.org,sunnyps@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469953 Review URL: https://codereview.chromium.org/1135003006 Cr-Commit-Position: refs/heads/master@{#330504}

…/. (patchset #1 id:1 of https://codereview.chromium.org/1137103003/) Reason for revert: Breaks some layout tests BUG=489672 Original issue's description: > Move content:: scheme registrations from chrome/ to content/. > > Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we > should do their various renderer-side scheme registrations in content > (RenderThreadImpl::RegisterSchemes) rather than in chrome > (ChromeContentRendererClient::RenderThreadStarted). > > R=jochen@chromium.org > > Committed: https://crrev.com/dcd7aad11d33ffd6dffe440ce32a0228c0843a67 > Cr-Commit-Position: refs/heads/master@{#330506} TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1142213002 Cr-Commit-Position: refs/heads/master@{#330513}

…(patchset #1 id:1 of https://codereview.chromium.org/1135333004/) Reason for revert: Bug fixed. Re-enabling the test. Original issue's description: > Temporarily disable a webgl conformance test on D3D9 only. > > BUG=488552 > TEST=webgl conformacne with D3D9 backend > R=kbr@chromium.org > NOTRY=true > > Committed: https://crrev.com/4fbdae9877d2b4775efa0dffdaa9c16ed6689c75 > Cr-Commit-Position: refs/heads/master@{#330138} TBR=kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488552 Review URL: https://codereview.chromium.org/1124083006 Cr-Commit-Position: refs/heads/master@{#330652}

…nkTestRunner (patchset #2 id:250001 of https://codereview.chromium.org/1125133005/) Reason for revert: Broke a bunch of Layout Tests. Here's an example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fstable%2Fanimations-unprefixed%2Fanimation-events-prefixed-04.html STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0) STDERR: #0 0x6a00bcf in content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43 STDERR: #1 0x4e5d9d in OnSetBluetoothAdapter content/shell/browser/layout_test/layout_test_message_filter.cc:171:3 STDERR: #2 0x4e5d9d in DispatchToMethodImpl<content::LayoutTestMessageFilter, void (content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &), std::__1::basic_string<char> , 0> base/tuple.h:252:0 Original issue's description: > bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner > > This patch removes the testing IPC from BluetoothDispatcher and > BluetoothDispatcherHost. > > This patch also changes the way the mock BluetoothAdapter was set in > BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter, > BluetoothDispatcherHost exposes a function to directly set the adapter. > This function is used by LayoutTestSupport to set the adapter. > > Mock adapter flow before: > BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC--> > BluetoothDispatcherHost (Mock constructed here) > > After: > BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) -> > LayoutTestSupport -> BluetoothDispatcherHost > > This is the first of two patches to remove testing from BluetoothDispatcher > and BluetoothDispatcherHost: > > [1] This patch. > [2] http://crrev.com/1132943002 > > BUG=436284 > > Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85 > Cr-Commit-Position: refs/heads/master@{#330647} TBR=jam@chromium.org,scheib@chromium.org,tsepez@chromium.org,ortuno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436284 Review URL: https://codereview.chromium.org/1142303002 Cr-Commit-Position: refs/heads/master@{#330653}

…hset #1 id:1 of https://codereview.chromium.org/1132853010/) Reason for revert: Looks like this broke some builds, where 'use_sysroot' isn't defined. See http://crbug.com/489783. Sounds like sbc has an alternative solution here: https://codereview.chromium.org/1142793003/ Original issue's description: > do not hardcode -I/usr/include32 when cross-compiling > > When we cross-compile, we do not want any /usr/include paths as that will > conflict with our own system headers. Disable the hardcoded path when we > have an active sysroot. > > BUG=chromium:488360 > > Committed: https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b > Cr-Commit-Position: refs/heads/master@{#330514} TBR=jochen@chromium.org,cjhopman@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org,scottmg@chromium.org,thakis@chromium.org,vapier@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488360,489783 Review URL: https://codereview.chromium.org/1147793003 Cr-Commit-Position: refs/heads/master@{#330656}

…meticks. (patchset #1 id:140001 of https://codereview.chromium.org/1140083004/) Reason for revert: Reverting for georgesak@ (his committer access hasn't propagated yet it looks like). After discussion with sky@, decided to keep TimeTicks. Original issue's description: > Change WebContents::last_active_time_ to Time instead of Timeticks. > > For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003 > > Notes: > - In dev tools, replaced "activity" with "active" for consistency > - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time). > > BUG=472772 > > Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20 > Cr-Commit-Position: refs/heads/master@{#330029} TBR=jamescook@chromium.org,jam@chromium.org,georgesak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472772 Review URL: https://codereview.chromium.org/1145233002 Cr-Commit-Position: refs/heads/master@{#330778}

ChromeSRMDelegate should not be reading the WebContents* back from WebContentsObserver after it has explicitly set to observe nullptr WebContents. This was introduced by my earlier CL: r330213, I never tested the feature from NTP. BUG=489182, 489157 Test=1) From new tab page, click on the mic beside search box, feed it some search query, it should not crash chrome. 2) Similar to step #1, but before the query completes, close the tab, observe no crash. Review URL: https://codereview.chromium.org/1134773004 Cr-Commit-Position: refs/heads/master@{#330784}

… the message header." (patchset #4 id:60001 of https://codereview.chromium.org/1330563002/ ) Reason for revert: This CL was only ever intended to make it into one Canary. Original issue's description: > Reland #1 "ipc: Add a new field num_brokered_attachments to the message header." > > This otherwise innocuous CL is causing an unusual crash in Canary. At first > glance, the crash appears related to IPC, but further digging indicates that > it's probably related to corruption of a ResourceBuffer. I've updated that class > to use CHECKs instead of DCHECKs https://codereview.chromium.org/1325153002/. > > I expect this CL to cause ~100 crashes in the next Chrome Canary. I intend to > revert this CL after a single Canary release. This CL will help me better > diagnose the exact nature of the crash. > > BUG=493414 > > Committed: https://crrev.com/d32c32bef61d80f68208e550ace18f50f1c498d1 > Cr-Commit-Position: refs/heads/master@{#347250} TBR=tsepez@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493414 Review URL: https://codereview.chromium.org/1314803005 Cr-Commit-Position: refs/heads/master@{#347429}

…(Sub)TextureCHROMIUM. (patchset #10 id:200001 of https://codereview.chromium.org/1275773003/ ) Reason for revert: Linux AMD GPU FYI bot has a broken gl_tests, likely because of this patch. http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/41273 [ RUN ] GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.Basic/2 Received signal 11 SEGV_MAPERR 000000000045 #0 0x000000492795 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7ff52630acb0 <unknown> #2 0x7ff5232a858c <unknown> #3 0x7ff5230a247c <unknown> #4 0x7ff5230a33ae <unknown> #5 0x7ff5227e8585 <unknown> #6 0x7ff5227e9b0a <unknown> #7 0x7ff522bf75c3 <unknown> #8 0x0000004f7ba4 gfx::GLApiBase::glCopyTexImage2DFn() #9 0x000000596ac1 (anonymous namespace)::DoCopyTexImage2D() #10 0x0000005968c4 gpu::CopyTextureCHROMIUMResourceManager::DoCopyTexture() Original issue's description: > gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. > > It makes it possible to optimize WebGL. > > TEST=gl_tests GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.* > BUG=517548 > > Committed: https://crrev.com/fa25f0e5786527e63c6ff9aeda77da3bd7456ee3 > Cr-Commit-Position: refs/heads/master@{#347354} TBR=piman@chromium.org,sievers@chromium.org,kbr@chromium.org,zmo@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517548,528374 Review URL: https://codereview.chromium.org/1304103005 Cr-Commit-Position: refs/heads/master@{#347465}

…d. (patchset #1 id:1 of https://codereview.chromium.org/1314823011/ ) Reason for revert: Speculative revert, some builders (Nexus 5, 6 and 9 under chromium.gpu) are failing at the device status check step after this change due to: File "build/android/buildbot/bb_device_status_check.py", line 154, in blacklisting_device_status if not serial in blacklist.Read(): AttributeError: 'NoneType' object has no attribute 'Read' See http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/2067 for example. Original issue's description: > [Android] Don't use a device blacklist if one isn't provided. > > BUG=517709 > > Committed: https://crrev.com/be5c91849d2196f97c7a4e0b3e90597c3f2b4c40 > Cr-Commit-Position: refs/heads/master@{#347473} TBR=rnephew@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517709 Review URL: https://codereview.chromium.org/1306653005 Cr-Commit-Position: refs/heads/master@{#347489}

… id:1 of https://codereview.chromium.org/1281273003/ ) Reason for revert: Revert because it breaks new beta. See https://code.google.com/p/chromium/issues/detail?id=528377 Original issue's description: > Pre-cache downloads directory path in PathUtils. > > When Chrome tabs are swiped away and user starts Chrome again, > their default downloads directory is requested. This causes a > StrictMode policy violation since it results in a ~60ms disk > read. Thus by adding this call to the initial AsyncTask we > save that time when the directory is requested by native. > > This must only be called in the browser process as the sandbox > processes do not need to make the call nor can they make the > call(results in NPE). > > BUG=508615 > > Committed: https://crrev.com/4a7568dffab924d3710a68949dca0717bdad3352 > Cr-Commit-Position: refs/heads/master@{#342672} TBR=yfriedman@google.com,wnwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508615 Review URL: https://codereview.chromium.org/1328043002 Cr-Commit-Position: refs/heads/master@{#347518}

…(patchset #1 id:1 of https://codereview.chromium.org/1326163002/ ) Reason for revert: This breaks the downstream test HostDriven_SigninTest.testManagedSignin. Original issue's description: > Android Media Notification: remove "Touch to return" text. > > The notification only shows the origin. Touching the notification to > return to the playing application is a very common pattern on Android. > It is not required for us to reinforce it with text, making the > notification less appealing. > > BUG=528202 > > Committed: https://crrev.com/ded797a710c1a07b06f8d84d697c54671a942b35 > Cr-Commit-Position: refs/heads/master@{#347377} TBR=avayvod@chromium.org,ianwen@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528202 Review URL: https://codereview.chromium.org/1307093008 Cr-Commit-Position: refs/heads/master@{#347533}

…(patchset #1 id:1 of https://codereview.chromium.org/1307093008/ ) Reason for revert: Wrongful conviction. Original issue's description: > Revert of Android Media Notification: remove "Touch to return" text. (patchset #1 id:1 of https://codereview.chromium.org/1326163002/ ) > > Reason for revert: > This breaks the downstream test HostDriven_SigninTest.testManagedSignin. > > Original issue's description: > > Android Media Notification: remove "Touch to return" text. > > > > The notification only shows the origin. Touching the notification to > > return to the playing application is a very common pattern on Android. > > It is not required for us to reinforce it with text, making the > > notification less appealing. > > > > BUG=528202 > > > > Committed: https://crrev.com/ded797a710c1a07b06f8d84d697c54671a942b35 > > Cr-Commit-Position: refs/heads/master@{#347377} > > TBR=avayvod@chromium.org,ianwen@chromium.org,mlamouri@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=528202 > > Committed: https://crrev.com/2fa386cfd0174b20b8ec67c3e3a2503ef479bd3a > Cr-Commit-Position: refs/heads/master@{#347533} TBR=avayvod@chromium.org,ianwen@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528202 Review URL: https://codereview.chromium.org/1306123010 Cr-Commit-Position: refs/heads/master@{#347572}

ltilve closed this as completed Apr 20, 2015

ltilve mentioned this issue Aug 3, 2015

Having different extensions on the sidebar tests #38

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove jquery from examples/extensions/bookmarks-sidebar #1

Remove jquery from examples/extensions/bookmarks-sidebar #1

ryumiel commented Apr 16, 2015

ltilve commented Apr 20, 2015

Remove jquery from examples/extensions/bookmarks-sidebar #1

Remove jquery from examples/extensions/bookmarks-sidebar #1

Comments

ryumiel commented Apr 16, 2015

ltilve commented Apr 20, 2015