Remove extension_sidebar_*.[h|cc] from browserAction CL #2

ryumiel · 2015-04-16T08:41:59Z

Those classes should not placed in extensions/common, because these functionality are
only related to sidebar_api and sidebar_manager

extensions/common/extension_sidebar_defaults.cc | 18 +
extensions/common/extension_sidebar_defaults.h | 29 +
extensions/common/extension_sidebar_utils.cc | 37 +
extensions/common/extension_sidebar_utils.h | 29 +

ryumiel · 2015-04-16T08:45:33Z

It is done at 218a91a028aa75038bc57388b86a93c87148469e (API side) but need more clean up for browserAction CL.

…FrameDeleted. (patchset #2 id:20001 of https://codereview.chromium.org/1070553005/) Reason for revert: Tentative revert to try to fix BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit Mac10.6 Tests and Mac10.8 Tests. It times out during ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and gets killed whilst waiting for the navigations. It started failing between https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474 and https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29002, so the blamelists are: Chromium: https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd02040b7ccec2c56f38b4db..274eb3202c59d4842c191e924577e81f14044af5 Blink: https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae490efa83aa1b59107f..4dd6623614cff05eb3c18cd96f8d6ed089b7965b This is the only patch that seems at all relevant from amongst those... Original issue's description: > Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. > > In the FrameTree unittests, illustrate the liveness of frames in the ASCII > dumps. Update some tests so that children aren't born to dead parents. > > BUG=474231 > > Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f > Cr-Commit-Position: refs/heads/master@{#325508} TBR=nasko@chromium.org,nick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474231 Review URL: https://codereview.chromium.org/1086613003 Cr-Commit-Position: refs/heads/master@{#325629}

…odereview.chromium.org/1089943003/) Reason for revert: webkit_tests is failing consistently on http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN since this v8 roll. The failure stacktraces always start like this: 04:10:19.032 18684 ==4== WARNING: MemorySanitizer: use-of-uninitialized-value 04:10:19.032 18684 #0 0x7fac91e377b1 in v8::internal::Heap::IdleNotification(double) v8/src/heap/heap.cc:4592:37 04:10:19.033 18684 #1 0x7fac919e3b41 in v8::Isolate::IdleNotificationDeadline(double) v8/src/api.cc:7115:10 04:10:19.033 18684 #2 0x7fac979924ef in blink::idleGCTaskInMainThread(double) third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:324:22 0 Original issue's description: > Update V8 to version 4.4.24. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/a9250269..c04a49b3 > > Please follow these instructions for assigning/CC'ing issues: > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/9b5a9a85ca1f560edb2103fcc340a8a9afb7905a > Cr-Commit-Position: refs/heads/master@{#325616} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1051043004 Cr-Commit-Position: refs/heads/master@{#325632}

…ted/RenderFrameDeleted. (patchset #1 id:1 of https://codereview.chromium.org/1086613003/) Reason for revert: Relanding because the test is still failing even with this patch reverted. Original issue's description: > Revert of Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (patchset #2 id:20001 of https://codereview.chromium.org/1070553005/) > > Reason for revert: > Tentative revert to try to fix BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit Mac10.6 Tests and Mac10.8 Tests. > > It times out during ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and gets killed whilst waiting for the navigations. > > It started failing between https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474 and https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29002, so the blamelists are: > > Chromium: https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd02040b7ccec2c56f38b4db..274eb3202c59d4842c191e924577e81f14044af5 > > Blink: https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae490efa83aa1b59107f..4dd6623614cff05eb3c18cd96f8d6ed089b7965b > > This is the only patch that seems at all relevant from amongst those... > > Original issue's description: > > Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. > > > > In the FrameTree unittests, illustrate the liveness of frames in the ASCII > > dumps. Update some tests so that children aren't born to dead parents. > > > > BUG=474231 > > > > Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f > > Cr-Commit-Position: refs/heads/master@{#325508} > > TBR=nasko@chromium.org,nick@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=474231 > > Committed: https://crrev.com/5e69a55db837879b5d4ca4b0935cf61742e09751 > Cr-Commit-Position: refs/heads/master@{#325629} TBR=nasko@chromium.org,nick@chromium.org,johnme@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474231 Review URL: https://codereview.chromium.org/1091303003 Cr-Commit-Position: refs/heads/master@{#325665}

…cb010. (patchset #2 id:20001 of https://codereview.chromium.org/1087243003/) Reason for revert: Causes errors on WinXP: http://crbug.com/478178 Original issue's description: > Roll web-page-replay to 4e772b969d8da0506c1ba1ff14765367bc9cb010. > > For a full list of changes, see > chromium/web-page-replay@4e4d540...4e772b9 > > BUG= > > Committed: https://crrev.com/9a05a5a920c567173faf921aadf10bf372c89a36 > Cr-Commit-Position: refs/heads/master@{#325499} TBR=nednguyen@google.com,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1087303003 Cr-Commit-Position: refs/heads/master@{#325666}

…s_name to True by default (patchset #2 id:20001 of https://codereview.chromium.org/1094723002/) Reason for revert: Speculative revert for BUG=478268 Original issue's description: > [Telemetry] Switch discover.DiscoverClasses's index_by_class_name to True by default > > BUG=466804 > > Committed: https://crrev.com/2d35135080ac73b7d602bb8c6d699293de5dd4d9 > Cr-Commit-Position: refs/heads/master@{#325669} TBR=dtu@chromium.org,aiolos@chromium.org BUG=466804 Review URL: https://codereview.chromium.org/1083133004 Cr-Commit-Position: refs/heads/master@{#325754}

…ner based CreateProcess failures. (patchset #2 id:20001 of https://codereview.chromium.org/1093443002/) Reason for revert: Collected dumps, reverting. Original issue's description: > Adding checks in sandbox code to get some data on AppContainer based CreateProcess failures. > Due to limited debugging options, given it doesn't repro locally, adding some checks in sandbox code to gather more data. > > BUG=467920 > R=jschuh@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/cb0da85dcf65824f96233ed77fd04d99b4c031cb > Cr-Commit-Position: refs/heads/master@{#325663} TBR=cpu@chromium.org,jschuh@chromium.org,wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467920 Review URL: https://codereview.chromium.org/1057083006 Cr-Commit-Position: refs/heads/master@{#325793}

ryumiel · 2015-04-22T07:44:08Z

I decided to remove this classes, because its functionality can be covered inside of sidebar_api classes.

… of https://codereview.chromium.org/1083863002/) Reason for revert: Tests are failing on cros_trunk/stable. See crbug.com/478820. Relevant failure: ../../chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc:163: Failure Value of: input_method::InputMethodManager::Get() ->GetActiveIMEState() ->GetActiveInputMethodIds() Actual: { "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us::eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:altgr-intl:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:dvorak:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:dvp:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:colemak:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:fr::fra" } Expected: expected_input_methods Which is: { "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us::eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:altgr-intl:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:dvorak:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:colemak:eng", "_comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:fr::fra" } Original issue's description: > Add programmer dvorak keyboard layout > > BUG=none > > Committed: https://crrev.com/a49731b2d52429d3948ecb872aff4d019850f99f > Cr-Commit-Position: refs/heads/master@{#325119} TBR=shuchen@chromium.org,chirantan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478820 Review URL: https://codereview.chromium.org/1095153003 Cr-Commit-Position: refs/heads/master@{#325946}

…d lifetime mgmt in VideoCaptureBufferPool (patchset #7 id:480001 of https://codereview.chromium.org/1064963002/) Reason for revert: The reason for reverting is: Speculatively revert to address Android Tests (dbg) content_unittests failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27395 content_unittests content_unittests failures: VideoCaptureBufferPoolTest.BufferPool/2 GpuMemoryBufferFactoryTests/GpuMemoryBufferFactoryTest.CreateAndDestroy/1 VideoCaptureBufferPoolTest.BufferPool/0 VideoCaptureBufferPoolTest.BufferPool/1 [ RUN ] VideoCaptureBufferPoolTest.BufferPool/0 [FATAL:browser_gpu_memory_buffer_manager.cc(56)] Check failed: !g_gpu_memory_buffer_manager. #00 0x764081d3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fdf1d3 #1 0x75cf95c3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x008d05c3 #2 0x75a3c697 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00613697 #3 0x75f8d1fb /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b641fb #4 0x75f8d35b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b6435b #5 0x75f8d3e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b643e3 #6 0x75f8d5e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b645e3 #7 0x75f8c3c7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b633c7 #8 0x75f49bb7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b20bb7 #9 0x75f41c8b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b18c8b #10 0x75736087 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x0030d087 #11 0x763de291 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fb5291 #12 0x41503bcf /system/lib/libdvm.so+0x0001dbcf #13 0x41534125 /system/lib/libdvm.so+0x0004e125 #14 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #15 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #16 0x4151163b /system/lib/libdvm.so+0x0002b63b #17 0x41546863 /system/lib/libdvm.so+0x00060863 #18 0x4154e7c5 /system/lib/libdvm.so+0x000687c5 #19 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #20 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #21 0x4151163b /system/lib/libdvm.so+0x0002b63b #22 0x4154657f /system/lib/libdvm.so+0x0006057f #23 0x4152fd0d /system/lib/libdvm.so+0x00049d0d #24 0x401a82b3 /system/lib/libandroid_runtime.so+0x0004d2b3 #25 0x401a8fd9 /system/lib/libandroid_runtime.so+0x0004dfd9 #26 0x4006b05d /system/bin/app_process+0x0000105d #27 0x400a234b /system/lib/libc.so+0x0000e34b This CL is the most suspect in the blame-list because it touches the VideoCaptureBufferPool. Original issue's description: > VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool & relatives > > - This CL adds support for GpuMemoryBufferTracker in > addition to the existing SharedMemTracker. > > - A GpuMemoryBufferTracker owns a GpuMemoryBuffer, > which can only be accessed byte-wise between Map() and > Unmap(). > > - For that reason, instead of making a VCBP::Tracker > directly accessible via |void* data| and |size|, a > BufferHandle abstraction is introduced. > > - VideoCaptureDeviceClient then defines its own > AutoReleaseBuffer in terms of this new BufferHandle. > This BufferHandle is supposed to stay Map()ed and > ready to use for the duration of its lifetime. > > Summing up: > * VideoCaptureBufferPool has a pool of Trackers, > * from the VCBP we can get a BufferHandle per |buffer_id|, > * from a BufferHandle we can obtain data(), valid > and Map()ed as long as the BufferHandle itself exists. > > - VideoCaptureDevice::ReserveOutputBuffer() changes to > return a scoped_ptr<Buffer> ISO a scoped_refptr. > > - Added VideoCaptureDevice::OnIncomingCapturedBuffer() > to pass directly a Buffer with the capture contents. > > - video_capture_texture_wrapper.{cc,h} is removed and > its contents are merged into VideoCaptureDeviceClient. > > - FakeVideoCaptureDevice learns how to produce > GpuMemoryBuffers. Also, PIXEL_FORMAT_GPUMEMORYBUFFER > is added. > > Summing up, VCDClient accepts: > * memory backed buffers (the usual) > * texture-backed buffers > * GMB-backed buffers (these are wrapped into a Texture > VideoFrame indistinguishable from the previous case) > > - VideoCaptureTextureWrapper files are gone and > its contents folded into VideoCaptureDeviceClient. > > - Unittests are updated, and so is FakeVideoCaptureDevice. > > BUG=440843 > > Committed: https://crrev.com/abeb15fa955c570cd481accb04c2a677eb2865a9 > Cr-Commit-Position: refs/heads/master@{#326171} TBR=miu@chromium.org,emircan@chromium.org,avi@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440843 Review URL: https://codereview.chromium.org/1090273006 Cr-Commit-Position: refs/heads/master@{#326250}

…atchset #1 id:1 of https://codereview.chromium.org/1099063003/) Reason for revert: Speculatively revert to address Linux ChromiumOS Tests browser_tests failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1742 browser_tests RestoreOnStartupTestChromeOS.PRE_LogInAndVerify 596 disabled 10 flaky failed 2 failures: RestoreOnStartupTestChromeOS.LogInAndVerify RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [385/509] RestoreOnStartupTestChromeOS.LogInAndVerify (SKIPPED) [ RUN ] RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [ FATAL ] ../../testing/gtest/include/gtest/gtest.h:1849:: Condition parameter_ != NULL failed. GetParam() can only be called inside a value-parameterized test -- did you intend to write TEST_P instead of TEST_F? Received signal 6 #0 0x7ff3af22e6de base::debug::StackTrace::StackTrace() #1 0x7ff3af22e21f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7ff3abc5dcb0 <unknown> #3 0x7ff3a78320d5 gsignal #4 0x7ff3a783583b abort #5 0x00000074f9d9 testing::internal::posix::Abort() #6 0x0000024055b0 testing::internal::GTestLog::~GTestLog() #7 0x0000007477b3 testing::WithParamInterface<>::GetParam() #8 0x0000012ecb31 policy::LoginPolicyTestBase::LoginPolicyTestBase() #9 0x0000012fc025 policy::RestoreOnStartupTestChromeOS::RestoreOnStartupTestChromeOS() #10 0x0000012fd18c policy::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test() #11 0x0000012fd117 testing::internal::TestFactoryImpl<>::CreateTest() #12 0x0000007009ca _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #13 0x00000241ab2e testing::internal::HandleExceptionsInMethodIfSupported<>() #14 0x000002410383 testing::TestInfo::Run() #15 0x00000241094a testing::TestCase::Run() #16 0x000002415ccc testing::internal::UnitTestImpl::RunAllTests() #17 0x00000242c01a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #18 0x00000241bf4e testing::internal::HandleExceptionsInMethodIfSupported<>() #19 0x00000241596f testing::UnitTest::Run() #20 0x0000022d95e1 RUN_ALL_TESTS() #21 0x0000022d8647 base::TestSuite::Run() #22 0x0000010d2b72 ChromeBrowserTestSuiteRunner::RunTestSuite() #23 0x00000224de78 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #24 0x000004c38ed5 content::LaunchTests() #25 0x00000224ddb9 LaunchChromeTests() #26 0x0000010d2ad8 main #27 0x7ff3a781d76d __libc_start_main #28 0x000000672fe9 <unknown> r8: 00007ff3a51dc8c0 r9: 00007ff3a51dc8c0 r10: 0000000000000008 r11: 0000000000000202 r12: 0000000000672fc0 r13: 00007fffdd71f330 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000005662 si: 0000000000005662 bp: 00007fffdd71e270 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffdd71e138 ip: 00007ff3a78320d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Add browser test for RestoreOnStartup[URLs] on Chrome OS > > Ladies and gentlemen, this CL brings you the long-awaited end-to-end > browser test for RRestoreOnStartup and RestoreOnStartupURLs, at least > on Chrome OS. > > BUG=477145 > TEST=New browser test > > Committed: https://crrev.com/641bb06057cf18e518a96edaadaae42411341905 > Cr-Commit-Position: refs/heads/master@{#326261} TBR=mnissler@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477145 Review URL: https://codereview.chromium.org/1103493003 Cr-Commit-Position: refs/heads/master@{#326272}

…tps://codereview.chromium.org/1101633003/) Reason for revert: Breaks downstream Chrome Android ToT instrumentation test. BUG=480285 Original issue's description: > Roll Android SDK and AppCompat. > > - Android SDK rolls to API 22 rev 2 > (no API changes, just bug fixes) > - Android Support Library rolls to 22.1.0 > > BUG=479858 > > Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a > Cr-Commit-Position: refs/heads/master@{#326437} TBR=newt@chromium.org,cjhopman@chromium.org,aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479858 Review URL: https://codereview.chromium.org/1092843003 Cr-Commit-Position: refs/heads/master@{#326484}

#2 id:40001 of https://codereview.chromium.org/1100173002/) Reason for revert: This change has broke the CQ build: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/240 Original issue's description: > Add a WinHeap dump provider to the memory profiler. > > BUG=466141 > > Committed: https://crrev.com/62215af64daf642c492fc2002cffc287b2c3bb09 > Cr-Commit-Position: refs/heads/master@{#326501} TBR=primiano@chromium.org,chrisha@chromium.org,nduca@chromium.org,sebmarchand@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466141 Review URL: https://codereview.chromium.org/1101853002 Cr-Commit-Position: refs/heads/master@{#326503}

While the notification list is opened (it means when ChangeQueue is active), if an "add" change (change #1) and an "update" change (change #3) come in continuously, the change #2 overrides the previous change #1 then the "add" change #1 is gone. Hence, the added notification is never added. This patch fixes this bug. BUG=477993 Review URL: https://codereview.chromium.org/1094823002 Cr-Commit-Position: refs/heads/master@{#326510}

… of https://codereview.chromium.org/1092843003/) Reason for revert: Downstream needs a fix in styles.xml to roll this in. Original issue's description: > Revert of Roll Android SDK and AppCompat. (patchset #2 id:20001 of https://codereview.chromium.org/1101633003/) > > Reason for revert: > Breaks downstream Chrome Android ToT instrumentation test. > BUG=480285 > > Original issue's description: > > Roll Android SDK and AppCompat. > > > > - Android SDK rolls to API 22 rev 2 > > (no API changes, just bug fixes) > > - Android Support Library rolls to 22.1.0 > > > > BUG=479858 > > > > Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a > > Cr-Commit-Position: refs/heads/master@{#326437} > > TBR=newt@chromium.org,cjhopman@chromium.org,aurimas@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=479858 > > Committed: https://crrev.com/dd703b9316d9b346ec1bf6ec357884d40ffe80e6 > Cr-Commit-Position: refs/heads/master@{#326484} TBR=newt@chromium.org,cjhopman@chromium.org,pasko@chromium.org,azarchs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480285 Review URL: https://codereview.chromium.org/1086523004 Cr-Commit-Position: refs/heads/master@{#326583}

The dSYM for Google Chrome Framework has grown to be larger than 4GB. dsymutil can't handle this. Reduce the amount of debug info output for official builds of Google Chrome. On my local machine, the dSYM is 10x smaller. BUG=479841 Review URL: https://codereview.chromium.org/1101163002 Cr-Commit-Position: refs/heads/master@{#326635}

…patchset #2 id:20001 of https://codereview.chromium.org/1080633009/) Reason for revert: ash_unittests are timing out on Win8 Aura and Linux ChromiumOS Tests (dbg)(1) bot and this CL is suspected to be the cause of the problem. Original issue's description: > ui: Clean up damaged rects and clear them after painting. > > This cleans up some of the damage rects code by converting the SkRegion > to a cc::Region, allowing use of gfx::Rects. It moves the recursion > over the Layer tree out to Compositor instead of on Layer. > > And we keep the damaged_region_ valid until the layer is painted. This > will allow us to pass that damaged_region_ to the painting code with > impl-side slimming paint, because with impl-side painting, the paint > clip rect can be larger than the invalidations (as large as the whole > layer). > > R=piman@chromium.org, sky > BUG=466426 > > Committed: https://crrev.com/a5e585868e16ce53c990f764d4943592f11749aa > Cr-Commit-Position: refs/heads/master@{#326547} TBR=piman@chromium.org,sky@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466426 Review URL: https://codereview.chromium.org/1101103004 Cr-Commit-Position: refs/heads/master@{#326637}

…hset #2 id:80001 of https://codereview.chromium.org/1101513003/) Reason for revert: The GN file wasn't formatted correctly. http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/8764/steps/compile/logs/stdio Original issue's description: > mac: Weakly link against the CoreBluetooth framework. > > In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously, > it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX > 10.10, the top level CoreBluetooth framework must be weakly linked. > > BUG=463170 > > Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8 > Cr-Commit-Position: refs/heads/master@{#326705} TBR=rsesek@chromium.org,keybuk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170 Review URL: https://codereview.chromium.org/1065453003 Cr-Commit-Position: refs/heads/master@{#326708}

…1 of https://codereview.chromium.org/1082813004/) Reason for revert: Caused gyp_flag_compare failure on Linux GN bots. BUG=480739 Original issue's description: > Roll GN (via buildtools) 321178:326666 > > This picks up the changes for 'gn help all' and > the markdown docs, fixes a bug related to the > transitive propagation of public_deps across > shared objects, and includes a speculative fix > for the WriteFile() failures we're seeing on > Windows. > > TBR=brettw@chromium.org > > Committed: https://crrev.com/a21c4f2acc0b7b97a65c3c145361aed55c53f769 > Cr-Commit-Position: refs/heads/master@{#326704} TBR=brettw@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1095553006 Cr-Commit-Position: refs/heads/master@{#326716}

…automatic (patchset #2 id:20001 of https://codereview.chromium.org/1096263005/) Reason for revert: automatic alert dialog styling was reverted, so revert this as well for now. Original issue's description: > Remove special theming for CardUnmaskPrompt since it's now automatic > for all alert dialogs. > > BUG=463576 > > Committed: https://crrev.com/d9456757bec482f2b27cf75ef7fa2109af0500a6 > Cr-Commit-Position: refs/heads/master@{#326869} TBR=newt@chromium.org,aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463576 Review URL: https://codereview.chromium.org/1097263003 Cr-Commit-Position: refs/heads/master@{#326899}

… (patchset #2 id:20001 of https://codereview.chromium.org/1098083003/) Reason for revert: Broke Win 8 Aura content_browsertests [ RUN ] ServiceWorkerVersionBrowserTest.ReadResourceFailure ... [2420:2792:0426/232049:1965296:FATAL:service_worker_registration.cc(44)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on Unknown Thread. Backtrace: base::debug::StackTrace::StackTrace [0x07FB1081+33] logging::LogMessage::~LogMessage [0x07FFD9FF+63] content::ServiceWorkerRegistration::~ServiceWorkerRegistration [0x045639F5+293] content::ServiceWorkerRegistration::`scalar deleting destructor' [0x006A087A+26] base::RefCounted\u003Ccontent::ServiceWorkerRegistration>::Release [0x0372C3D2+114] scoped_refptr\u003Ccontent::ServiceWorkerRegistration>::Release [0x03D8F94E+14] http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/29227/steps/content_browsertests/logs/ServiceWorkerVersionBrowserTest.ReadResourceFailure Original issue's description: > Evict Service Worker when reading it from disk cache fails. > > If reading the SW resources from the disk cache fails, we should evict > the worker or else we will keep getting the same failure. > > This patch unsets the worker from the live registration, and then > deletes the registration if the SW was the stored version. > > BUG=448003 > > Committed: https://crrev.com/64e3ffb1c6b85c7d21e63afcbffe85c5a1112eb7 > Cr-Commit-Position: refs/heads/master@{#327000} TBR=nhiroki@chromium.org,kinuko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448003 Review URL: https://codereview.chromium.org/1056913010 Cr-Commit-Position: refs/heads/master@{#327012}

…1 of https://codereview.chromium.org/1099713005/) Reason for revert: Speculative revert - Linux ChromiumOS Ozone Tests is broken. http://goo.gl/vykWsG Related to https://codereview.chromium.org/1100803004/ Original issue's description: > ozone: Add sync flag for atomic commit and page flip event handling > > Committed: https://crrev.com/f7553583492a8ea9a54d75cd6b2d3dd83c94512c > Cr-Commit-Position: refs/heads/master@{#326863} TBR=dnicoara@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1098093005 Cr-Commit-Position: refs/heads/master@{#327016}

… need for atomic (patchset #2 id:20001 of https://codereview.chromium.org/1100803004/) Reason for revert: Speculative revert - Linux ChromiumOS Ozone Tests is broken. http://goo.gl/vykWsG Original issue's description: > ozone: Add ability to set client capabilities which we will need for atomic > > Committed: https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713 > Cr-Commit-Position: refs/heads/master@{#326860} TBR=dnicoara@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1104013002 Cr-Commit-Position: refs/heads/master@{#327018}

…tchset #2 id:20001 of https://codereview.chromium.org/1106653002/) Reason for revert: Speculative revert - multiple browser_tests fail on Mac10.9 Tests (dbg) http://goo.gl/4AqhVG Original issue's description: > Flip extension background page throttling on by default > > R=kalman > BUG=424661 > > Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd > Cr-Commit-Position: refs/heads/master@{#326953} TBR=kalman@chromium.org,oysteine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=424661 Review URL: https://codereview.chromium.org/1106953002 Cr-Commit-Position: refs/heads/master@{#327021}

The first attempt to land this CL failed because there weas a missing import in device/BUILD.gn. > mac: Weakly link against the CoreBluetooth framework. > > In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously, > it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX > 10.10, the top level CoreBluetooth framework must be weakly linked. > > BUG=463170 > Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8 > Cr-Commit-Position: refs/heads/master@{#326705} BUG=463170 TBR=rsesek@chromium.org, keybuk@chromium.org Review URL: https://codereview.chromium.org/1056313004 Cr-Commit-Position: refs/heads/master@{#327065}

…mpt #2) The original CL had non-determinism in the unit test. > Delete session cookies immediately after loading the cookie DB. > > Previously, the session cookies were deleted after all cookies were loaded into > memory. This allows for a race condition where new session cookies are inserted > into the database while the cookies are being loaded into memory, which causes > the new session cookies to also be deleted. > > BUG= > > Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843 > Cr-Commit-Position: refs/heads/master@{#326672} BUG= Review URL: https://codereview.chromium.org/1103003002 Cr-Commit-Position: refs/heads/master@{#327104}

…ispatcherHost (1) (patchset #2 id:140001 of https://codereview.chromium.org/1101733005/) Reason for revert: I think this patch caused layouttest failures on the Blink tree, see crbug.com/481784 for details. Original issue's description: > CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) > > CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship > and the indirection is no longer necessary. As a first step of merge, this CL > moves message handlers for CacheStorage API from the listener to the dispatcher. > > BUG=474233 > TEST=content_unittests --gtest_filter=CacheStorage* > > Committed: https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf > Cr-Commit-Position: refs/heads/master@{#327199} TBR=jsbell@chromium.org,nhiroki@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474233, 481784 Review URL: https://codereview.chromium.org/1111703002 Cr-Commit-Position: refs/heads/master@{#327229}

…id:20001 of https://codereview.chromium.org/1103393002/) Reason for revert: Causes a build failure with -Dcomponent=shared_library Original issue's description: > Pass -Oz flag to Clang when targeting Android. > > The -Oz flag enables more aggressive size optimizations. Shrinks the > libchromeshell.so DSO by around 2.5MB. > > BUG=481675 > R=thakis@chromium.org > > Committed: https://crrev.com/2433e6ab2206fad3bc5954fd61e9d4785ccab108 > Cr-Commit-Position: refs/heads/master@{#327183} TBR=thakis@chromium.org,pcc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481675 Review URL: https://codereview.chromium.org/1109203002 Cr-Commit-Position: refs/heads/master@{#327326}

In order for us to map and track between the touch events and their ACKs, we need to set unique_event_id to WebTouchEvent when converting from TouchEvent. This patch is part of a series: patch #1: https://codereview.chromium.org/1008573002/ patch #2: This CL BUG=466711 Review URL: https://codereview.chromium.org/999423003 Cr-Commit-Position: refs/heads/master@{#327520}

clear to developers. This commit includes 5 changes that make OIB connection info strings more clear to developers (and advanced users). Since it has become impractical to target "normal" users with these strings, the focus is on using exact terminology instead of "friendly" alternatives. This should help developers to understand the page's issues at a glance: https://docs.google.com/document/d/1YgavRvC7_6PoOYHjUuKQL1Mlc718z7F1AnTNGrM92W4/edit#heading=h.kldzb7b775ri Changes in this commit: 1. The identity section explicitly mentions when an error was caused by SHA-1 in the certificate chain, instead of referencing "outdated security settings" (there are no such settings apart from SHA-1 signatures right now). (https://crbug.com/437466) 2. Mentions of "public audit records" have been replaced with mentions of "Certificate Transparency". The phrase "Public audit records" was hinging at the implications of CT, but a full understanding the string requires knowledge of CT. Also, the mention of CT has been split into a separate sentence. The presence of "but" had a strong but incorrect implication that this affects the lock icon (which will not be the case for non-EV sites in the near future). 3. The phrase "modern cryptography" is now "modern cipher suite" in order to distinguish the kind of cryptography in question. (Similarly for "obsolete cryptography".) This technically doesn't mention the protocol; however, the main problem usually lies with the cipher suite rather than the protocol, and all the cipher suites we currently consider good require TLS 1.2 (or, say, QUIC) as a prerequisite. 4. Mixed content message: Instead of "However", the sentence now starts with "Further" so that it still makes sense when the protocol/cipher suite is obsolete (https://crbug.com/434617). 5. The "SHA1 for message authentication" string (for ciphers with a MAC) now displays SHA1 as HMAC-SHA1, to be more suggestive that this a different use of SHA-1 than for cert signatures. (Similarly for other TLS MACs.) Design constraint: In order to make this change as simple as possible, the code logic has not been touched. The string contents have been changed, but all strings keep their identifiers and semantics. Also, these changes are definitely meant as a band-aid. In the medium-long term, the plan is to remove the connection tab from the OIB and offer the information in DevTools. (However, we have yet to decide on a plan to supplant it on mobile.) Test pages: #1: https://sha1.badssl.com/ #2: - DV, no SCT: https://garron.net/ - DV, SCT: https://embed.ct.digicert.com/ - EV, no SCT: https://www.mozilla.org/ - EV, SCT: https://www.bankofamerica.com/ #3: - "modern": https://garron.net/ - "obsolete": https://rc4.badssl.com/ #4: https://mixed.badssl.com/ #5: https://rc4.badssl.com/ Note that this commit roughly coincides with the reintroduction of connection info on Android: - https://crbug.com/425158#c41 - https://chromium.googlesource.com/chromium/src/+/f21c52aeafa701b18ed505347ee0e7a7d07e5d53 Android Chrome users haven't been able to access this information for the last half year, and will see these new strings directly. BUG=461045, 434617, 437466 TEST=Visit the test pages (listed above). Review URL: https://codereview.chromium.org/1109283003 Cr-Commit-Position: refs/heads/master@{#328502}

…ces to NetworkChangeNotifier. (patchset #2 id:190001 of https://codereview.chromium.org/1128533003/) Reason for revert: See crbug.com/485135 If it's unrelated, I'll reland this. Original issue's description: > (Reland) Enable ignoring network interfaces in NetworkChangeNotifierLinux. > > NetworkChangeNotifier should not report network changes from interfaces > that are not used to connect to the internet (ie. wifi APs). Adjust constructor > for NetworkChangeNotifierLinux to accept a list of interfaces that are known to > not be used to connect to internet. > > R=pauljensen@chromium.org,akuegel@chromium.org,jochen@chromium.org > BUG=469863 > > Committed: https://crrev.com/09c74490237aeefe5f41c1cad07a7d1e2b384590 > Cr-Commit-Position: refs/heads/master@{#328378} TBR=pauljensen@chromium.org,akuegel@chromium.org,jochen@chromium.org,derekjchow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469863 Review URL: https://codereview.chromium.org/1126303002 Cr-Commit-Position: refs/heads/master@{#328550}

…s. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/) Reason for revert: Broke iOS build. http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio Original issue's description: > Fixit: Factor out common base::Time* math operator overloads. > > This is part 1 of a 2-part change to fork base::TimeTicks into three > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The > forking of TimeTicks will ensure values from different clocks are not > erroneously being mixed together when doing time math. > > In this change, the identical comparison and math operator overloads > found in base::Time and base::TimeTicks are being factored-out into a > templated base class. In a following change, this base class will also > be used to de-dupe this common functionality in the two new time > classes. > > BUG=467417 > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d > Cr-Commit-Position: refs/heads/master@{#328696} TBR=thestig@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467417 Review URL: https://codereview.chromium.org/1130953002 Cr-Commit-Position: refs/heads/master@{#328706}

…nload-removed tests (patchset #2 id:60001 of https://codereview.chromium.org/1132483002/) Reason for revert: Need to revert because the preceeding CL was reverted: https://codereview.chromium.org/1136453002/ Original issue's description: > Reland of [Download Notification] Add cancel-button and download-removed tests > > The original CL (crrev.com/24185c2b) had been reverted due to the memory leak (crrev.com/a8d1b6a3). But memory leak has been fixed so this patch reland the original CL. > > The diff of this CL is completely same as the original. > > Original CL's description: > > [Download Notification] Add cancel-button and download-removed tests > > > > This patch adds the following tests: > > - Clicking cancel-button while download is in progress > > - Clicking cancel-button after download is finished > > - Download is removed externally > > > > BUG=480489 > > TEST=manually tested > > > > Committed: https://crrev.com/24185c2b385071c1ba007b3cc16f52692dd78d02 > > Cr-Commit-Position: refs/heads/master@{#328059} > > TBR=yoshiki@chromium.org, asanka@chromium.org > BUG=480489 > > Committed: https://crrev.com/31f75c00b6b26521182bb38d6875d5b1dfbc6770 > Cr-Commit-Position: refs/heads/master@{#328735} TBR=yoshiki@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480489 Review URL: https://codereview.chromium.org/1127383002 Cr-Commit-Position: refs/heads/master@{#328741}

…r overloads. (patchset #1 id:1 of https://codereview.chromium.org/1130953002/) Reason for revert: iOS_Device builder was not rebuilding certain modules dependent on changes in base::Time. http://crbug.com/485435 Original issue's description: > Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/) > > Reason for revert: > Broke iOS build. > > http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio > > Original issue's description: > > Fixit: Factor out common base::Time* math operator overloads. > > > > This is part 1 of a 2-part change to fork base::TimeTicks into three > > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The > > forking of TimeTicks will ensure values from different clocks are not > > erroneously being mixed together when doing time math. > > > > In this change, the identical comparison and math operator overloads > > found in base::Time and base::TimeTicks are being factored-out into a > > templated base class. In a following change, this base class will also > > be used to de-dupe this common functionality in the two new time > > classes. > > > > BUG=467417 > > > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d > > Cr-Commit-Position: refs/heads/master@{#328696} > > TBR=thestig@chromium.org,miu@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=467417 > > Committed: https://crrev.com/a365825583412c355a449274bec70e41e992ffd7 > Cr-Commit-Position: refs/heads/master@{#328706} TBR=thestig@chromium.org,ksakamoto@chromium.org NOPRESUBMIT=true BUG=467417,485435 Review URL: https://codereview.chromium.org/1128273004 Cr-Commit-Position: refs/heads/master@{#328843}

…th operator overloads. (patchset #1 id:1 of https://codereview.chromium.org/1128273004/) Reason for revert: Still breaks iOS bots. Tracking at crbug.com/485435. Original issue's description: > Revert of Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #1 id:1 of https://codereview.chromium.org/1130953002/) > > Reason for revert: > iOS_Device builder was not rebuilding certain modules dependent on changes in base::Time. http://crbug.com/485435 > > Original issue's description: > > Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/) > > > > Reason for revert: > > Broke iOS build. > > > > http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio > > > > Original issue's description: > > > Fixit: Factor out common base::Time* math operator overloads. > > > > > > This is part 1 of a 2-part change to fork base::TimeTicks into three > > > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The > > > forking of TimeTicks will ensure values from different clocks are not > > > erroneously being mixed together when doing time math. > > > > > > In this change, the identical comparison and math operator overloads > > > found in base::Time and base::TimeTicks are being factored-out into a > > > templated base class. In a following change, this base class will also > > > be used to de-dupe this common functionality in the two new time > > > classes. > > > > > > BUG=467417 > > > > > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d > > > Cr-Commit-Position: refs/heads/master@{#328696} > > > > TBR=thestig@chromium.org,miu@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=467417 > > > > Committed: https://crrev.com/a365825583412c355a449274bec70e41e992ffd7 > > Cr-Commit-Position: refs/heads/master@{#328706} > > TBR=thestig@chromium.org,ksakamoto@chromium.org > NOPRESUBMIT=true > BUG=467417,485435 > > Committed: https://crrev.com/59fca1cd30487a013b942acf9d660dfcc639e25a > Cr-Commit-Position: refs/heads/master@{#328843} TBR=thestig@chromium.org,ksakamoto@chromium.org,smut@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467417,485435 Review URL: https://codereview.chromium.org/1125283003 Cr-Commit-Position: refs/heads/master@{#328864}

…0001 of https://codereview.chromium.org/1084793003/) Reason for revert: BUG=480789 Original issue's description: > Re-size frame only for printing selection > > Re-size was added to fix issue 1566. There is a test in #7. > With current state of blink resize is not needed and actually has > issues afters https://codereview.chromium.org/1008513003. > > Printing selection still needs resizing, because selectionAsMarkup() returns > fixed snapshot of frame. Re-layout or re-sizing of the snapshot after > that is not possible. > > BUG=474173 > > Committed: https://crrev.com/51cda916c51147311cf3d13d4305bc6647b22479 > Cr-Commit-Position: refs/heads/master@{#325106} TBR=alekseys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474173 Review URL: https://codereview.chromium.org/1131193002 Cr-Commit-Position: refs/heads/master@{#328873}

…atchset #2 id:20001 of https://codereview.chromium.org/1104193003/) Reason for revert: LayerTreeHostTestBeginMainFrameTimeIsAlsoImplTime started failing since a dependent patch (https://codereview.chromium.org/787763006/) is reverted. example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/24421 Original issue's description: > cc: Test BeginMainFrame values come from BeginImplFrame. > > The frame time in the BeginFrameArgs sent to BeginMainFrame should match a > value from a BeginImplFrame. However there is not a 1:1 relantionship, when the > main thread is slow, there many be multiple impl frames. > > DEPS=http://crrev.com/787763006 > BUG=346230 > R=brianderson,enne > > Committed: https://crrev.com/a003f9bc651a572fea3881cfb72a7d8842c62192 > Cr-Commit-Position: refs/heads/master@{#328929} TBR=brianderson@chromium.org,enne@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346230 Review URL: https://codereview.chromium.org/1133763002 Cr-Commit-Position: refs/heads/master@{#328941}

…#2 id:20001 of https://codereview.chromium.org/1122423007/) Reason for revert: http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/59288 Looks like the __STDC_FORMAT_MACROS thing got lost when inttypes.h and BN_FMT_* were moved to a public header. That it's a public header is... problematic... Original issue's description: > Roll src/third_party/boringssl/src 68de407:65a7e94 > > Summary of changes available at: > https://boringssl.googlesource.com/boringssl/+log/68de407..65a7e94 > > This also removes update_gypi_and_asm.py in favor of the script inside > BoringSSL proper. > > BUG=none > > Committed: https://crrev.com/c80637399c13d7c3e8cb7a16bd5de104feb449e9 > Cr-Commit-Position: refs/heads/master@{#329032} TBR=agl@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1132243002 Cr-Commit-Position: refs/heads/master@{#329035}

… try) (patchset #2 id:20001 of https://codereview.chromium.org/1130523003/) Reason for revert: Looks like interactive_ui_tests needs a dep on chrome too: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/40889/steps/compile/logs/stdio FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated "../out/Release/interactive_ui_tests.isolated" --isolate "interactive_ui_tests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Release " --extra-variable "version_full=44.0.2398.0" --config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux" --config-variable "asan=0" --config-variable "branding=Chrome" --config-variable "chromeos=0" --config-variable "component=static_library" --config-variable "disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable "fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable "libpeer_target_type=static_library" --config-variable "lsan=0" --config-variable "msan=0" --config-variable "target_arch=ia32" --config-variable "tsan=0" --config-variable "use_custom_libcxx=0" --config-variable "use_instrumented_libraries=0" --config-variable "use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=0" --config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable "v8_use_external_startup_data=1" Failed to find an input file: Input file /b/build/slave/google-chrome-rel-linux/build/src/out/Release/chrome doesn't exist Reverting for now, but should be easy to fix. Original issue's description: > Add support for escaped target names in isolate driver (3rd try) > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > 1st try: https://codereview.chromium.org/970203003/ > 1st revert: https://codereview.chromium.org/985753002/ > 2nd try: https://codereview.chromium.org/1103793002/ > 2nd revert: https://codereview.chromium.org/1129493003/ > BUG=462248 > > Committed: https://crrev.com/e94fb8bb82056ce3a255691a9326fd12707cf0cb > Cr-Commit-Position: refs/heads/master@{#329038} TBR=vadimsh@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Review URL: https://codereview.chromium.org/1131363003 Cr-Commit-Position: refs/heads/master@{#329064}

…eption (patchset #2 id:20001 of https://codereview.chromium.org/1132473004/) Reason for revert: broke findbugs: http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/59364 slipped through CQ because analyze in android_clang_dbg_recipe decided it didn't need to compile: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/75301 Original issue's description: > Catch Exception for Intent.parseUri instead of URISyntaxException > > Intent.parseUri can throw other excpetions like NumberFormatException. > So we need to catch Exception to avoid crash. > > BUG=484336 > > Committed: https://crrev.com/e9785bb71f9e0b8a9a3ba321c2c6483c8805e5a1 > Cr-Commit-Position: refs/heads/master@{#329163} TBR=torne@chromium.org,tedchoc@chromium.org,jaekyun@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484336 Review URL: https://codereview.chromium.org/1139753003 Cr-Commit-Position: refs/heads/master@{#329170}

…Bluetooth permission. (patchset #2 id:110001 of https://codereview.chromium.org/1129683002/) Reason for revert: Failing on the main waterfall: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27824 Original issue's description: > bluetooth: Android adapter can be created with and without Bluetooth permission. > > This enables unit tests to run with Bluetooth permission, > by adding the Bluetooth permission to native_test. > > Non-test applications will not have the Bluetooth permission, > and unit tests should also verify behavior > when the permission is not given. To enable this > createWithoutPermissionForTesting is added and > results in a state equivalent to when the permission > is not available. > > Unit tests will be built in parallel for both when Bluetooth > permission exists and doesn't. > > BUG=471536 > > Committed: https://crrev.com/30e81472dc168ea1c331a8779b3f6a14f684c54b > Cr-Commit-Position: refs/heads/master@{#329212} TBR=tedchoc@chromium.org,armansito@chromium.org,scheib@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471536 Review URL: https://codereview.chromium.org/1137083002 Cr-Commit-Position: refs/heads/master@{#329240}

…(patchset #2 id:20001 of https://codereview.chromium.org/1127383007/) Reason for revert: This has caused failures on the memory bots. e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179 Sample test output: [ RUN ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection ==6485== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f5bc93bb605 in ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound const&, ui::SelectionBound const&) ui/touch_selection/touch_selection_controller.cc:71:27 #1 0x7f5bc922803a in ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool, gfx::RectF const&, bool) ui/touch_selection/touch_selection_controller_unittest.cc:147:5 #2 0x7f5bc9278c8d in ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody() ui/touch_selection/touch_selection_controller_unittest.cc:946:3 #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12 #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0 #5 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #6 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #8 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #9 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0 #10 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0 #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10 #13 0x7f5bc92f85ee in Run base/callback.h:396:12 #14 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10 #17 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 #18 0x7f5bc9188f38 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0 #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp() ui/touch_selection/touch_selection_controller_unittest.cc:65:23 #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12 #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0 #4 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #5 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #7 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #8 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0 #9 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0 #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10 #12 0x7f5bc92f85ee in Run base/callback.h:396:12 #13 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10 #16 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605) Exiting Original issue's description: > Be explicit about forcing TouchSelectionController updates > > Previously, cached values in the TouchSelectionController would be reset > to force future selection updates. However, these cached values can > actually be used outside of selection update calls, e.g., when force > showing the selection from the current cached values. Instead of > resetting the cached values, simply set a dirty bit that forces an > update, avoiding issues when dealing with the reset values. > > BUG=393025 > > Committed: https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83 > Cr-Commit-Position: refs/heads/master@{#329325} TBR=mohsen@chromium.org,jdduke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393025 Review URL: https://codereview.chromium.org/1139533006 Cr-Commit-Position: refs/heads/master@{#329352}

…t page. (patchset #2 id:20001 of https://codereview.chromium.org/1137773003/) Reason for revert: We're seeing crashes; this looks to be the wrong approach. Original issue's description: > Tests that the title only ever gets replaced for the current page. > > BUG=369661 > TEST=All tests remain green. > > Committed: https://crrev.com/e5fab09f6e313f78d4113e4d4fe0ce3b38ce0ca5 > Cr-Commit-Position: refs/heads/master@{#329414} TBR=creis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Review URL: https://codereview.chromium.org/1144443005 Cr-Commit-Position: refs/heads/master@{#329686}

…20001 of https://codereview.chromium.org/1137663006/) Reason for revert: This is converting the original crash to another crash. Will need another null check. Original issue's description: > Fix WebViewPlugin::scheduleAnimation crash > > The crash was probably due to accessing a dangling pointer to the plugin > container during a small time frame between PepperWebPluginImpl::destroy() > and the destructor being called. (Speculated from source since no reliable > repro is found.) > > This CL clears eveything in the destroy() function as if the destructor has > been called, only delaying memory release. > > R=tommycli > BUG=483068 > > Committed: https://crrev.com/6a9b5b10ff3515adb47718fc23ebe039a9e3b9ff > Cr-Commit-Position: refs/heads/master@{#329309} TBR=tommycli@chromium.org,raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487607,483068 Review URL: https://codereview.chromium.org/1127293004 Cr-Commit-Position: refs/heads/master@{#329715}

StartSrpcServices will require using the service_runtime pointer, to set up the srpc_client pointer. So we cannot destroy the service_runtime at the same time. E.g., if I add a sleep() to induce the race, I get: ../../native_client/src/include/nacl_scoped_ptr.h:96: C *nacl::scoped_ptr<plugin::SelLdrLauncherChrome>::operator->() const [C = plugin::SelLdrLauncherChrome]: Assertion `ptr_ != __null' failed. Received signal 6 #0 0x7f687f4aef7e base::debug::StackTrace::StackTrace() #1 0x7f687f4aeabf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f6879dee340 <unknown> #3 0x7f6876504cc9 gsignal #4 0x7f68765080d8 abort #5 0x7f68764fdb86 <unknown> #6 0x7f68764fdc32 __assert_fail #7 0x7f688e2887f2 nacl::scoped_ptr<>::operator->() #8 0x7f688e288487 plugin::ServiceRuntime::SetupAppChannel() #9 0x7f688e28cb76 plugin::NaClSubprocess::StartSrpcServices() #10 0x7f688e281810 plugin::PnaclTranslateThread::DoLink() #11 0x7f688e27fe7d plugin::PnaclTranslateThread::DoLinkThread() #12 0x7f6879de6182 start_thread #13 0x7f68765c847d clone Should have checked this in previous refactoring: https://codereview.chromium.org/1128943003 BUG=473474 Review URL: https://codereview.chromium.org/1128373005 Cr-Commit-Position: refs/heads/master@{#329718}

…omium.org/1141753002/) Reason for revert: broke linux gn build ../../third_party/angle/src/libANGLE/Display.cpp:113:24:error: no type named 'DisplayGLX' in namespace 'rx' impl = new rx::DisplayGLX(); ~~~~^ 1 error generated. ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/190/steps/compile/logs/stdio Original issue's description: > Roll ANGLE. > > https://chromium.googlesource.com/angle/angle/+log/b11e24..71632d > > BUG=484963 > BUG=483252 > > Committed: https://crrev.com/6e8e29564f8590bff2215668d959b17075b96240 > Cr-Commit-Position: refs/heads/master@{#329727} TBR=jmadill@chromium.org,geofflang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484963 Review URL: https://codereview.chromium.org/1128913010 Cr-Commit-Position: refs/heads/master@{#329741}

1. Recently close tabs 2. Download cancel dialog 3. Cloud Printer discovery 4. extension: usb device selection For #2, some strings are revised per the string review with ainslie@. For both browser shutdown and incognito exit, the title is simply 'Download in progress' and the 'go-ahead' button is simply 'Cancel download' (or their plural forms). Besides, recently_closed.js is also removed because it's not used any more and removing it let us drop two strings (about closed_tabs) that has become unnecessary with this CL. BUG=21407,455005,482092 TEST=Open a new window, open multiple tabs and close the windows. In another window, go to 'Recent tabs' menu. '# tabs' for the closed window is shown as expected TEST=1. Go to http://www.thinkbroadband.com/download.html 2. Start downloading a single file 3. Try to quit chrome before the download is completed 4. Check the dialog popping up. TEST=Do the above with multiple file downloads TEST=Do the above two in the only open incognito window (close the only open incognito window) Review URL: https://codereview.chromium.org/1103293004 Cr-Commit-Position: refs/heads/master@{#329747}

…set #2 id:20001 of https://codereview.chromium.org/1135383002/) Reason for revert: Seems to break browser_tests failed interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1). This CL was the best I could find in the blame list. Reverting as Chrome sheriff to see if it helps. See https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1252 Original issue's description: > Add the chrome.fileSystem.onVolumeListChanged event. > > This CL adds an event which notifies extension about changed list of volumes > which can be requested via chrome.fileSystem.requestFileSystem. > > TEST=browser_tests: *OnVolumeListChanged* > BUG=440674 > > Committed: https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f > Cr-Commit-Position: refs/heads/master@{#330047} TBR=benwells@chromium.org,mtomasz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440674 Review URL: https://codereview.chromium.org/1145563002 Cr-Commit-Position: refs/heads/master@{#330064}

…s. (patchset #2 id:20001 of https://codereview.chromium.org/1125173006/) Reason for revert: This CL broke Linux GN Clobber bot. Original issue's description: > Disable user gesture checking for all autofill browser tests. > > When drmemory_full runs, the browser tests are slowed down enough to > timeout the user gesture indicator, which prevents autofill from > processing the input and passing the browser test. The fix is to disable > user gesture checking for all autofill browser tests except > AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. > > BUG=484910 TBR=estade@chromium.org,thestig@chromium.org,rouslan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484910 Review URL: https://codereview.chromium.org/1140013004 Cr-Commit-Position: refs/heads/master@{#330272}

The only thing we need to know per QuerySync block is its index in the block sequence. Everything else can be calculated from that if we just store a few numbers in the Bucket objects. Total memory reduction is 92%. This is alt #2 in bug 485536. BUG=485536 Review URL: https://codereview.chromium.org/1131913004 Cr-Commit-Position: refs/heads/master@{#330334}

…hset #2 id:20001 of https://codereview.chromium.org/1143473002/) Reason for revert: Incorrect logic for determining if async uploads is used Original issue's description: > content: Use NumberOfProcessors() / 2 raster threads. > > 4 raster threads improve performance on 8 core machines. > 8 core machines might not be a priority but it seems > like an unnecessary limitation to have. > > BUG= > > Committed: https://crrev.com/4a0177a1dba8197f61021ff3b4f9426e45faaa62 > Cr-Commit-Position: refs/heads/master@{#330427} TBR=danakj@chromium.org,enne@chromium.org,piman@chromium.org,vmpstr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1136633006 Cr-Commit-Position: refs/heads/master@{#330520}

…#2 id:20001 of https://codereview.chromium.org/1148613002/) Reason for revert: seems to break the build https://build.chromium.org/p/chromium/builders/Android/builds/40042 Original issue's description: > [Sync] Remove periodic sync for Chrome for Android > > updateAccount() is always called on startup with the signed in account, > so the removePeriodicSync() call will be hit even for already signed in > users when the app restarts. > > BUG=480688 > > Committed: https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36 > Cr-Commit-Position: refs/heads/master@{#330588} TBR=nyquist@chromium.org,maxbogue@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480688 Review URL: https://codereview.chromium.org/1135113006 Cr-Commit-Position: refs/heads/master@{#330592}

… to "none" type. (patchset #2 id:20001 of https://codereview.chromium.org/1138103003/) Reason for revert: Patch landed despite rejection from code reviewers. Original issue's description: > Remember previous keyboard type and use that when switching to "none" type. > > BUG=484139 > > Committed: https://crrev.com/e8e5d60be5f3b36634a1b012ec21874a4abe0ef0 > Cr-Commit-Position: refs/heads/master@{#330551} TBR=aurimas@chromium.org,bcwhite@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484139 Review URL: https://codereview.chromium.org/1148503003 Cr-Commit-Position: refs/heads/master@{#330625}

…nkTestRunner (patchset #2 id:250001 of https://codereview.chromium.org/1125133005/) Reason for revert: Broke a bunch of Layout Tests. Here's an example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fstable%2Fanimations-unprefixed%2Fanimation-events-prefixed-04.html STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0) STDERR: #0 0x6a00bcf in content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43 STDERR: #1 0x4e5d9d in OnSetBluetoothAdapter content/shell/browser/layout_test/layout_test_message_filter.cc:171:3 STDERR: #2 0x4e5d9d in DispatchToMethodImpl<content::LayoutTestMessageFilter, void (content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &), std::__1::basic_string<char> , 0> base/tuple.h:252:0 Original issue's description: > bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner > > This patch removes the testing IPC from BluetoothDispatcher and > BluetoothDispatcherHost. > > This patch also changes the way the mock BluetoothAdapter was set in > BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter, > BluetoothDispatcherHost exposes a function to directly set the adapter. > This function is used by LayoutTestSupport to set the adapter. > > Mock adapter flow before: > BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC--> > BluetoothDispatcherHost (Mock constructed here) > > After: > BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) -> > LayoutTestSupport -> BluetoothDispatcherHost > > This is the first of two patches to remove testing from BluetoothDispatcher > and BluetoothDispatcherHost: > > [1] This patch. > [2] http://crrev.com/1132943002 > > BUG=436284 > > Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85 > Cr-Commit-Position: refs/heads/master@{#330647} TBR=jam@chromium.org,scheib@chromium.org,tsepez@chromium.org,ortuno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436284 Review URL: https://codereview.chromium.org/1142303002 Cr-Commit-Position: refs/heads/master@{#330653}

…lay. (patchset #2 id:40001 of https://codereview.chromium.org/1148233002/) Reason for revert: Reverting due to compile failure on Google Chrome Mac builder: ../../media/cast/sender/h264_vt_encoder_unittest.cc:282:38: error: no viable conversion from 'Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'Callback<void (scoped_ptr<media::cast::SenderEncodedFrame>)>' VideoEncoder::FrameEncodedCallback cb = base::Bind( ^ ~~~~~~~~~~~ ../../base/callback.h:358:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'base::Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'base::Callback<void (scoped_ptr<media::cast::SenderEncodedFrame, base::DefaultDeleter<media::cast::SenderEncodedFrame> >)> &&' for 1st argument class Callback; http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Mac&number=1293 Original issue's description: > [Cast] Compute utilization metrics and add performance overlay. > > Adds computation of two frame-level utilization metrics to the software > VP8 encoder in Cast: deadline utilization and lossy utilization. The > first is a measure of how long the encoding of each frame takes compared > to the frame duration. The second is a measure of the complexity of a > frame, in terms of the quality versus encoded size trade-off. > > In a future change, these utilization metrics will be sent as feedback > signals to the producer of the video frames, allowing the producer to > adjust data volumes based on the consumer's capability throughout a > session. See bug for more details. > > Also, this change adds an overlay display, where frame-level performance > metrics are rendered in the lower-right corner of each video frame just > before it is sent. This provides an "on screen display" of end-to-end > system performance. This is turned on with a command line argument: > --vmodule=performance_metrics_overlay=3 > > BUG=156767 > > Committed: https://crrev.com/d9e741512cd6ea56cefd0173b371d0dd29f0cce5 > Cr-Commit-Position: refs/heads/master@{#330896} TBR=hubbe@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=156767 Review URL: https://codereview.chromium.org/1143363005 Cr-Commit-Position: refs/heads/master@{#330906}

…chset #2 id:20001 of https://codereview.chromium.org/1151013002/) Reason for revert: It looks like this is causing a failure on Mac10.9 Tests bot. https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2130 Original issue's description: > Enable more benchmark_smoke_unittest coverage (Reland) > > Previously, benchmark_smoke_unittest has a heuristic to pick > a benchmark for smoke testing if the benchmark uses a test > in measurement directory. > This patch removes that check, and instead provide a black > list of benchmarks module that we exclude the > benchmark_smoke_unittest to avoid high CQ time. > > This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks > (one benchmark per benchmark module). > > On my local linux machine, this increases the cycle time of > benchmark_smoke_unittest from 20s -> 1m7s. > > To review this, the first patch is from issue 1144193002 at patchset 100001 (http://crrev.com/1144193002#ps100001) > Second patch adds indexeddb_perf to the black list of benchmarks to be smoke tested. > > BUG=490130 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2a13f1055fbba6ccb341b6fe3cab59647c876153 > Cr-Commit-Position: refs/heads/master@{#331000} TBR=sullivan@chromium.org,dtu@chromium.org,skyostil@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490130 Review URL: https://codereview.chromium.org/1152113002 Cr-Commit-Position: refs/heads/master@{#331043}

…(Sub)TextureCHROMIUM. (patchset #10 id:200001 of https://codereview.chromium.org/1275773003/ ) Reason for revert: Linux AMD GPU FYI bot has a broken gl_tests, likely because of this patch. http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/41273 [ RUN ] GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.Basic/2 Received signal 11 SEGV_MAPERR 000000000045 #0 0x000000492795 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7ff52630acb0 <unknown> #2 0x7ff5232a858c <unknown> #3 0x7ff5230a247c <unknown> #4 0x7ff5230a33ae <unknown> #5 0x7ff5227e8585 <unknown> #6 0x7ff5227e9b0a <unknown> #7 0x7ff522bf75c3 <unknown> #8 0x0000004f7ba4 gfx::GLApiBase::glCopyTexImage2DFn() #9 0x000000596ac1 (anonymous namespace)::DoCopyTexImage2D() #10 0x0000005968c4 gpu::CopyTextureCHROMIUMResourceManager::DoCopyTexture() Original issue's description: > gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. > > It makes it possible to optimize WebGL. > > TEST=gl_tests GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.* > BUG=517548 > > Committed: https://crrev.com/fa25f0e5786527e63c6ff9aeda77da3bd7456ee3 > Cr-Commit-Position: refs/heads/master@{#347354} TBR=piman@chromium.org,sievers@chromium.org,kbr@chromium.org,zmo@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517548,528374 Review URL: https://codereview.chromium.org/1304103005 Cr-Commit-Position: refs/heads/master@{#347465}

ryumiel closed this as completed Apr 22, 2015

ryumiel mentioned this issue May 8, 2015

Problems running some extensions inside browserAction sidebar #8

Closed

ltilve mentioned this issue Aug 3, 2015

Having different extensions on the sidebar tests #38

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove extension_sidebar_*.[h|cc] from browserAction CL #2

Remove extension_sidebar_*.[h|cc] from browserAction CL #2

ryumiel commented Apr 16, 2015

ryumiel commented Apr 16, 2015

ryumiel commented Apr 22, 2015

Remove extension_sidebar_*.[h|cc] from browserAction CL #2

Remove extension_sidebar_*.[h|cc] from browserAction CL #2

Comments

ryumiel commented Apr 16, 2015

ryumiel commented Apr 16, 2015

ryumiel commented Apr 22, 2015