Test fails at BrowserWindowControllerTest.TestSplitViewsAreNotOpaque #7
Comments
|
Crash was fixed by 05090c9e444d73a863990787802ba8727e63ef6e, ../../chrome/browser/ui/cocoa/browser_window_controller_unittest.mm:701: Failure [----------] Global test environment tear-down 1 FAILED TEST |
ryumiel
changed the title
ryumiel
changed the title
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…d lifetime mgmt in VideoCaptureBufferPool (patchset #7 id:480001 of https://codereview.chromium.org/1064963002/) Reason for revert: The reason for reverting is: Speculatively revert to address Android Tests (dbg) content_unittests failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27395 content_unittests content_unittests failures: VideoCaptureBufferPoolTest.BufferPool/2 GpuMemoryBufferFactoryTests/GpuMemoryBufferFactoryTest.CreateAndDestroy/1 VideoCaptureBufferPoolTest.BufferPool/0 VideoCaptureBufferPoolTest.BufferPool/1 [ RUN ] VideoCaptureBufferPoolTest.BufferPool/0 [FATAL:browser_gpu_memory_buffer_manager.cc(56)] Check failed: !g_gpu_memory_buffer_manager. #00 0x764081d3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fdf1d3 #1 0x75cf95c3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x008d05c3 #2 0x75a3c697 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00613697 #3 0x75f8d1fb /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b641fb #4 0x75f8d35b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b6435b #5 0x75f8d3e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b643e3 #6 0x75f8d5e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b645e3 #7 0x75f8c3c7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b633c7 #8 0x75f49bb7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b20bb7 #9 0x75f41c8b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b18c8b #10 0x75736087 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x0030d087 #11 0x763de291 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fb5291 #12 0x41503bcf /system/lib/libdvm.so+0x0001dbcf #13 0x41534125 /system/lib/libdvm.so+0x0004e125 #14 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #15 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #16 0x4151163b /system/lib/libdvm.so+0x0002b63b #17 0x41546863 /system/lib/libdvm.so+0x00060863 #18 0x4154e7c5 /system/lib/libdvm.so+0x000687c5 #19 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3 #20 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3 #21 0x4151163b /system/lib/libdvm.so+0x0002b63b #22 0x4154657f /system/lib/libdvm.so+0x0006057f #23 0x4152fd0d /system/lib/libdvm.so+0x00049d0d #24 0x401a82b3 /system/lib/libandroid_runtime.so+0x0004d2b3 #25 0x401a8fd9 /system/lib/libandroid_runtime.so+0x0004dfd9 #26 0x4006b05d /system/bin/app_process+0x0000105d #27 0x400a234b /system/lib/libc.so+0x0000e34b This CL is the most suspect in the blame-list because it touches the VideoCaptureBufferPool. Original issue's description: > VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool & relatives > > - This CL adds support for GpuMemoryBufferTracker in > addition to the existing SharedMemTracker. > > - A GpuMemoryBufferTracker owns a GpuMemoryBuffer, > which can only be accessed byte-wise between Map() and > Unmap(). > > - For that reason, instead of making a VCBP::Tracker > directly accessible via |void* data| and |size|, a > BufferHandle abstraction is introduced. > > - VideoCaptureDeviceClient then defines its own > AutoReleaseBuffer in terms of this new BufferHandle. > This BufferHandle is supposed to stay Map()ed and > ready to use for the duration of its lifetime. > > Summing up: > * VideoCaptureBufferPool has a pool of Trackers, > * from the VCBP we can get a BufferHandle per |buffer_id|, > * from a BufferHandle we can obtain data(), valid > and Map()ed as long as the BufferHandle itself exists. > > - VideoCaptureDevice::ReserveOutputBuffer() changes to > return a scoped_ptr<Buffer> ISO a scoped_refptr. > > - Added VideoCaptureDevice::OnIncomingCapturedBuffer() > to pass directly a Buffer with the capture contents. > > - video_capture_texture_wrapper.{cc,h} is removed and > its contents are merged into VideoCaptureDeviceClient. > > - FakeVideoCaptureDevice learns how to produce > GpuMemoryBuffers. Also, PIXEL_FORMAT_GPUMEMORYBUFFER > is added. > > Summing up, VCDClient accepts: > * memory backed buffers (the usual) > * texture-backed buffers > * GMB-backed buffers (these are wrapped into a Texture > VideoFrame indistinguishable from the previous case) > > - VideoCaptureTextureWrapper files are gone and > its contents folded into VideoCaptureDeviceClient. > > - Unittests are updated, and so is FakeVideoCaptureDevice. > > BUG=440843 > > Committed: https://crrev.com/abeb15fa955c570cd481accb04c2a677eb2865a9 > Cr-Commit-Position: refs/heads/master@{#326171} TBR=miu@chromium.org,emircan@chromium.org,avi@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440843 Review URL: https://codereview.chromium.org/1090273006 Cr-Commit-Position: refs/heads/master@{#326250}
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…atchset #1 id:1 of https://codereview.chromium.org/1099063003/) Reason for revert: Speculatively revert to address Linux ChromiumOS Tests browser_tests failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1742 browser_tests RestoreOnStartupTestChromeOS.PRE_LogInAndVerify 596 disabled 10 flaky failed 2 failures: RestoreOnStartupTestChromeOS.LogInAndVerify RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [385/509] RestoreOnStartupTestChromeOS.LogInAndVerify (SKIPPED) [ RUN ] RestoreOnStartupTestChromeOS.PRE_LogInAndVerify [ FATAL ] ../../testing/gtest/include/gtest/gtest.h:1849:: Condition parameter_ != NULL failed. GetParam() can only be called inside a value-parameterized test -- did you intend to write TEST_P instead of TEST_F? Received signal 6 #0 0x7ff3af22e6de base::debug::StackTrace::StackTrace() #1 0x7ff3af22e21f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7ff3abc5dcb0 <unknown> #3 0x7ff3a78320d5 gsignal #4 0x7ff3a783583b abort #5 0x00000074f9d9 testing::internal::posix::Abort() #6 0x0000024055b0 testing::internal::GTestLog::~GTestLog() #7 0x0000007477b3 testing::WithParamInterface<>::GetParam() #8 0x0000012ecb31 policy::LoginPolicyTestBase::LoginPolicyTestBase() #9 0x0000012fc025 policy::RestoreOnStartupTestChromeOS::RestoreOnStartupTestChromeOS() #10 0x0000012fd18c policy::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test() #11 0x0000012fd117 testing::internal::TestFactoryImpl<>::CreateTest() #12 0x0000007009ca _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #13 0x00000241ab2e testing::internal::HandleExceptionsInMethodIfSupported<>() #14 0x000002410383 testing::TestInfo::Run() #15 0x00000241094a testing::TestCase::Run() #16 0x000002415ccc testing::internal::UnitTestImpl::RunAllTests() #17 0x00000242c01a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #18 0x00000241bf4e testing::internal::HandleExceptionsInMethodIfSupported<>() #19 0x00000241596f testing::UnitTest::Run() #20 0x0000022d95e1 RUN_ALL_TESTS() #21 0x0000022d8647 base::TestSuite::Run() #22 0x0000010d2b72 ChromeBrowserTestSuiteRunner::RunTestSuite() #23 0x00000224de78 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #24 0x000004c38ed5 content::LaunchTests() #25 0x00000224ddb9 LaunchChromeTests() #26 0x0000010d2ad8 main #27 0x7ff3a781d76d __libc_start_main #28 0x000000672fe9 <unknown> r8: 00007ff3a51dc8c0 r9: 00007ff3a51dc8c0 r10: 0000000000000008 r11: 0000000000000202 r12: 0000000000672fc0 r13: 00007fffdd71f330 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000005662 si: 0000000000005662 bp: 00007fffdd71e270 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffdd71e138 ip: 00007ff3a78320d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Add browser test for RestoreOnStartup[URLs] on Chrome OS > > Ladies and gentlemen, this CL brings you the long-awaited end-to-end > browser test for RRestoreOnStartup and RestoreOnStartupURLs, at least > on Chrome OS. > > BUG=477145 > TEST=New browser test > > Committed: https://crrev.com/641bb06057cf18e518a96edaadaae42411341905 > Cr-Commit-Position: refs/heads/master@{#326261} TBR=mnissler@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477145 Review URL: https://codereview.chromium.org/1103493003 Cr-Commit-Position: refs/heads/master@{#326272}
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…l. (patchset #7 id:180001 of https://codereview.chromium.org/1073893003/) Reason for revert: Speculative revert to fix content_unittests failures: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27420 Original issue's description: > [Presentation API] Implement ondefaultsessionstart in PSImpl. > > Added DefaultSessionStartContext for coordinating sending default > session back to PresentationDispatcher. > > When ListenForDefaultSessionStart is called, DefaultSessionStartContext > will be installed on PresentationServiceImpl. When both the default > session and PresentationDispatcher's callback are available, the > callback will be invoked with the session. > > On Reset(), if a callback is available, it will be invoked with null. > Changed PresentationDispatcher to not update Blink in that case. > > Also, PSImpl now keeps track of the corresponding RFH's ID instead of > RFH* since most of the time we only need to use the ID. > > Changed PresentationServiceDelegate's Add/RemoveObserver interface, > since the PresentationServiceDelegate need to be able to correlate > an Observer with a RFH. (at most 1 per RFH, as it stands today). > > Added OnDefaultPresentationStarted to > PresentationServiceDelegate::Observer interface and implemented it > in PresentationServiceImpl. > > Added tests in PresentationServiceImpl. > > BUG=459001 > > Committed: https://crrev.com/79ddfb2383dca537e481eb9e0a477267dd48bc60 > Cr-Commit-Position: refs/heads/master@{#326353} TBR=avayvod@google.com,avi@chromium.org,imcheng@chromium.org,mfoltz@chromium.org,avayvod@chromium.org,imcheng@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459001 Review URL: https://codereview.chromium.org/1102683002 Cr-Commit-Position: refs/heads/master@{#326378}
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…ttps://codereview.chromium.org/1085703003/) Reason for revert: jingle_unittests failure on Mac ASan 64 Tests (1) https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/805 BUG=480107 Original issue's description: > Use standard ICE in Chromoting. > > Previously we were using legacy, non-standard version of ICE. This > change adds ICE version negotiation and enabled standard ICE by default, > when both peers support it. > > BUG=473758 > > Committed: https://crrev.com/4b35571a3085aa960dcf5533fb2277d5dcaaf11f > Cr-Commit-Position: refs/heads/master@{#326435} TBR=rmsousa@chromium.org,wez@chromium.org,dcaiafa@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473758 Review URL: https://codereview.chromium.org/1099203005 Cr-Commit-Position: refs/heads/master@{#326458}
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…ttps://codereview.chromium.org/1085703003/) Reason for revert: This change did cause test failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/34169/ (the link in the first revert was incorrect) Original issue's description: > Use standard ICE in Chromoting. > > Previously we were using legacy, non-standard version of ICE. This > change adds ICE version negotiation and enabled standard ICE by default, > when both peers support it. > > BUG=473758 > > Committed: https://crrev.com/5a5854ee3e1c5760b422f26d31909bfb5dca631f > Cr-Commit-Position: refs/heads/master@{#326560} TBR=rmsousa@chromium.org,wez@chromium.org,dcaiafa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473758 Review URL: https://codereview.chromium.org/1089253005 Cr-Commit-Position: refs/heads/master@{#326570}
ryumiel
pushed a commit
that referenced
this issue
Apr 28, 2015
…id:140001 of https://codereview.chromium.org/1097663003/) Reason for revert: Caused browser_tests failure. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1403/steps/browser_tests Original issue's description: > Fetch OAuth2 tokens prior to profile creation. > > BUG=470984 > TEST= > > Committed: https://crrev.com/163a4a63af5e56801395eed067a69e501e7b51a5 > Cr-Commit-Position: refs/heads/master@{#326691} TBR=xiyuan@chromium.org,nkostylev@chromium.org,achuith@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470984 Review URL: https://codereview.chromium.org/1102863002 Cr-Commit-Position: refs/heads/master@{#326713}
|
Fixed at ee6b4e1 |
ryumiel
pushed a commit
that referenced
this issue
May 7, 2015
…t pages. (patchset #7 id:120001 of https://codereview.chromium.org/1081803003/) Reason for revert: Caused compile error on Win x64 GN bot Original issue's description: > Limit form-less Autofilling to pages that look like checkout pages. > > This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout. > > Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information"). > > BUG=471090,477466 > > Committed: https://crrev.com/aa3219ce27ef5471c19670fe5145b136925cbc89 > Cr-Commit-Position: refs/heads/master@{#327108} TBR=thestig@chromium.org,brettw@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471090,477466 Review URL: https://codereview.chromium.org/1106313002 Cr-Commit-Position: refs/heads/master@{#327116}
ryumiel
pushed a commit
that referenced
this issue
May 7, 2015
…id:120001 of https://codereview.chromium.org/1114833002/) Reason for revert: Fails on the chromiumos.chromium builder (unused variable): https://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29/builds/4458 Original issue's description: > Implementation of the remote screenshot command > > Implementation of the remote screenshot command for kiosk sessions. The commit > also refactors the Upload job splitting it into an interace and an > implementation to make it mockable. > > BUG=480982 > TESTS=unit_tests > > Committed: https://crrev.com/097a518a23ab1533034d5f27667c527719a8eb67 > Cr-Commit-Position: refs/heads/master@{#327792} TBR=atwilson@chromium.org,cschuet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480982 Review URL: https://codereview.chromium.org/1118203002 Cr-Commit-Position: refs/heads/master@{#327879}
ryumiel
pushed a commit
that referenced
this issue
May 7, 2015
…ved tests (patchset #2 id:60001 of https://codereview.chromium.org/1086863004/) Reason for revert: Breaks the memory sanitizer on CrOS: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/981/steps/browser_tests/logs/DownloadNotificationTest.DownloadRemoved ================================================================= ==2998==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 416 byte(s) in 1 object(s) allocated from: #0 0x5b583b in operator new(unsigned long) (/tmp/run_tha_testDL6ABE/out/Release/browser_tests+0x5b583b) #1 0x37f8977 in DownloadNotificationItem::DownloadNotificationItem(content::DownloadItem*, Profile*, DownloadNotificationItem::Delegate*) chrome/browser/download/notification/download_notification_item.cc:86:23 #2 0x3443434 in DownloadNotificationManager::OnNewDownloadReady(content::DownloadItem*) chrome/browser/download/notification/download_notification_manager.cc:45:11 #3 0x2e8993d in DownloadUIController::OnDownloadUpdated(content::DownloadManager*, content::DownloadItem*) chrome/browser/download/download_ui_controller.cc:146:3 #4 0x765f4df in content::DownloadItemImpl::UpdateObservers() content/browser/download/download_item_impl.cc:301:3 #5 0x7669506 in content::DownloadItemImpl::OnDownloadRenamedToIntermediateName(content::DownloadInterruptReason, base::FilePath const&) content/browser/download/download_item_impl.cc:1263:5 #6 0x7cf365c in Run base/callback.h:396:12 #7 0x7cf365c in MakeItSo base/bind_internal.h:293 #8 0x7cf365c in base::internal::Invoker\u003CIndexSequence\u003C0ul, 1ul>, base::internal::BindState\u003Cbase::Callback\u003Cvoid (content::DownloadInterruptReason, base::FilePath const&)>, void (content::DownloadInterruptReason, base::FilePath const&), base::internal::TypeList\u003Ccontent::DownloadInterruptReason, base::FilePath> >, base::internal::TypeList\u003Cbase::internal::UnwrapTraits\u003Ccontent::DownloadInterruptReason>, base::internal::UnwrapTraits\u003Cbase::FilePath> >, base::internal::InvokeHelper\u003Cfalse, void, base::Callback\u003Cvoid (content::DownloadInterruptReason, base::FilePath const&)>, base::internal::TypeList\u003Ccontent::DownloadInterruptReason const&, base::FilePath const&> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:343 #9 0x3f18cc6 in Run base/callback.h:396:12 #10 0x3f18cc6 in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x3e336f7 in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:444:3 #12 0x3e340df in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) base/message_loop/message_loop.cc:454:5 #13 0x3e34947 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:566:13 #14 0x3f12256 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7 #15 0x3f12256 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109 #16 0x7f0a333dbd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539 #17 0x7f0a333dbd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075 Original issue's description: > [Download Notification] Add cancel-button and download-removed tests > > This patch adds the following tests: > - Clicking cancel-button while download is in progress > - Clicking cancel-button after download is finished > - Download is removed externally > > BUG=480489 > TEST=manually tested > > Committed: https://crrev.com/24185c2b385071c1ba007b3cc16f52692dd78d02 > Cr-Commit-Position: refs/heads/master@{#328059} TBR=asanka@chromium.org,yoshiki@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480489 Review URL: https://codereview.chromium.org/1116923004 Cr-Commit-Position: refs/heads/master@{#328105}
ryumiel
pushed a commit
that referenced
this issue
May 11, 2015
…0001 of https://codereview.chromium.org/1084793003/) Reason for revert: BUG=480789 Original issue's description: > Re-size frame only for printing selection > > Re-size was added to fix issue 1566. There is a test in #7. > With current state of blink resize is not needed and actually has > issues afters https://codereview.chromium.org/1008513003. > > Printing selection still needs resizing, because selectionAsMarkup() returns > fixed snapshot of frame. Re-layout or re-sizing of the snapshot after > that is not possible. > > BUG=474173 > > Committed: https://crrev.com/51cda916c51147311cf3d13d4305bc6647b22479 > Cr-Commit-Position: refs/heads/master@{#325106} TBR=alekseys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474173 Review URL: https://codereview.chromium.org/1131193002 Cr-Commit-Position: refs/heads/master@{#328873}
ryumiel
pushed a commit
that referenced
this issue
May 11, 2015
…5151) (patchset #7 id:120001 of https://codereview.chromium.org/981593002/) Reason for revert: Broke the Windows GN bots (https://build.chromium.org/p/chromium.win/builders/Win8%20GN) Original issue's description: > Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) > > This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code. > See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/ > > Summary of changes available at: > https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85 > > BUG=328475 > > Committed: https://crrev.com/94c5e80d3a385e223279b8ddb3ed8aa19d69a0e9 > Cr-Commit-Position: refs/heads/master@{#328972} TBR=jiayl@chromium.org,juberti@chromium.org,thakis@chromium.org,mail@joachim-bauch.de NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328475 Review URL: https://codereview.chromium.org/1131323002 Cr-Commit-Position: refs/heads/master@{#328981}
ryumiel
pushed a commit
that referenced
this issue
May 18, 2015
…(patchset #2 id:20001 of https://codereview.chromium.org/1127383007/) Reason for revert: This has caused failures on the memory bots. e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179 Sample test output: [ RUN ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection ==6485== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f5bc93bb605 in ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound const&, ui::SelectionBound const&) ui/touch_selection/touch_selection_controller.cc:71:27 #1 0x7f5bc922803a in ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool, gfx::RectF const&, bool) ui/touch_selection/touch_selection_controller_unittest.cc:147:5 #2 0x7f5bc9278c8d in ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody() ui/touch_selection/touch_selection_controller_unittest.cc:946:3 #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12 #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0 #5 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #6 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #8 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #9 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0 #10 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0 #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10 #13 0x7f5bc92f85ee in Run base/callback.h:396:12 #14 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10 #17 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 #18 0x7f5bc9188f38 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0 #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp() ui/touch_selection/touch_selection_controller_unittest.cc:65:23 #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12 #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0 #4 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #5 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #7 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #8 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0 #9 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0 #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10 #12 0x7f5bc92f85ee in Run base/callback.h:396:12 #13 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10 #16 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605) Exiting Original issue's description: > Be explicit about forcing TouchSelectionController updates > > Previously, cached values in the TouchSelectionController would be reset > to force future selection updates. However, these cached values can > actually be used outside of selection update calls, e.g., when force > showing the selection from the current cached values. Instead of > resetting the cached values, simply set a dirty bit that forces an > update, avoiding issues when dealing with the reset values. > > BUG=393025 > > Committed: https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83 > Cr-Commit-Position: refs/heads/master@{#329325} TBR=mohsen@chromium.org,jdduke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393025 Review URL: https://codereview.chromium.org/1139533006 Cr-Commit-Position: refs/heads/master@{#329352}
ryumiel
pushed a commit
that referenced
this issue
May 18, 2015
…id:120001 of https://codereview.chromium.org/1134633003/) Reason for revert: MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327 Original issue's description: > Drive: Let DriveUploader use batch request API. > > The CL lets DriveUploader use batch request API. DriveUploader does asynchronous > preparation before calling API on service interface. To hold batch request > during the asynchronous preparation, the CL introduce refcounted hepler class, > which manages life time of batch request configurator. > > BUG=451917 > TEST=DriveUploaderTest > > Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0 > Cr-Commit-Position: refs/heads/master@{#329599} TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451917 Review URL: https://codereview.chromium.org/1135353004 Cr-Commit-Position: refs/heads/master@{#329610}
ryumiel
pushed a commit
that referenced
this issue
May 18, 2015
…patchset #1 id:1 of https://codereview.chromium.org/1135353004/) Reason for revert: The failure is not caused by the patch. MigrationSingleClientTest.AllTypesIndividually looks flaky. Original issue's description: > Revert of Drive: Let DriveUploader use batch request API. (patchset #7 id:120001 of https://codereview.chromium.org/1134633003/) > > Reason for revert: > MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN: > > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327 > > Original issue's description: > > Drive: Let DriveUploader use batch request API. > > > > The CL lets DriveUploader use batch request API. DriveUploader does asynchronous > > preparation before calling API on service interface. To hold batch request > > during the asynchronous preparation, the CL introduce refcounted hepler class, > > which manages life time of batch request configurator. > > > > BUG=451917 > > TEST=DriveUploaderTest > > > > Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0 > > Cr-Commit-Position: refs/heads/master@{#329599} > > TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=451917 > > Committed: https://crrev.com/e244812ae9a09d001f24f9aaaf780c80f976d790 > Cr-Commit-Position: refs/heads/master@{#329610} TBR=kinaba@chromium.org,tzik@chromium.org,sergeyv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451917 Review URL: https://codereview.chromium.org/1138883004 Cr-Commit-Position: refs/heads/master@{#329613}
ryumiel
pushed a commit
that referenced
this issue
May 18, 2015
StartSrpcServices will require using the service_runtime pointer, to set up the srpc_client pointer. So we cannot destroy the service_runtime at the same time. E.g., if I add a sleep() to induce the race, I get: ../../native_client/src/include/nacl_scoped_ptr.h:96: C *nacl::scoped_ptr<plugin::SelLdrLauncherChrome>::operator->() const [C = plugin::SelLdrLauncherChrome]: Assertion `ptr_ != __null' failed. Received signal 6 #0 0x7f687f4aef7e base::debug::StackTrace::StackTrace() #1 0x7f687f4aeabf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f6879dee340 <unknown> #3 0x7f6876504cc9 gsignal #4 0x7f68765080d8 abort #5 0x7f68764fdb86 <unknown> #6 0x7f68764fdc32 __assert_fail #7 0x7f688e2887f2 nacl::scoped_ptr<>::operator->() #8 0x7f688e288487 plugin::ServiceRuntime::SetupAppChannel() #9 0x7f688e28cb76 plugin::NaClSubprocess::StartSrpcServices() #10 0x7f688e281810 plugin::PnaclTranslateThread::DoLink() #11 0x7f688e27fe7d plugin::PnaclTranslateThread::DoLinkThread() #12 0x7f6879de6182 start_thread #13 0x7f68765c847d clone Should have checked this in previous refactoring: https://codereview.chromium.org/1128943003 BUG=473474 Review URL: https://codereview.chromium.org/1128373005 Cr-Commit-Position: refs/heads/master@{#329718}
ryumiel
pushed a commit
that referenced
this issue
May 20, 2015
#7 id:230001 of https://codereview.chromium.org/1140853002/) Reason for revert: We'll reland this CL with DiskCache migration code. Original issue's description: > ServiceWorker: Use SimpleCache for the script cache > > This CL migrates the backend of ServiceWorkerDiskCache from Default to > SimpleCache on all platforms. > > If old DiskCache images exist, > (1) DiskCache backend fails to open an pre-existing data due to incompatible > format (in both Default->SimpleCache and SimpleCache->Default cases), > (2) ServiceWorkerStorage wipes out all cached scripts and registrations via > DeleteAndStartOver, and > (3) navigation falls back to network. > > BUG=487482 > TEST=manual (use DiskCache and SimpleCache alternately and make sure the system can recover) > > Committed: https://crrev.com/a00e5be5a06e626de1b62cbfc7c350bef08647ea > Cr-Commit-Position: refs/heads/master@{#330274} TBR=michaeln@chromium.org BUG=487482 Review URL: https://codereview.chromium.org/1142193002 Cr-Commit-Position: refs/heads/master@{#330505}
ryumiel
pushed a commit
that referenced
this issue
May 20, 2015
…d:120001 of https://codereview.chromium.org/1126543009/) Reason for revert: broke http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android e.g. http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/1922 Original issue's description: > [Android] Refactor the native test wrappers. > > BUG=476410 > > Committed: https://crrev.com/581d25e509e4a2b1e8927c6d8accc0c90ea86090 > Cr-Commit-Position: refs/heads/master@{#330531} TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,perezju@chromium.org,tedchoc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476410 Review URL: https://codereview.chromium.org/1138993009 Cr-Commit-Position: refs/heads/master@{#330591}
ltilve
pushed a commit
that referenced
this issue
Sep 14, 2015
…(Sub)TextureCHROMIUM. (patchset #10 id:200001 of https://codereview.chromium.org/1275773003/ ) Reason for revert: Linux AMD GPU FYI bot has a broken gl_tests, likely because of this patch. http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/41273 [ RUN ] GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.Basic/2 Received signal 11 SEGV_MAPERR 000000000045 #0 0x000000492795 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7ff52630acb0 <unknown> #2 0x7ff5232a858c <unknown> #3 0x7ff5230a247c <unknown> #4 0x7ff5230a33ae <unknown> #5 0x7ff5227e8585 <unknown> #6 0x7ff5227e9b0a <unknown> #7 0x7ff522bf75c3 <unknown> #8 0x0000004f7ba4 gfx::GLApiBase::glCopyTexImage2DFn() #9 0x000000596ac1 (anonymous namespace)::DoCopyTexImage2D() #10 0x0000005968c4 gpu::CopyTextureCHROMIUMResourceManager::DoCopyTexture() Original issue's description: > gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. > > It makes it possible to optimize WebGL. > > TEST=gl_tests GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.* > BUG=517548 > > Committed: https://crrev.com/fa25f0e5786527e63c6ff9aeda77da3bd7456ee3 > Cr-Commit-Position: refs/heads/master@{#347354} TBR=piman@chromium.org,sievers@chromium.org,kbr@chromium.org,zmo@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517548,528374 Review URL: https://codereview.chromium.org/1304103005 Cr-Commit-Position: refs/heads/master@{#347465}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$ ./out/Release/unit_tests --single-process --gtest_filter=BrowserWindowControllerTest*
[ RUN ] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque
2015-04-21 16:10:45.261 unit_tests[49694:1591922] -[SidebarController view]: unrecognized selector sent to instance 0x7ff88e855b30
[49694:1299:0421/161045:79539930151365:FATAL:chrome_browser_application_mac.mm(159)] Someone is trying to raise an exception! NSInvalidArgumentException reason -[SidebarController view]: unrecognized selector sent to instance 0x7ff88e855b30
[11/17] BrowserWindowControllerTest.TestResizeViewsWithBookmarkBar (171 ms)
[12/17] BrowserWindowControllerTest.BookmarkBarIsSameWidth (79 ms)
[13/17] BrowserWindowControllerTest.TestTopRightForBubble (70 ms)
[14/17] BrowserWindowControllerTest.TestZoomFrame (116 ms)
[15/17] BrowserWindowControllerTest.TestFindBarOnTop (84 ms)
[16/17] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque (CRASHED)
Note: Google Test filter = BrowserWindowControllerTest.BookmarkBarHitTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserWindowControllerTest
[ RUN ] BrowserWindowControllerTest.BookmarkBarHitTest
[ OK ] BrowserWindowControllerTest.BookmarkBarHitTest (150 ms)
[----------] 1 test from BrowserWindowControllerTest (151 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (151 ms total)
[ PASSED ] 1 test.
[17/17] BrowserWindowControllerTest.BookmarkBarHitTest (150 ms)
1 test crashed:
BrowserWindowControllerTest.TestSplitViewsAreNotOpaque
Tests took 2 seconds.
The text was updated successfully, but these errors were encountered: