Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidebar_api should be in side of extension namespace. #3

Closed
ryumiel opened this issue Apr 16, 2015 · 1 comment
Closed

sidebar_api should be in side of extension namespace. #3

ryumiel opened this issue Apr 16, 2015 · 1 comment

Comments

@ryumiel
Copy link
Collaborator

ryumiel commented Apr 16, 2015

No description provided.

ryumiel pushed a commit that referenced this issue Apr 20, 2015
@johnmellor
Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (pa…
c29d5c5 
…tchset #1 id:1 of https://codereview.chromium.org/1085073002/)

Reason for revert:
Still very flaky on Win Nvidia:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view

Original issue's description:
> Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/)
>
> Reason for revert:
> kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues.  I'll try reverting it, and keep an eye on it.
>
> Original issue's description:
> > Disable WebGL conformance test on Win8/NVIDIA
> >
> > The test:
> > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view
> >
> > Has been timing out on and off for as long as we have records.
> >
> > BUG=459265
> > NOPRESUBMIT=True
> >
> > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d
> > Cr-Commit-Position: refs/heads/master@{#316872}
>
> TBR=zmo@chromium.org,ccameron@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459265
>
> Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702
> Cr-Commit-Position: refs/heads/master@{#325142}

TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459265

Review URL: https://codereview.chromium.org/1082203004

Cr-Commit-Position: refs/heads/master@{#325435}
ryumiel pushed a commit that referenced this issue Apr 20, 2015
Revert of Make a mojo:apptests GN meta-target, add apptests. (patchset …
69bc247 
…#3 id:60001 of https://codereview.chromium.org/1050233005/)

Reason for revert:
Caused compile failures (many errors, one example below) on Mac GN bot:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/7019/steps/compile/logs/stdio

gen/mojo/services/html_viewer/blink_resource_map.h:37:58:error: no newline at end of file [-Werror,-Wnewline-eof]
#endif // MOJO_SERVICES_HTML_VIEWER_BLINK_RESOURCE_MAP_H_

Original issue's description:
> Make a mojo:apptests GN meta-target, add apptests.
>
> Add an apptest meta-target in mojo/BUILD.gn.
> Move the apptests targets specified in src/BUILD.gn.
> Add the remaining apptest targets (clipboard, VM, WM).
>
> Was limited to release, allow debug, but exclude component.
> See gn_debug compile error from including component build in PS2:
>   FAILED: /b/build/slave/linux_chromium_gn/build/src/buildtools/linux64/gn --root=/b/build/slave/linux_chromium_gn/build/src -q gen //out/Debug/
>   ERROR at //mojo/shell/BUILD.gn:13:1: Assertion failed.
>   assert(!is_component_build)
>
> BUG=NONE
> TEST=Building mojo:apptests builds all local apptest binaries (on dbg too!).
> R=sky@chromium.org
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/16b112790f541670d5f2ab97dfa70c8b89b44b1f
> Cr-Commit-Position: refs/heads/master@{#325570}

TBR=sky@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/1093763002

Cr-Commit-Position: refs/heads/master@{#325575}
ryumiel pushed a commit that referenced this issue Apr 20, 2015
Revert of [Webapp Refactor] Remove remoting.SessionConnector. (patchset
cb655c2 
#3 id:60001 of https://codereview.chromium.org/1047413006/)

Reason for revert:
Bad merge with a previous version that will cause compilation failure.

Original issue's description:
> [Webapp Refactor] Remove remoting.SessionConnector.
>
> remoting.SessionConnector is currently responsible for creating
> the plugin, the signal strategy and the clientSession.  It also
> magically disposes the plugin when the clientSession finishes.
>
> However, the session is not exposed to the caller elsewhere, which makes
> it hard for the caller to dispose of the session before it is connected,
> e.g. Cancel a PIN entry.
>
> It is currently a stateful object that keeps track of the host,
> credentials provider, strategy of the created session, which is redundant.
>
> This CL
> 1. Offloads the creation of the clientSession to the
>    remoting.ClientSessionFactory.  It also allow the caller to configure
>    a clientSession prior to connecting.  The remoting.ClientSessionFactory
>    is essentially stateless except for a few predefined ClientSession
>    construction parameters.
> 2. Allow the caller to have a different instance of
>    ClientSession.EventHandler for each instance ClientSession created.
> 3. Revives remoting.MockClientPlugin and uses it for remoting.ClientSessionFactory
>    unittests.
>
> Ownership graph before:
> Activity -> SessionConenctor -> ClientSession
>
> Ownership graph after:
> Activity -> ClientSession
>
> BUG=477522
> TEST=All browser tests passed on
> https://chromium-swarm.appspot.com/user/tasks?sort=created_ts&state=all&limit=10&task_name=chromoting_integration_tests
>
> Committed: https://crrev.com/4c69287fc3e0ad6663ab98f02ef57c570f8992e3
> Cr-Commit-Position: refs/heads/master@{#325745}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477522

Review URL: https://codereview.chromium.org/1096883002

Cr-Commit-Position: refs/heads/master@{#325748}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
Revert of Roll WebGL 0c2bcf..66dc43. (patchset #3 id:40001 of https:/…
0d59c53 
…/codereview.chromium.org/1080543003/)

Reason for revert:
It looks like this is causing failures on some bots.

Original issue's description:
> Roll WebGL 0c2bcf..66dc43.
>
> Rolling to include test optimization.
>
> I've also disabled some new failing tests and logged bugs for
> those issues.
>
> BUG=459265, 478570, 478572
>
> Committed: https://crrev.com/e3605a084f02077cbea6decba8995b4945dcd169
> Cr-Commit-Position: refs/heads/master@{#325981}

TBR=bajones@chromium.org,zmo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459265, 478570, 478572

Review URL: https://codereview.chromium.org/1083783003

Cr-Commit-Position: refs/heads/master@{#326031}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
Revert of VideoCapture: add support for GpuMemoryBuffer allocation an…
df9c7fd 
…d lifetime mgmt in VideoCaptureBufferPool (patchset #7 id:480001 of https://codereview.chromium.org/1064963002/)

Reason for revert:
The reason for reverting is: Speculatively revert to address Android Tests (dbg) content_unittests failure:

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27395

content_unittests content_unittests
failures:
VideoCaptureBufferPoolTest.BufferPool/2
GpuMemoryBufferFactoryTests/GpuMemoryBufferFactoryTest.CreateAndDestroy/1
VideoCaptureBufferPoolTest.BufferPool/0
VideoCaptureBufferPoolTest.BufferPool/1

[ RUN      ] VideoCaptureBufferPoolTest.BufferPool/0
[FATAL:browser_gpu_memory_buffer_manager.cc(56)] Check failed: !g_gpu_memory_buffer_manager.
#00 0x764081d3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fdf1d3
#1 0x75cf95c3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x008d05c3
#2 0x75a3c697 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00613697
#3 0x75f8d1fb /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b641fb
#4 0x75f8d35b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b6435b
#5 0x75f8d3e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b643e3
#6 0x75f8d5e3 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b645e3
#7 0x75f8c3c7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b633c7
#8 0x75f49bb7 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b20bb7
#9 0x75f41c8b /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00b18c8b
#10 0x75736087 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x0030d087
#11 0x763de291 /data/app-lib/org.chromium.native_test-1/libcontent_unittests.so+0x00fb5291
#12 0x41503bcf /system/lib/libdvm.so+0x0001dbcf
#13 0x41534125 /system/lib/libdvm.so+0x0004e125
#14 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3
#15 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3
#16 0x4151163b /system/lib/libdvm.so+0x0002b63b
#17 0x41546863 /system/lib/libdvm.so+0x00060863
#18 0x4154e7c5 /system/lib/libdvm.so+0x000687c5
#19 0x4150cfe3 /system/lib/libdvm.so+0x00026fe3
#20 0x41513fa3 /system/lib/libdvm.so+0x0002dfa3
#21 0x4151163b /system/lib/libdvm.so+0x0002b63b
#22 0x4154657f /system/lib/libdvm.so+0x0006057f
#23 0x4152fd0d /system/lib/libdvm.so+0x00049d0d
#24 0x401a82b3 /system/lib/libandroid_runtime.so+0x0004d2b3
#25 0x401a8fd9 /system/lib/libandroid_runtime.so+0x0004dfd9
#26 0x4006b05d /system/bin/app_process+0x0000105d
#27 0x400a234b /system/lib/libc.so+0x0000e34b

This CL is the most suspect in the blame-list because it touches the VideoCaptureBufferPool.

Original issue's description:
> VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool & relatives
>
> - This CL adds support for GpuMemoryBufferTracker in
> addition to the existing SharedMemTracker.
>
> - A GpuMemoryBufferTracker owns a GpuMemoryBuffer,
> which can only be accessed byte-wise between Map() and
> Unmap().
>
> - For that reason, instead of making a VCBP::Tracker
> directly accessible via |void* data| and |size|, a
> BufferHandle abstraction is introduced.
>
> - VideoCaptureDeviceClient then defines its own
> AutoReleaseBuffer in terms of this new BufferHandle.
> This BufferHandle is supposed to stay Map()ed and
> ready to use for the duration of its lifetime.
>
> Summing up:
>  * VideoCaptureBufferPool has a pool of Trackers,
>  * from the VCBP we can get a BufferHandle per |buffer_id|,
>  * from a BufferHandle we can obtain data(), valid
>  and Map()ed as long as the BufferHandle itself exists.
>
> - VideoCaptureDevice::ReserveOutputBuffer() changes to
> return a scoped_ptr<Buffer> ISO a scoped_refptr.
>
> - Added VideoCaptureDevice::OnIncomingCapturedBuffer()
> to pass directly a Buffer with the capture contents.
>
> - video_capture_texture_wrapper.{cc,h} is removed and
> its contents are merged into VideoCaptureDeviceClient.
>
> - FakeVideoCaptureDevice learns how to produce
> GpuMemoryBuffers. Also, PIXEL_FORMAT_GPUMEMORYBUFFER
> is added.
>
> Summing up, VCDClient accepts:
>  * memory backed buffers (the usual)
>  * texture-backed buffers
>  * GMB-backed buffers (these are wrapped into a Texture
>   VideoFrame indistinguishable from the previous case)
>
> - VideoCaptureTextureWrapper files are gone and
> its contents folded into VideoCaptureDeviceClient.
>
> - Unittests are updated, and so is FakeVideoCaptureDevice.
>
> BUG=440843
>
> Committed: https://crrev.com/abeb15fa955c570cd481accb04c2a677eb2865a9
> Cr-Commit-Position: refs/heads/master@{#326171}

TBR=miu@chromium.org,emircan@chromium.org,avi@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440843

Review URL: https://codereview.chromium.org/1090273006

Cr-Commit-Position: refs/heads/master@{#326250}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
Revert of Add browser test for RestoreOnStartup[URLs] on Chrome OS (p…
8de0316 
…atchset #1 id:1 of https://codereview.chromium.org/1099063003/)

Reason for revert:
Speculatively revert to address Linux ChromiumOS Tests browser_tests failure:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1742

browser_tests
RestoreOnStartupTestChromeOS.PRE_LogInAndVerify 596 disabled 10 flaky failed 2
failures:
RestoreOnStartupTestChromeOS.LogInAndVerify
RestoreOnStartupTestChromeOS.PRE_LogInAndVerify

[385/509] RestoreOnStartupTestChromeOS.LogInAndVerify (SKIPPED)
[ RUN      ] RestoreOnStartupTestChromeOS.PRE_LogInAndVerify

[ FATAL ] ../../testing/gtest/include/gtest/gtest.h:1849:: Condition parameter_ != NULL failed. GetParam() can only be called inside a value-parameterized test -- did you intend to write TEST_P instead of TEST_F?
Received signal 6
#0 0x7ff3af22e6de base::debug::StackTrace::StackTrace()
#1 0x7ff3af22e21f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7ff3abc5dcb0 <unknown>
#3 0x7ff3a78320d5 gsignal
#4 0x7ff3a783583b abort
#5 0x00000074f9d9 testing::internal::posix::Abort()
#6 0x0000024055b0 testing::internal::GTestLog::~GTestLog()
#7 0x0000007477b3 testing::WithParamInterface<>::GetParam()
#8 0x0000012ecb31 policy::LoginPolicyTestBase::LoginPolicyTestBase()
#9 0x0000012fc025 policy::RestoreOnStartupTestChromeOS::RestoreOnStartupTestChromeOS()
#10 0x0000012fd18c policy::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test::RestoreOnStartupTestChromeOS_PRE_LogInAndVerify_Test()
#11 0x0000012fd117 testing::internal::TestFactoryImpl<>::CreateTest()
#12 0x0000007009ca _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_
#13 0x00000241ab2e testing::internal::HandleExceptionsInMethodIfSupported<>()
#14 0x000002410383 testing::TestInfo::Run()
#15 0x00000241094a testing::TestCase::Run()
#16 0x000002415ccc testing::internal::UnitTestImpl::RunAllTests()
#17 0x00000242c01a testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#18 0x00000241bf4e testing::internal::HandleExceptionsInMethodIfSupported<>()
#19 0x00000241596f testing::UnitTest::Run()
#20 0x0000022d95e1 RUN_ALL_TESTS()
#21 0x0000022d8647 base::TestSuite::Run()
#22 0x0000010d2b72 ChromeBrowserTestSuiteRunner::RunTestSuite()
#23 0x00000224de78 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#24 0x000004c38ed5 content::LaunchTests()
#25 0x00000224ddb9 LaunchChromeTests()
#26 0x0000010d2ad8 main
#27 0x7ff3a781d76d __libc_start_main
#28 0x000000672fe9 <unknown>
  r8: 00007ff3a51dc8c0  r9: 00007ff3a51dc8c0 r10: 0000000000000008 r11: 0000000000000202
 r12: 0000000000672fc0 r13: 00007fffdd71f330 r14: 0000000000000000 r15: 0000000000000000
  di: 0000000000005662  si: 0000000000005662  bp: 00007fffdd71e270  bx: 0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007fffdd71e138
  ip: 00007ff3a78320d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000

Original issue's description:
> Add browser test for RestoreOnStartup[URLs] on Chrome OS
>
> Ladies and gentlemen, this CL brings you the long-awaited end-to-end
> browser test for RRestoreOnStartup and RestoreOnStartupURLs, at least
> on Chrome OS.
>
> BUG=477145
> TEST=New browser test
>
> Committed: https://crrev.com/641bb06057cf18e518a96edaadaae42411341905
> Cr-Commit-Position: refs/heads/master@{#326261}

TBR=mnissler@chromium.org,bartfab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477145

Review URL: https://codereview.chromium.org/1103493003

Cr-Commit-Position: refs/heads/master@{#326272}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
@jbudorick
Revert of [Android] Convert RestartAdbd to DeviceUtils. (patchset #3 …
b209978 
…id:40001 of https://codereview.chromium.org/1100473004/)

Reason for revert:
all perf bots are purple

Original issue's description:
> [Android] Convert RestartAdbd to DeviceUtils.
>
> BUG=267773
>
> Committed: https://crrev.com/598af7c6bd830d6da9182d485842f7ca4e51a6b4
> Cr-Commit-Position: refs/heads/master@{#326304}

TBR=perezju@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/1104543003

Cr-Commit-Position: refs/heads/master@{#326357}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
Revert of Revert of Revert of Disable WebGL conformance test on Win8/…
6e99cf8 
…NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1082203004/)

Reason for revert:
The windows test time has been cut in half and shouldn't time out anymore.

Original issue's description:
> Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1085073002/)
>
> Reason for revert:
> Still very flaky on Win Nvidia:
>
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view
>
> Original issue's description:
> > Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/)
> >
> > Reason for revert:
> > kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues.  I'll try reverting it, and keep an eye on it.
> >
> > Original issue's description:
> > > Disable WebGL conformance test on Win8/NVIDIA
> > >
> > > The test:
> > > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view
> > >
> > > Has been timing out on and off for as long as we have records.
> > >
> > > BUG=459265
> > >
> > > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d
> > > Cr-Commit-Position: refs/heads/master@{#316872}
> >
> > TBR=zmo@chromium.org,ccameron@chromium.org
> > BUG=459265
> >
> > Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702
> > Cr-Commit-Position: refs/heads/master@{#325142}
>
> TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org
> BUG=459265
>
> Committed: https://crrev.com/c29d5c5f8d7ae90012a3d6bd42218b860cb53558
> Cr-Commit-Position: refs/heads/master@{#325435}

TBR=zmo@chromium.org,ccameron@chromium.org,johnme@chromium.org
BUG=459265

Review URL: https://codereview.chromium.org/1099203003

Cr-Commit-Position: refs/heads/master@{#326400}
ryumiel pushed a commit that referenced this issue Apr 28, 2015
@yoshikig
[Notification] fix a bug that "update" overrides "add" change
6f23046 
While the notification list is opened (it means when ChangeQueue is active), if an "add" change (change #1) and an "update" change (change #3) come in continuously, the change #2 overrides the previous change #1 then the "add" change #1 is gone. Hence, the added notification is never added. This patch fixes this bug.

BUG=477993

Review URL: https://codereview.chromium.org/1094823002

Cr-Commit-Position: refs/heads/master@{#326510}
ryumiel pushed a commit that referenced this issue May 7, 2015
@xhwang-chromium
Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunne…
84a3918 
…rHandle (patchset #3 id:40001 of https://codereview.chromium.org/1108773002/)

Reason for revert:
see https://code.google.com/p/chromium/issues/detail?id=481632

Original issue's description:
> Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media.
>
> MessageLoopProxy is deprecated.
> This basically does a search and replace:
>
> MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().
>
> BUG=391045
>
> Committed: https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f
> Cr-Commit-Position: refs/heads/master@{#327075}

TBR=anujk.sharma@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=391045

Review URL: https://codereview.chromium.org/1105163004

Cr-Commit-Position: refs/heads/master@{#327142}
ryumiel pushed a commit that referenced this issue May 7, 2015
@nedn
[Telemetry] Remove support for automatic record creation in smoothnes…
eb2eca9 
…s controller.

Add logic to make sure that page sets paired with
smoothness/repaint only have interaction records with same label & they have repeatable flags enabled.

To make sure that this doesn't crash any smoothness
benchmarks, I modified benchmark_smoke_unittest to run all
smoothness benchmarks (including ones that only support
android) in patch #3. To validate the test runs, see
telemetry_perf_unittest's result in patch #5

smoothness.key_silk_cases: https://codereview.chromium.org/1111543002/

smoothness.polymer:
https://codereview.chromium.org/1060583012

BUG=444701,444703

Review URL: https://codereview.chromium.org/1104573002

Cr-Commit-Position: refs/heads/master@{#327186}
ryumiel pushed a commit that referenced this issue May 7, 2015
Revert of [Android] Remove more uses of android_commands from build/a…
6a02a61 
…ndroid/pylib. (patchset #3 id:40001 of https://codereview.chromium.org/1105323002/)

Reason for revert:
Causes HostDriven_SigninTest.testManagedSignin to fail, and hence prevents rolls into Android downstream repository

BUG=482406

Original issue's description:
> [Android] Remove more uses of android_commands from build/android/pylib.
>
> BUG=267773
>
> Committed: https://crrev.com/166b709fc6c8fefad72520473850ce15ffe45898
> Cr-Commit-Position: refs/heads/master@{#327402}

TBR=perezju@chromium.org,mikecase@chromium.org,rnephew@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/1116493003

Cr-Commit-Position: refs/heads/master@{#327469}
ryumiel pushed a commit that referenced this issue May 7, 2015
@rickyz
Revert of Add a GN flag for the Windows multi-dll build. (patchset #3 …
e203954 
…id:40001 of https://codereview.chromium.org/1120803003/)

Reason for revert:
May have caused some link errors on windows: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/814

Original issue's description:
> Add a GN flag for the Windows multi-dll build.
>
> The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing.
>
> R=scottmg@chromium.org
> TBR=ddorwin@chromium.org (widevine)
>
> Committed: https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3
> Cr-Commit-Position: refs/heads/master@{#327854}

TBR=scottmg@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1117063004

Cr-Commit-Position: refs/heads/master@{#327861}
ryumiel pushed a commit that referenced this issue May 7, 2015
@danbeam
Revert of Roll Clang 233105:234521 (patchset #3 id:40001 of https://c…
0bdeb5d 
…odereview.chromium.org/1115633003/)

Reason for revert:
May have caused a __TEXT size change on mac clobber builders running sizes:
http://build.chromium.org/p/chromium/builders/Mac/builds/1588

This is a speculative revert because we're not totally sure this is the cause.  Promise to reinstate (re-revert) if nothing gets fixed.

Original issue's description:
> Roll Clang 233105:234521
>
> BUG=483026
>
> Committed: https://crrev.com/10a866ab06ab72fa161328cb922052876c49c3a8
> Cr-Commit-Position: refs/heads/master@{#327801}

TBR=thakis@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483026

Review URL: https://codereview.chromium.org/1118353002

Cr-Commit-Position: refs/heads/master@{#327933}
ryumiel pushed a commit that referenced this issue May 7, 2015
Revert of Adds thunks for getting platform handles (patchset #3 id:40…
781e65d 
…001 of https://codereview.chromium.org/1113393002/)

Reason for revert:
Broke build.

Original issue's description:
> Adds thunks for getting platform handles
>
> BUG=none
> TEST=none
> R=viettrungluu@chromium.org
>
> Committed: https://crrev.com/8f7386b022c30b46325f8c67ba4d04d33606103b
> Cr-Commit-Position: refs/heads/master@{#327937}

TBR=viettrungluu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1123453003

Cr-Commit-Position: refs/heads/master@{#327945}
ryumiel pushed a commit that referenced this issue May 7, 2015
@danbeam
Revert of Adds resource_provider::ResourceProvider (patchset #3 id:40…
51c7082 
…001 of https://codereview.chromium.org/1108403008/)

Reason for revert:
Broke compile:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/853/steps/compile/logs/stdio#error1

Original issue's description:
> Adds resource_provider::ResourceProvider
>
> It's used to fetch resources for mojo apps.
>
> R=ben@chromium.org
>
> Committed: https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0
> Cr-Commit-Position: refs/heads/master@{#328014}

TBR=ben@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1113223003

Cr-Commit-Position: refs/heads/master@{#328021}
ryumiel pushed a commit that referenced this issue May 7, 2015
Revert of [Download Notification] Add cancel-button and download-remo…
a8d1b6a 
…ved tests (patchset #2 id:60001 of https://codereview.chromium.org/1086863004/)

Reason for revert:
Breaks the memory sanitizer on CrOS:

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/981/steps/browser_tests/logs/DownloadNotificationTest.DownloadRemoved

=================================================================
==2998==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 416 byte(s) in 1 object(s) allocated from:
    #0 0x5b583b in operator new(unsigned long) (/tmp/run_tha_testDL6ABE/out/Release/browser_tests+0x5b583b)
    #1 0x37f8977 in DownloadNotificationItem::DownloadNotificationItem(content::DownloadItem*, Profile*, DownloadNotificationItem::Delegate*) chrome/browser/download/notification/download_notification_item.cc:86:23
    #2 0x3443434 in DownloadNotificationManager::OnNewDownloadReady(content::DownloadItem*) chrome/browser/download/notification/download_notification_manager.cc:45:11
    #3 0x2e8993d in DownloadUIController::OnDownloadUpdated(content::DownloadManager*, content::DownloadItem*) chrome/browser/download/download_ui_controller.cc:146:3
    #4 0x765f4df in content::DownloadItemImpl::UpdateObservers() content/browser/download/download_item_impl.cc:301:3
    #5 0x7669506 in content::DownloadItemImpl::OnDownloadRenamedToIntermediateName(content::DownloadInterruptReason, base::FilePath const&) content/browser/download/download_item_impl.cc:1263:5
    #6 0x7cf365c in Run base/callback.h:396:12
    #7 0x7cf365c in MakeItSo base/bind_internal.h:293
    #8 0x7cf365c in base::internal::Invoker\u003CIndexSequence\u003C0ul, 1ul>, base::internal::BindState\u003Cbase::Callback\u003Cvoid (content::DownloadInterruptReason, base::FilePath const&)>, void (content::DownloadInterruptReason, base::FilePath const&), base::internal::TypeList\u003Ccontent::DownloadInterruptReason, base::FilePath> >, base::internal::TypeList\u003Cbase::internal::UnwrapTraits\u003Ccontent::DownloadInterruptReason>, base::internal::UnwrapTraits\u003Cbase::FilePath> >, base::internal::InvokeHelper\u003Cfalse, void, base::Callback\u003Cvoid (content::DownloadInterruptReason, base::FilePath const&)>, base::internal::TypeList\u003Ccontent::DownloadInterruptReason const&, base::FilePath const&> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:343
    #9 0x3f18cc6 in Run base/callback.h:396:12
    #10 0x3f18cc6 in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    #11 0x3e336f7 in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:444:3
    #12 0x3e340df in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) base/message_loop/message_loop.cc:454:5
    #13 0x3e34947 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:566:13
    #14 0x3f12256 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7
    #15 0x3f12256 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109
    #16 0x7f0a333dbd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539
    #17 0x7f0a333dbd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075

Original issue's description:
> [Download Notification] Add cancel-button and download-removed tests
>
> This patch adds the following tests:
> - Clicking cancel-button while download is in progress
> - Clicking cancel-button after download is finished
> - Download is removed externally
>
> BUG=480489
> TEST=manually tested
>
> Committed: https://crrev.com/24185c2b385071c1ba007b3cc16f52692dd78d02
> Cr-Commit-Position: refs/heads/master@{#328059}

TBR=asanka@chromium.org,yoshiki@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480489

Review URL: https://codereview.chromium.org/1116923004

Cr-Commit-Position: refs/heads/master@{#328105}
ryumiel pushed a commit that referenced this issue May 7, 2015
@danbeam
Revert of Change the callsites of InterfacePtr<> methods which direct…
eec7904 
…ly deal with message pipe handles. (patchset #3 id:40001 of https://codereview.chromium.org/1120753004/)

Reason for revert:
This might've broke Mac 10.9's IPC message handling(?):
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/5606

Lots of errors like this:
[361:34051:0504/184612:WARNING:ipc_mojo_bootstrap.cc(214)] Detected error on Mojo bootstrap channel.
[361:34051:0504/184612:WARNING:ipc_message_attachment_set.cc(37)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1

Original issue's description:
> Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles.
>
> Because those methods are going to be removed.
>
> BUG=None
>
> Committed: https://crrev.com/99f65895acf2086af0755b9ea865d6ded4baecd6
> Cr-Commit-Position: refs/heads/master@{#328232}

TBR=jam@chromium.org,rockot@chromium.org,yzshen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1124553004

Cr-Commit-Position: refs/heads/master@{#328264}
ryumiel pushed a commit that referenced this issue May 7, 2015
@danbeam
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to…
861e7ec 
… SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/)

Reason for revert:
Final stop on the revert train!

net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this?
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

Here's a log of the break:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29

Original issue's description:
> Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
> so that all provider subclasses can have their state verified.
>
> Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
> Cr-Commit-Position: refs/heads/master@{#328154}

TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1119803006

Cr-Commit-Position: refs/heads/master@{#328271}
ryumiel pushed a commit that referenced this issue May 7, 2015
@jeisinger
Revert of [mojo] Replace MessageLoopProxy usage with ThreadTaskRunner…
b77bd75 
…Handle (patchset #3 id:40001 of https://codereview.chromium.org/1118473002/)

Reason for revert:
breaks compilation on win gn
https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6922

Original issue's description:
> Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in mojo module.
>
> MessageLoopProxy is deprecated.
> This basically does a search and replace:
>
> MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().
>
> BUG=391045
>
> Committed: https://crrev.com/332a1b2b1d5635199d5ed453f5f9586b2e030b64
> Cr-Commit-Position: refs/heads/master@{#328311}

TBR=sky@chromium.org,anujk.sharma@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=391045

Review URL: https://codereview.chromium.org/1125913002

Cr-Commit-Position: refs/heads/master@{#328314}
ryumiel pushed a commit that referenced this issue May 7, 2015
@lgarron
Change connection info strings (e.g. SHA-1 cert warnings) to be more
46bd40a 
clear to developers.

This commit includes 5 changes that make OIB connection info strings
more clear to developers (and advanced users). Since it has become
impractical to target "normal" users with these strings, the focus is on
using exact terminology instead of "friendly" alternatives. This should
help developers to understand the page's issues at a glance:

https://docs.google.com/document/d/1YgavRvC7_6PoOYHjUuKQL1Mlc718z7F1AnTNGrM92W4/edit#heading=h.kldzb7b775ri

Changes in this commit:

1. The identity section explicitly mentions when an error was caused by
   SHA-1 in the certificate chain, instead of referencing "outdated
   security settings" (there are no such settings apart from SHA-1
   signatures right now). (https://crbug.com/437466)

2. Mentions of "public audit records" have been replaced with mentions
   of "Certificate Transparency". The phrase "Public audit records" was
   hinging at the implications of CT, but a full understanding the
   string requires knowledge of CT.
   Also, the mention of CT has been split into a separate sentence. The
   presence of "but" had a strong but incorrect implication that this
   affects the lock icon (which will not be the case for non-EV sites in
   the near future).

3. The phrase "modern cryptography" is now "modern cipher suite" in
   order to distinguish the kind of cryptography in question. (Similarly
   for "obsolete cryptography".) This technically doesn't mention the
   protocol; however, the main problem usually lies with the cipher
   suite rather than the protocol, and all the cipher suites we
   currently consider good require TLS 1.2 (or, say, QUIC) as a
   prerequisite.

4. Mixed content message: Instead of "However", the sentence now starts
   with "Further" so that it still makes sense when the protocol/cipher
   suite is obsolete (https://crbug.com/434617).

5. The "SHA1 for message authentication" string (for ciphers with a MAC)
   now displays SHA1 as HMAC-SHA1, to be more suggestive that this a
   different use of SHA-1 than for cert signatures. (Similarly for other
   TLS MACs.)

Design constraint: In order to make this change as simple as possible,
the code logic has not been touched. The string contents have been
changed, but all strings keep their identifiers and semantics. Also,
these changes are definitely meant as a band-aid. In the medium-long
term, the plan is to remove the connection tab from the OIB and offer
the information in DevTools. (However, we have yet to decide on a plan
to supplant it on mobile.)

Test pages:
#1: https://sha1.badssl.com/
#2:
  - DV, no SCT: https://garron.net/
  - DV, SCT: https://embed.ct.digicert.com/
  - EV, no SCT: https://www.mozilla.org/
  - EV, SCT: https://www.bankofamerica.com/
#3:
  - "modern": https://garron.net/
  - "obsolete": https://rc4.badssl.com/
#4: https://mixed.badssl.com/
#5: https://rc4.badssl.com/

Note that this commit roughly coincides with the reintroduction of
connection info on Android:
- https://crbug.com/425158#c41
- https://chromium.googlesource.com/chromium/src/+/f21c52aeafa701b18ed505347ee0e7a7d07e5d53
Android Chrome users haven't been able to access this information for
the last half year, and will see these new strings directly.

BUG=461045, 434617, 437466
TEST=Visit the test pages (listed above).

Review URL: https://codereview.chromium.org/1109283003

Cr-Commit-Position: refs/heads/master@{#328502}
@ryumiel ryumiel mentioned this issue May 8, 2015
Closed
ryumiel pushed a commit that referenced this issue May 11, 2015
@marcheu
Revert of Keep track of the displayed surface in BufferQueue (patchset …
a1a2f61 
…#3 id:40001 of https://codereview.chromium.org/1119793002/)

Reason for revert:
Seems to break VMtests on Chrome OS alex_freon, see https://code.google.com/p/chromium/issues/detail?id=484307

Original issue's description:
> Keep track of the displayed surface in BufferQueue
>
> PageFlipComplete() only signals that the first in flight buffer is
> currently displaying. During startup or resizes it is possible to
> have more than 1 in flight surfaces when PageFlipComplete() is
> called the first time.
>
> Previously we were incorrectly treating this case as if the first in
> flight surface was available for rendering causing us to mark the
> surface available for rendering. In turn it was possible to start
> rendering on the front buffer.
>
> This patch explicitly tracks the displayed surface such that we don't
> return it too early.
>
> BUG=481626
>
> Committed: https://crrev.com/d519bdd36636dc1528fd9862a991905364dac4e1
> Cr-Commit-Position: refs/heads/master@{#327954}

TBR=alexst@chromium.org,piman@chromium.org,danakj@chromium.org,dnicoara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=481626

Review URL: https://codereview.chromium.org/1128203006

Cr-Commit-Position: refs/heads/master@{#328703}
ryumiel pushed a commit that referenced this issue May 11, 2015
@GregTho
Revert of mini_installer: Change to use _countof rather than base's a…
4febac2 
…rraysize macro. (patchset #3 id:40001 of https://codereview.chromium.org/1126163003/)

Reason for revert:
Broke signing build.

Original issue's description:
> Replace mini_installer's use of arraysize macro with range-based for loops
> and/or _countof.
>
> * Remove the duplication in the decompress.h
>
> https://msdn.microsoft.com/en-us/library/ms175773.aspx
>
> This issue arised when doing https://codereview.chromium.org/1115993004/.
>
> BUG=None
> TEST=trybots
> R=grt@chromium.org
>
> Committed: https://crrev.com/016d71e2e048f0578e2c53c3f741755173ef8cb2
> Cr-Commit-Position: refs/heads/master@{#328623}

TBR=tfarina@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1133613002

Cr-Commit-Position: refs/heads/master@{#328753}
ryumiel pushed a commit that referenced this issue May 11, 2015
@ccameron-chromium
Revert of Mac: Ensure that web contents background matches theme (pat…
f76987d 
…chset #3 id:40001 of https://codereview.chromium.org/1124813002/)

Reason for revert:
BUG=485133
BUG=485426
BUG=484982

I have no idea how these bugs could be caused by this CL, but there enough of them for me to not wait to figure it out.

Original issue's description:
> Mac: Ensure that web contents background matches theme
>
> Have the TabContentsContainerView send the theme's background color down
> to the WebContentsViewCocoa. Make the RenderWidgetHostViewCocoa be transparent,
> so that the WebContentsViewCocoa which is always behind it shows.
>
> Simplify the computation of the blended background color for the
> TabContentsContainerView.
>
> Also fix a bug in TabContentsController where calls to [self view] in dealloc
> would cause the TabContentsContainerView to be lazily allocated (only to be
> immediately destroyed). This was causing as this allocate-while-being-destroyed
> arrangement was creating poorly defined states, which would now be tickled
> more because of the calls to SetBackgroundColor that were inserted.
>
> BUG=470669
>
> Committed: https://crrev.com/e8c43faf256fb877d783287b347f8beb38b7495a
> Cr-Commit-Position: refs/heads/master@{#328427}

TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=470669

Review URL: https://codereview.chromium.org/1131933002

Cr-Commit-Position: refs/heads/master@{#328764}
ryumiel pushed a commit that referenced this issue May 11, 2015
@irori
Revert of [Chromoting] Add GN build support for ar_sample_app target.…
fdf00f9 
… (patchset #3 id:40001 of https://codereview.chromium.org/1126393002/)

Reason for revert:
Broke Linux GN Clobber build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/49/steps/compile/logs/stdio

Original issue's description:
> [Chromoting] Add GN build support for ar_sample_app target.
>
> This adds GN build rules for the AppRemoting sample app.
> Some DesktopRemoting build rules were prettified as part of this
> process (to make the App- and Desktop- remoting build rules more
> similar).
>
> BUG=471916
>
> Committed: https://crrev.com/13a3ca1f8053b1b2d195b8f5f52b90e184287ea8
> Cr-Commit-Position: refs/heads/master@{#328871}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471916

Review URL: https://codereview.chromium.org/1135603003

Cr-Commit-Position: refs/heads/master@{#328902}
ryumiel pushed a commit that referenced this issue May 11, 2015
@jbauman2
Revert of Simplify accelerated paint and remove windows CanvasSkiaPai…
6dcbb58 
…nt (patchset #3 id:40001 of https://codereview.chromium.org/1133433002/)

Reason for revert:
Broke GN build

Original issue's description:
> Simplify accelerated paint and remove windows CanvasSkiaPaint
>
> We always draw window contents using a compositor, so we can remove the windows desktop aura code that handles GDI painting.
>
> Committed: https://crrev.com/036fd204f5aa384fc5b1d882262d02c115c34807
> Cr-Commit-Position: refs/heads/master@{#328906}

TBR=sky@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1125423003

Cr-Commit-Position: refs/heads/master@{#328907}
ryumiel pushed a commit that referenced this issue May 11, 2015
@nico
Revert of Evaluate declarativeContent API rules on add/remove (patchset
64b7887 
#3 id:40001 of https://codereview.chromium.org/1128323002/)

Reason for revert:
DeclarativeContentApiTest.Overview started to reliably fail on the Mac OS X 10.6 bot after this went in:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/2062
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/2063

../../chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc:134: Failure
Value of: page_action->GetIsVisible(tab_id)
  Actual: true
Expected: false

Original issue's description:
> Evaluate declarativeContent API rules on add/remove
>
> Fixes bug where rules were not being evaluated until tabs' WebContents
> were navigated.
>
> BUG=485172
>
> Committed: https://crrev.com/b6780cb55862276ac886d6acfc6193f885d93f2e
> Cr-Commit-Position: refs/heads/master@{#329048}

TBR=kalman@chromium.org,wittman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485172

Review URL: https://codereview.chromium.org/1130793004

Cr-Commit-Position: refs/heads/master@{#329053}
ryumiel pushed a commit that referenced this issue May 18, 2015
Reland Evaluate declarativeContent API rules on add/remove
95100b1 
Restore the second content::ExecuteScript(tab, std::string()) call in the Overview test, to avoid test breakage.

Original issue's description:
> Revert of Evaluate declarativeContent API rules on add/remove (patchset #3 id:40001 of https://codereview.chromium.org/1128323002/)
>
> Reason for revert:
> DeclarativeContentApiTest.Overview started to reliably fail on the Mac OS X 10.6 bot after this went in:
> http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/2062
> http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/2063
>
> ../../chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc:134: Failure
> Value of: page_action->GetIsVisible(tab_id)
>   Actual: true
> Expected: false
>
> Original issue's description:
> > Evaluate declarativeContent API rules on add/remove
> >
> > Fixes bug where rules were not being evaluated until tabs' WebContents
> > were navigated.
> >
> > BUG=485172
> >
> > Committed: https://crrev.com/b6780cb55862276ac886d6acfc6193f885d93f2e
> > Cr-Commit-Position: refs/heads/master@{#329048}
>
> TBR=kalman@chromium.org,wittman@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=485172
>
> Committed: https://crrev.com/64b78871a088973eb7dc4c36b19509a8526b5a71
> Cr-Commit-Position: refs/heads/master@{#329053}

TBR=kalman@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=485172

Review URL: https://codereview.chromium.org/1136953004

Cr-Commit-Position: refs/heads/master@{#329194}
ryumiel pushed a commit that referenced this issue May 18, 2015
Revert of Be explicit about forcing TouchSelectionController updates …
e63eab6 
…(patchset #2 id:20001 of https://codereview.chromium.org/1127383007/)

Reason for revert:
This has caused failures on the memory bots. e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179

Sample test output:
[ RUN      ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection
==6485== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f5bc93bb605 in ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound const&, ui::SelectionBound const&) ui/touch_selection/touch_selection_controller.cc:71:27
    #1 0x7f5bc922803a in ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool, gfx::RectF const&, bool) ui/touch_selection/touch_selection_controller_unittest.cc:147:5
    #2 0x7f5bc9278c8d in ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody() ui/touch_selection/touch_selection_controller_unittest.cc:946:3
    #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0
    #5 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #6 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #8 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #9 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #10 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #13 0x7f5bc92f85ee in Run base/callback.h:396:12
    #14 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #17 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #18 0x7f5bc9188f38 in _start ??:0:0

  Uninitialized value was created by a heap allocation
    #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0
    #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp() ui/touch_selection/touch_selection_controller_unittest.cc:65:23
    #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0
    #4 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #5 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #7 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #8 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #9 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #12 0x7f5bc92f85ee in Run base/callback.h:396:12
    #13 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #16 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605)
Exiting

Original issue's description:
> Be explicit about forcing TouchSelectionController updates
>
> Previously, cached values in the TouchSelectionController would be reset
> to force future selection updates. However, these cached values can
> actually be used outside of selection update calls, e.g., when force
> showing the selection from the current cached values. Instead of
> resetting the cached values, simply set a dirty bit that forces an
> update, avoiding issues when dealing with the reset values.
>
> BUG=393025
>
> Committed: https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83
> Cr-Commit-Position: refs/heads/master@{#329325}

TBR=mohsen@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=393025

Review URL: https://codereview.chromium.org/1139533006

Cr-Commit-Position: refs/heads/master@{#329352}
ryumiel pushed a commit that referenced this issue May 18, 2015
@davidben
Revert of Roll src/third_party/boringssl/src 68de407:de12d6c (patchset …
49f8b81 
…#3 id:40001 of https://codereview.chromium.org/1132443004/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/17339

Decent chance this will need to be re-uploaded manually, but let's see...

Original issue's description:
> Roll src/third_party/boringssl/src 68de407:de12d6c
>
> Summary of changes available at:
> https://boringssl.googlesource.com/boringssl/+log/68de407..de12d6c
>
> This also removes update_gypi_and_asm.py in favor of the script inside
> BoringSSL proper.
>
> BUG=none
>
> Committed: https://crrev.com/45248985036de1238c29d195b583797319a7020f
> Cr-Commit-Position: refs/heads/master@{#329500}

TBR=agl@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1128293004

Cr-Commit-Position: refs/heads/master@{#329504}
ryumiel pushed a commit that referenced this issue May 18, 2015
Revert of Allow user to manually fetch remote commands (patchset #3 i…
d7f2f2b 
…d:40001 of https://codereview.chromium.org/1106193003/)

Reason for revert:
crash occasionally on CrOS

Original issue's description:
> Allow user to manually fetch remote commands
>
> Currently remote commands fetch depends solely on invalidation, evaluate and
> possibly remove this after invalidation service is landed and tested.
>
> BUG=480982
>
> Committed: https://crrev.com/610f47342c8d725e239513ac17727a176d161495
> Cr-Commit-Position: refs/heads/master@{#327765}

TBR=bartfab@chromium.org,estade@chromium.org
BUG=480982,486672

Review URL: https://codereview.chromium.org/1132223003

Cr-Commit-Position: refs/heads/master@{#329660}
ryumiel pushed a commit that referenced this issue May 18, 2015
PNaCl: Hold subprocess_mu while doing StartSrpcServices.
7862c25 
StartSrpcServices will require using the service_runtime pointer,
to set up the srpc_client pointer. So we cannot destroy the
service_runtime at the same time.

E.g., if I add a sleep() to induce the race, I get:

../../native_client/src/include/nacl_scoped_ptr.h:96: C *nacl::scoped_ptr<plugin::SelLdrLauncherChrome>::operator->() const [C = plugin::SelLdrLauncherChrome]: Assertion `ptr_ != __null' failed.
Received signal 6
#0 0x7f687f4aef7e base::debug::StackTrace::StackTrace()
#1 0x7f687f4aeabf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f6879dee340 <unknown>
#3 0x7f6876504cc9 gsignal
#4 0x7f68765080d8 abort
#5 0x7f68764fdb86 <unknown>
#6 0x7f68764fdc32 __assert_fail
#7 0x7f688e2887f2 nacl::scoped_ptr<>::operator->()
#8 0x7f688e288487 plugin::ServiceRuntime::SetupAppChannel()
#9 0x7f688e28cb76 plugin::NaClSubprocess::StartSrpcServices()
#10 0x7f688e281810 plugin::PnaclTranslateThread::DoLink()
#11 0x7f688e27fe7d plugin::PnaclTranslateThread::DoLinkThread()
#12 0x7f6879de6182 start_thread
#13 0x7f68765c847d clone

Should have checked this in previous refactoring:
https://codereview.chromium.org/1128943003

BUG=473474

Review URL: https://codereview.chromium.org/1128373005

Cr-Commit-Position: refs/heads/master@{#329718}
ryumiel pushed a commit that referenced this issue May 18, 2015
Sync: Change Local IDs to GUID based to avoid ID collision
51f97d0 
This changes implementation of Directory::NextId() to no longer depend on
"next_id" counter stored in Sync DB. Even though there was a special precaution
to avoid potential collision of local IDs by fast forwarding next_id by a large
number on every save there are still a couple scenarios leading the the collision
between a local ID generated on a client and originator_client_item_id coming
from the server (which is basically a local ID of an item previously committed
to the server.

The new implementation of Directory::NextId() is based on base::GenerateGUID.
The following changes accompany the transition to the new ID format:
1) The next_id field is no longer needed in Directory::PersistedKernelInfo
2) The code that persists next_id is no longer needed.
3) Forcing the directory to save by marking it with KERNEL_SHARE_INFO_DIRTY
    flag right after loading it is no longer necessary. That was done primarily
    to increment next_id by a large value as a way to attempt this problem.
4) Fixing #3 revealed a bug in Directory::IncrementTransactionVersion that
    doesn't mark the directory with KERNEL_SHARE_INFO_DIRTY when incrementing
    a datatype's transaction version. That caused a number of bookmark tests
    to fail due to the transaction version check. Fixed it.
5) Changing local IDs to GUIDs had a subtle effect on some tests. For the
    types that don't support ordering, sorting of entries in ParentChildIndex
    defaults to ID comparison. Since generation of local IDs base on next_id
    followed a predictable pattern, some tests relied on order of items returned
    by ParentChildIndex. Switching to GUIDs disrupted the expected order
    (of entries that are unordered in their nature). To preserve the existing
    ordering pattern for unordered entries, I changed ParentChildIndex to
    default to META_HANDLE comparison.
6) Another test that failed due to the GUID transition was
    SyncableDirectoryTest.BookmarkTagTest. The test relied on a predefined,
    repeatable local ID which was no longer the case with the GUID generation.
    I found the test to be redundant. There is another tests that verifies
    the same functionality - unique bookmark tag generation algorithm.

For now the change leaves next_id in the database even though the field is
no longer used. I should probably file another bug to track its removal.

BUG=362467

Review URL: https://codereview.chromium.org/1136953013

Cr-Commit-Position: refs/heads/master@{#329946}
ryumiel pushed a commit that referenced this issue May 22, 2015
@anniesullie
Revert of [Telemetry] Disable auto issuing record for thread_times (p…
d8cf830 
…atchset #3 id:60001 of https://codereview.chromium.org/1140353003/)

Reason for revert:
Seems to have broken service_worker tests (http://crbug.com/490130)

Original issue's description:
> [Telemetry] Disable auto issuing record for thread_times
>
> BUG=444705
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed
> Cr-Commit-Position: refs/heads/master@{#330613}

TBR=eakuefner@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444705

Review URL: https://codereview.chromium.org/1151543002

Cr-Commit-Position: refs/heads/master@{#330728}
ryumiel pushed a commit that referenced this issue May 22, 2015
@LanWei22
Revert of Fix a crash when views::HWNDMessageHandler::HandleTouchMess…
187b7d3 
…age (patchset #3 id:80001 of https://codereview.chromium.org/1147583002/)

Reason for revert:
We reverted the CL which needs to be fixed by this one, so we need to revert it one as well. We will recommit it once we fully fix and test it.

Original issue's description:
> Fix a crash when views::HWNDMessageHandler::HandleTouchMessage.
>
> There is a crash when calling views::HWNDMessageHandler::HandleTouchMessage,
> because there are missing touch presses. Remove the CHECK for missing touch press,
> and ignore when this happens.
>
> BUG=316085, 488473
>
> Committed: https://crrev.com/41065dad044cd3bbd3c9bcc24e59eeae27a6c6a9
> Cr-Commit-Position: refs/heads/master@{#330751}

TBR=sadrul@chromium.org,ananta@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=316085, 488473

Review URL: https://codereview.chromium.org/1148143002

Cr-Commit-Position: refs/heads/master@{#330757}
ryumiel pushed a commit that referenced this issue May 22, 2015
Revert of Add SyncScheduler for scheduling CryptAuth enrollments and …
917821a 
…syncing devices. (patchset #3 id:80001 of https://codereview.chromium.org/1147563002/)

Reason for revert:
MSan and Valgrind failures (use-of-uninitialized memory).

Original issue's description:
> Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices.
>
> BUG=420315
> TEST=unit test
>
> Committed: https://crrev.com/27e044cfc5c2a43b6c575508aca64763bfa2deba
> Cr-Commit-Position: refs/heads/master@{#330713}

TBR=isherman@chromium.org,tengs@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420315

Review URL: https://codereview.chromium.org/1146193002

Cr-Commit-Position: refs/heads/master@{#330780}
@ltilve
Copy link
Owner

ltilve commented May 25, 2015

WONTFIX for browserAction branch

@ltilve ltilve closed this as completed May 25, 2015
@ltilve ltilve mentioned this issue Aug 3, 2015
Open
ltilve pushed a commit that referenced this issue Sep 14, 2015
@zmodem
Revert of Simulate turning on PluginPowerSaver via Finch (patchset #3 …
29a8430 
…id:80001 of https://codereview.chromium.org/1301373006/ )

Reason for revert:
This broke browser_tests in branding=Chrome builds, e.g. http://master.chrome.corp.google.com:8010/builders/mac64/builds/2523

Original issue's description:
> Simulate turning on PluginPowerSaver via Finch
>
> R=rkaplow@chromium.org
> BUG=478918
>
> Committed: https://crrev.com/d036a4f77d480588370d4c9f94647b2ecf80f1c9
> Cr-Commit-Position: refs/heads/master@{#347269}

TBR=rkaplow@chromium.org,kalman@chromium.org,dbeam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478918

Review URL: https://codereview.chromium.org/1314923008

Cr-Commit-Position: refs/heads/master@{#347442}
ltilve pushed a commit that referenced this issue Sep 14, 2015
@null77
Revert of gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy…
8ff8391 
…(Sub)TextureCHROMIUM. (patchset #10 id:200001 of https://codereview.chromium.org/1275773003/ )

Reason for revert:
Linux AMD GPU FYI bot has a broken gl_tests, likely because of this patch.

http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/41273

[ RUN      ] GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.Basic/2
Received signal 11 SEGV_MAPERR 000000000045
#0 0x000000492795 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7ff52630acb0 <unknown>
#2 0x7ff5232a858c <unknown>
#3 0x7ff5230a247c <unknown>
#4 0x7ff5230a33ae <unknown>
#5 0x7ff5227e8585 <unknown>
#6 0x7ff5227e9b0a <unknown>
#7 0x7ff522bf75c3 <unknown>
#8 0x0000004f7ba4 gfx::GLApiBase::glCopyTexImage2DFn()
#9 0x000000596ac1 (anonymous namespace)::DoCopyTexImage2D()
#10 0x0000005968c4 gpu::CopyTextureCHROMIUMResourceManager::DoCopyTexture()

Original issue's description:
> gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM.
>
> It makes it possible to optimize WebGL.
>
> TEST=gl_tests GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.*
> BUG=517548
>
> Committed: https://crrev.com/fa25f0e5786527e63c6ff9aeda77da3bd7456ee3
> Cr-Commit-Position: refs/heads/master@{#347354}

TBR=piman@chromium.org,sievers@chromium.org,kbr@chromium.org,zmo@chromium.org,dongseong.hwang@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517548,528374

Review URL: https://codereview.chromium.org/1304103005

Cr-Commit-Position: refs/heads/master@{#347465}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryumiel @ltilve