-
-
Notifications
You must be signed in to change notification settings - Fork 143
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo #11
Comments
Beautiful work . |
Hey @LucasMucGH - Any idea on when we might see functionality for |
Hey @NathHorrigan, |
It will be possible with the new update to update topCornerRadius and background blur color? |
Yes, I put it on my list. Greetings Lucas |
This fixes #8 because it no longer relies on `.disabled()` as it uses `Introspect` instead. This is only a temporary solution, as i don't want to rely on other packages and as im planning to port my own UIScrollView to SwiftUI. The custom port would fix this issue and could make other features on my ToDo List (see #11) possible.
@LucasMucGH Hi Lucas, love this package, thanks for creating it. Could you share a timeframe for some of the decided features in this list? It would greatly enhance the app I'm working on. Thanks in advance. Keep up the good work :) |
Hello Arjan, im currently very busy and don’t have much time going into expanding the project. Greetings, |
I get that completely! No problem at all. Thanks anyway :) |
Hey @LucasMucGH 👋 Just wanted to say what a lovely library this is. I've been exploring a few alternatives (mostly including Apple's own new one) and this has so many awesome features in comparison to theirs 👏 Was going to raise a ticket but realised somebody raised it before me, so would love to +1 on number 15 (pull down the sheet instead of scrolling the ScrollView when at the top). I understand you're not spending too much time on this at the moment 🙂 I may look to open a PR (time permitting on my side too aha!). Awesome work regardless ❤️ |
I'd love to see the dynamic height feature! Hope it's implemented soon 🙏🏻 |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
This is a collection of features that are on my To-Do list. Each feature is briefly explained and a possible solution is described.
Any feedback for further features or comments on the features (whether they are redundant or ideas for implementation) are welcomed. No ETA is and will be provided.
Decided
Declined
swipeToDismiss
(see Adding blur background or dim #8).OptionSet
forBottomSheet.Options
OptionSet
does not work with associated values, so it can't replace my current attempt.Other
BottomSheetPosition
still do not match Apple's. I've tried countless ways, but unfortunately couldn't find out how apple calculates the height in the different states.sheetBackground
modifier still needs the View to be erased to AnyView. I have no idea how to make it better as an enum cannot have asome View
or ageneric type
.The text was updated successfully, but these errors were encountered: