Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo #11

Closed
lucaszischka opened this issue Jun 2, 2021 · 10 comments
Closed

ToDo #11

lucaszischka opened this issue Jun 2, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@lucaszischka
Copy link
Owner

lucaszischka commented Jun 2, 2021

This is a collection of features that are on my To-Do list. Each feature is briefly explained and a possible solution is described.

Any feedback for further features or comments on the features (whether they are redundant or ideas for implementation) are welcomed. No ETA is and will be provided.

Decided

  • Add support for iPad, Mac and horizontally rotated iPhones (see iPad and Horizontal Device Orientation Update  #3)
    • If you have a look at how Apple Maps displays the BottomSheet on the iPad or the iPhone when it is horizontally rotated, you will get the idea. I want to add this "floating" implementation.
  • Add an option to make the BottomSheet height dynamic to its content size (see Wrap content height #17)

Declined

  • Add threshold for swipeToDismiss (see Adding blur background or dim #8).
    • The current implementation doesn't need a threshold, because it is dynamic. It uses the flick through feature to decide when it should get dismissed.
  • Make BottomSheet not go above 100% (see Adding blur background or dim #8)
    • If the BottomSheet gets dragged above the full screen height(100%), it snaps back to the highest value in the BottomSheetPosition enum. And because no value should be above 1, it will never be unreachable.
  • Transition to OptionSet for BottomSheet.Options
    • OptionSet does not work with associated values, so it can't replace my current attempt.

Other

  • The default values of BottomSheetPosition still do not match Apple's. I've tried countless ways, but unfortunately couldn't find out how apple calculates the height in the different states.
  • The sheetBackground modifier still needs the View to be erased to AnyView. I have no idea how to make it better as an enum cannot have a some View or a generic type.
@lucaszischka lucaszischka self-assigned this Jun 2, 2021
@lucaszischka lucaszischka added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jun 2, 2021
@lucaszischka lucaszischka pinned this issue Jun 2, 2021
@lucaszischka lucaszischka mentioned this issue Jun 2, 2021
10 tasks
@TariqAlmazyad
Copy link

Beautiful work .

@lucaszischka lucaszischka changed the title ToDo List ToDo Jun 2, 2021
@NathHorrigan
Copy link

Hey @LucasMucGH - Any idea on when we might see functionality for appleScrollBehavior?

@lucaszischka
Copy link
Owner Author

Hey @NathHorrigan,
as long as i don’t find a way to prevent a ScrollView from scrolling i can’t tell you a estimated arrival time.
Greetings Lucas

@blandinf
Copy link

It will be possible with the new update to update topCornerRadius and background blur color?
Thanks for your work!

@lucaszischka
Copy link
Owner Author

It will be possible with the new update to update topCornerRadius and background blur color?

Yes, I put it on my list. Greetings Lucas

@lucaszischka lucaszischka removed the bug Something isn't working label Jul 14, 2021
lucaszischka added a commit that referenced this issue Jul 21, 2021
This fixes #8 because it no longer relies on `.disabled()` as it uses `Introspect` instead. This is only a temporary solution, as i don't want to rely on other packages and as im planning to port my own UIScrollView to SwiftUI. The custom port would fix this issue and could make other features on my ToDo List (see #11) possible.
@lucaszischka lucaszischka removed the documentation Improvements or additions to documentation label Sep 9, 2021
@dewit
Copy link

dewit commented Oct 6, 2021

@LucasMucGH Hi Lucas, love this package, thanks for creating it. Could you share a timeframe for some of the decided features in this list? It would greatly enhance the app I'm working on. Thanks in advance. Keep up the good work :)

@lucaszischka
Copy link
Owner Author

Hello Arjan,

im currently very busy and don’t have much time going into expanding the project.
I wont share a ETA because this is a project I do for fun in my free time and I don’t want to stress myself, by setting deadlines.
As soon as I have more time again I will continue expanding this project and I will add more features, but for the time being, the best option if you want to see new features is to make a pull request and adding them yourself. Sorry about that.

Greetings,
Lucas

@dewit
Copy link

dewit commented Oct 6, 2021

Hello Arjan,

im currently very busy and don’t have much time going into expanding the project. I wont share a ETA because this is a project I do for fun in my free time and I don’t want to stress myself, by setting deadlines. As soon as I have more time again I will continue expanding this project and I will add more features, but for the time being, the best option if you want to see new features is to make a pull request and adding them yourself. Sorry about that.

Greetings, Lucas

I get that completely! No problem at all. Thanks anyway :)

@Sherlouk
Copy link

Hey @LucasMucGH 👋 Just wanted to say what a lovely library this is. I've been exploring a few alternatives (mostly including Apple's own new one) and this has so many awesome features in comparison to theirs 👏

Was going to raise a ticket but realised somebody raised it before me, so would love to +1 on number 15 (pull down the sheet instead of scrolling the ScrollView when at the top). I understand you're not spending too much time on this at the moment 🙂 I may look to open a PR (time permitting on my side too aha!).

Awesome work regardless ❤️

@flowbe
Copy link

flowbe commented Jun 21, 2022

I'd love to see the dynamic height feature! Hope it's implemented soon 🙏🏻
Awesome work nonetheless!

Repository owner locked and limited conversation to collaborators Jun 26, 2022
@lucaszischka lucaszischka converted this issue into discussion #68 Jun 26, 2022
@lucaszischka lucaszischka removed their assignment Jun 26, 2022
@lucaszischka lucaszischka unpinned this issue Jun 28, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants