-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version #7
Merged
Merged
New version #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split files (ViewExtension) - Reorganised Files - New Options System (less parameter) -
- Change Resizable to notResizeable - Add noDragIndicator option
- Fix Initialiser - Fix Assets links in Readme
- Set empty array to default for options - Set nil returning closure to default for headerContent - Remove super fluent nil default
Closed
lucaszischka
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
May 23, 2021
This was referenced May 27, 2021
This was
linked to
issues
May 27, 2021
I will now merge this pull request, even if not all features have been implemented. All features that are missing are now moved to #11 and will be worked on in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a new version, where I want to implement a new options system; below are the positive and negative aspect discussed, your feedback is welcomed.
Example Syntax
Pro
showCancelButton
andcloseAction
problem, because they weren't connected them up to now (you could specify a close action without a close button XD)Contra
showCloseButton (() -> Void)
Accepted
noDragIndicator
swipeToDismiss
(see Adding blur background or dim #8)appleScrollBehavior
(see Dragging inner content #6)tapToDissmiss
(see Adding blur background or dim #8)backgroundBlur
(see Adding blur background or dim #8)sheetBackground(some View)
(see add background param as View . #9)dragIndicatorColor(Color)
(see add background param as View . #9)Undecided
Declined
dragToDismiss
(see Adding blur background or dim #8). (Reason: The current implementation doesn't need a threshold, because it is dynamic. It uses the flick through feature to decide when it should get dismissed.)