Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): fix chart naming scheme, lucide-ize appearance, et cetera #2219

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • New Icon
  • Bug fix

Description

Updates chart icons with:

  • naming guideline adhering names
  • design guideline adhering axes

Adds a few extra for missing chart types and missing, but implied icons (e.g. chart-column-decreasing to match chart-column-increasing).

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

… extra variants that were implied but missing
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Added or changed icons

icons/chart-area.svgicons/chart-bar-decreasing.svgicons/chart-bar-increasing.svgicons/chart-bar-stacked.svgicons/chart-column-big.svgicons/chart-column-increasing.svgicons/chart-column-stacked.svgicons/chart-network.svgicons/chart-no-axes-combined.svgicons/chart-spline.svgicons/chart-bar-big.svgicons/chart-bar.svgicons/chart-candlestick.svgicons/chart-column-decreasing.svgicons/chart-column.svgicons/chart-line.svgicons/chart-no-axes-column-decreasing.svgicons/chart-no-axes-column-increasing.svgicons/chart-no-axes-column.svgicons/chart-no-axes-gantt.svgicons/chart-pie.svgicons/chart-scatter.svgicons/file-chart-column-increasing.svgicons/file-chart-column.svgicons/file-chart-line.svgicons/file-chart-pie.svgicons/square-chart-gantt.svg

Preview cohesion icons/square-bottom-dashed-scissors.svgicons/square-terminal.svgicons/square-split-vertical.svgicons/square-arrow-down-right.svgicons/square-check-big.svgicons/square-menu.svgicons/message-square-plus.svgicons/square-arrow-up.svgicons/square-function.svgicons/square-scissors.svgicons/square-radical.svgicons/square-parking-off.svgicons/message-square-dashed.svgicons/message-square.svgicons/square-dot.svgicons/message-square-share.svgicons/square-plus.svgicons/square-arrow-up-right.svgicons/square-dashed-kanban.svgicons/rotate-ccw-square.svgicons/square-pi.svgicons/square-check.svgicons/square-chevron-down.svgicons/square-x.svgicons/square-slash.svgicons/square-chart-gantt.svgicons/square-arrow-out-up-right.svg
icons/chart-area.svgicons/chart-bar-decreasing.svgicons/chart-bar-increasing.svgicons/chart-bar-stacked.svgicons/chart-column-big.svgicons/chart-column-increasing.svgicons/chart-column-stacked.svgicons/chart-network.svgicons/chart-no-axes-combined.svgicons/chart-spline.svgicons/chart-bar-big.svgicons/chart-bar.svgicons/chart-candlestick.svgicons/chart-column-decreasing.svgicons/chart-column.svgicons/chart-line.svgicons/chart-no-axes-column-decreasing.svgicons/chart-no-axes-column-increasing.svgicons/chart-no-axes-column.svgicons/chart-no-axes-gantt.svgicons/chart-pie.svgicons/chart-scatter.svgicons/file-chart-column-increasing.svgicons/file-chart-column.svgicons/file-chart-line.svgicons/file-chart-pie.svgicons/square-chart-gantt.svg
icons/database-backup.svgicons/arrow-right-left.svgicons/scale.svgicons/git-branch-plus.svgicons/bug-play.svgicons/zoom-out.svgicons/play.svgicons/hand-heart.svgicons/sparkle.svgicons/iteration-cw.svgicons/gauge.svgicons/ham.svgicons/book-check.svgicons/signal-high.svgicons/circle-stop.svgicons/circle-gauge.svgicons/rocking-chair.svgicons/carrot.svgicons/tower-control.svgicons/leafy-green.svgicons/share-2.svgicons/clock-5.svgicons/align-vertical-space-between.svgicons/merge.svgicons/monitor-check.svgicons/japanese-yen.svgicons/square-pilcrow.svg
Preview stroke widths icons/chart-area.svgicons/chart-bar-decreasing.svgicons/chart-bar-increasing.svgicons/chart-bar-stacked.svgicons/chart-column-big.svgicons/chart-column-increasing.svgicons/chart-column-stacked.svgicons/chart-network.svgicons/chart-no-axes-combined.svgicons/chart-spline.svgicons/chart-bar-big.svgicons/chart-bar.svgicons/chart-candlestick.svgicons/chart-column-decreasing.svgicons/chart-column.svgicons/chart-line.svgicons/chart-no-axes-column-decreasing.svgicons/chart-no-axes-column-increasing.svgicons/chart-no-axes-column.svgicons/chart-no-axes-gantt.svgicons/chart-pie.svgicons/chart-scatter.svgicons/file-chart-column-increasing.svgicons/file-chart-column.svgicons/file-chart-line.svgicons/file-chart-pie.svgicons/square-chart-gantt.svg
icons/chart-area.svgicons/chart-bar-decreasing.svgicons/chart-bar-increasing.svgicons/chart-bar-stacked.svgicons/chart-column-big.svgicons/chart-column-increasing.svgicons/chart-column-stacked.svgicons/chart-network.svgicons/chart-no-axes-combined.svgicons/chart-spline.svgicons/chart-bar-big.svgicons/chart-bar.svgicons/chart-candlestick.svgicons/chart-column-decreasing.svgicons/chart-column.svgicons/chart-line.svgicons/chart-no-axes-column-decreasing.svgicons/chart-no-axes-column-increasing.svgicons/chart-no-axes-column.svgicons/chart-no-axes-gantt.svgicons/chart-pie.svgicons/chart-scatter.svgicons/file-chart-column-increasing.svgicons/file-chart-column.svgicons/file-chart-line.svgicons/file-chart-pie.svgicons/square-chart-gantt.svg
icons/chart-area.svgicons/chart-bar-decreasing.svgicons/chart-bar-increasing.svgicons/chart-bar-stacked.svgicons/chart-column-big.svgicons/chart-column-increasing.svgicons/chart-column-stacked.svgicons/chart-network.svgicons/chart-no-axes-combined.svgicons/chart-spline.svgicons/chart-bar-big.svgicons/chart-bar.svgicons/chart-candlestick.svgicons/chart-column-decreasing.svgicons/chart-column.svgicons/chart-line.svgicons/chart-no-axes-column-decreasing.svgicons/chart-no-axes-column-increasing.svgicons/chart-no-axes-column.svgicons/chart-no-axes-gantt.svgicons/chart-pie.svgicons/chart-scatter.svgicons/file-chart-column-increasing.svgicons/file-chart-column.svgicons/file-chart-line.svgicons/file-chart-pie.svgicons/square-chart-gantt.svg
DPI Preview (24px) icons/chart-area.svg

@github-actions github-actions bot removed the Stale label Jul 20, 2024
],
"aliases": [
{
"name": "file-line-chart",
Copy link
Member

@ericfennis ericfennis Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is git confused again? The aliases aren't matching the renaming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm afraid. 😅

@karsa-mistmere karsa-mistmere merged commit 18d1836 into main Jul 22, 2024
8 checks passed
@karsa-mistmere karsa-mistmere deleted the icon/charts branch July 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants